Re: [OpenWrt-Devel] [PATCH] ramips: enable additional GPIOs on HAME MPR-A1

2014-08-09 Thread Paul Fertser
On Fri, Aug 08, 2014 at 08:17:05PM +0400, Paul Fertser wrote:
 --- a/target/linux/ramips/dts/MPRA1.dts
 +++ b/target/linux/ramips/dts/MPRA1.dts
 @@ -41,12 +41,15 @@
   };
   };
   };
 + gpio1: gpio@660 {
 + status = okay;
 + };

What I still do not understand is why it must be disabled by default
(in rt5350.dts)?  It's not like it affects the leds (or spi cs1)
operation anyhow unless it's set to gpio in pinctrl?

-- 
Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
mailto:fercer...@gmail.com
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH] ramips: enable additional GPIOs on HAME MPR-A1

2014-08-09 Thread Álvaro Fernández Rojas
It's disabled because gpio1 is only used for ethernet LEDs and SPI_CS1.
Since most RT5350 use those LEDs for ethernet and have them configured by the 
bootloader, there's no need in enabling and reconfiguring them on all boards.

El 09/08/2014 15:35, Paul Fertser escribió:
 On Fri, Aug 08, 2014 at 08:17:05PM +0400, Paul Fertser wrote:
 --- a/target/linux/ramips/dts/MPRA1.dts
 +++ b/target/linux/ramips/dts/MPRA1.dts
 @@ -41,12 +41,15 @@
  };
  };
  };
 +gpio1: gpio@660 {
 +status = okay;
 +};
 
 What I still do not understand is why it must be disabled by default
 (in rt5350.dts)?  It's not like it affects the leds (or spi cs1)
 operation anyhow unless it's set to gpio in pinctrl?
 
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH] ramips: enable additional GPIOs on HAME MPR-A1

2014-08-09 Thread Paul Fertser
On Sat, Aug 09, 2014 at 03:51:17PM +0200, Álvaro Fernández Rojas wrote:
 Since most RT5350 use those LEDs for ethernet and have
 them configured by the bootloader, there's no need in enabling and
 reconfiguring them on all boards.

Do you mean the current gpio driver will reconfigure them somehow even
if they're not enabled in pinctrl? Also (even if so), does it matter
if the pads are still muxed to their functions (and not gpio)?

-- 
Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
mailto:fercer...@gmail.com
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel


Re: [OpenWrt-Devel] [PATCH] ramips: enable additional GPIOs on HAME MPR-A1

2014-08-08 Thread Paul Fertser
On Fri, Aug 08, 2014 at 06:32:15PM +0200, Álvaro Fernández Rojas wrote:
 If you also add spi_cs1 GPIO#27 will be exposed.
 This was added on https://dev.openwrt.org/changeset/41938 for VoCore.

Yes, but it's not routed from under the SoC, unfortunately, so there's
no reason to do it.

-- 
Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
mailto:fercer...@gmail.com
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel