Re: [OpenWrt-Devel] [PATCH] x86: disable kmod-drm-radeon and kmod-drm-amdgpu for geode
On 09.04.2019 01:28, Tomasz Maciej Nowak wrote: W dniu 08.04.2019 o 23:56, Lucian Cristian pisze: On 08.04.2019 20:19, Tomasz Maciej Nowak wrote: Hi Petr, Alberto, W dniu 08.04.2019 o 14:34, Alberto Bursi pisze: On 08/04/19 11:42, Petr Štetiar wrote: Tomasz Maciej Nowak [2019-04-07 18:35:01]: Hi, thanks for trying to unbreak currently failing Geode builds. Building images for geode has been failing because of missing dependencies: backlight.ko drm_kms_helper.ko fb.ko ttm.ko Being geode a speciffic hardware, where drm-radeon and drm-amdgpu modules will probably never be used, disable both. Fixing the kernel module dependencies is PITA, I know, but this simply doesn't look like a proper fix to me, rather just like a workaround. Yes, adding those modules to dependencies would solve the issue, but for how long? If AMD people would decide to add another module to dependencies, we would need to fix it again and fix something not one would ever use on this target, only for the sake of it? Sorry, I may have sounded harsh and triggered here, that was not my intention. I'm fine with either, but please do consider that with other solution that may not be the final one for the future. -- ynezz It is indeed a workaround, but is it worth to spend time troubleshooting something that is never going to be used? I don't see why these modules were built at all. It's pretty hard or even impossible to run any addon graphics card on a Geode system. At most they have PCI slots, many (the networking alix boards from PCEngines) only have mini PCI slots. drm-amdgpu will 100% never be used as it runs modern PCIe cards. I don't find any good reason to mount an ancient AMD card over a PCI slot (or mini pci slot + adapter) as they have their own integrated graphics with a VGA port already. -Alberto Thanks, this is more or less what I had in mind deciding how to approach this, and form this POV calling it workaround is debatable. I'll leave patch in this form, if anyone wants to take different approach, please do. Regards Because I crashed that, if your approach is not accepted I'll add the module dependencies, I didn't put them in the generic config because I also thought it will only be used on modern hardware Thanks, please do. Regards Lucian Regards FYI https://github.com/openwrt/openwrt/pull/1981 Regards ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] x86: disable kmod-drm-radeon and kmod-drm-amdgpu for geode
W dniu 08.04.2019 o 23:56, Lucian Cristian pisze: > On 08.04.2019 20:19, Tomasz Maciej Nowak wrote: >> Hi Petr, Alberto, >> >> W dniu 08.04.2019 o 14:34, Alberto Bursi pisze: >>> On 08/04/19 11:42, Petr Štetiar wrote: Tomasz Maciej Nowak [2019-04-07 18:35:01]: Hi, thanks for trying to unbreak currently failing Geode builds. > Building images for geode has been failing because of missing > dependencies: > backlight.ko > drm_kms_helper.ko > fb.ko > ttm.ko > Being geode a speciffic hardware, where drm-radeon and drm-amdgpu modules > will probably never be used, disable both. Fixing the kernel module dependencies is PITA, I know, but this simply doesn't look like a proper fix to me, rather just like a workaround. >> Yes, adding those modules to dependencies would solve the issue, but for how >> long? If AMD people would decide to add another module to dependencies, we >> would need to fix it again and fix something not one would ever use on this >> target, only for the sake of it? Sorry, I may have sounded harsh and triggered here, that was not my intention. I'm fine with either, but please do consider that with other solution that may not be the final one for the future. >> -- ynezz >>> It is indeed a workaround, but is it worth to spend time troubleshooting >>> something that is never going to be used? >>> >>> I don't see why these modules were built at all. It's pretty hard or even >>> impossible >>> to run any addon graphics card on a Geode system. >>> >>> At most they have PCI slots, many (the networking alix boards from >>> PCEngines) only have mini PCI slots. >>> >>> drm-amdgpu will 100% never be used as it runs modern PCIe cards. >>> >>> I don't find any good reason to mount an ancient AMD card over a >>> PCI slot (or mini pci slot + adapter) as they have their own integrated >>> graphics with a VGA port already. >>> >>> -Alberto >> Thanks, this is more or less what I had in mind deciding how to approach >> this, and form this POV calling it workaround is debatable. I'll leave patch >> in this form, if anyone wants to take different approach, please do. >> >> Regards >> > Because I crashed that, if your approach is not accepted I'll add the module > dependencies, I didn't put them in the generic config because I also thought > it will only be used on modern hardware Thanks, please do. > > Regards > > Lucian Regards -- TMN ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] x86: disable kmod-drm-radeon and kmod-drm-amdgpu for geode
On 08.04.2019 20:19, Tomasz Maciej Nowak wrote: Hi Petr, Alberto, W dniu 08.04.2019 o 14:34, Alberto Bursi pisze: On 08/04/19 11:42, Petr Štetiar wrote: Tomasz Maciej Nowak [2019-04-07 18:35:01]: Hi, thanks for trying to unbreak currently failing Geode builds. Building images for geode has been failing because of missing dependencies: backlight.ko drm_kms_helper.ko fb.ko ttm.ko Being geode a speciffic hardware, where drm-radeon and drm-amdgpu modules will probably never be used, disable both. Fixing the kernel module dependencies is PITA, I know, but this simply doesn't look like a proper fix to me, rather just like a workaround. Yes, adding those modules to dependencies would solve the issue, but for how long? If AMD people would decide to add another module to dependencies, we would need to fix it again and fix something not one would ever use on this target, only for the sake of it? -- ynezz It is indeed a workaround, but is it worth to spend time troubleshooting something that is never going to be used? I don't see why these modules were built at all. It's pretty hard or even impossible to run any addon graphics card on a Geode system. At most they have PCI slots, many (the networking alix boards from PCEngines) only have mini PCI slots. drm-amdgpu will 100% never be used as it runs modern PCIe cards. I don't find any good reason to mount an ancient AMD card over a PCI slot (or mini pci slot + adapter) as they have their own integrated graphics with a VGA port already. -Alberto Thanks, this is more or less what I had in mind deciding how to approach this, and form this POV calling it workaround is debatable. I'll leave patch in this form, if anyone wants to take different approach, please do. Regards Because I crashed that, if your approach is not accepted I'll add the module dependencies, I didn't put them in the generic config because I also thought it will only be used on modern hardware Regards Lucian ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] x86: disable kmod-drm-radeon and kmod-drm-amdgpu for geode
Hi Petr, Alberto, W dniu 08.04.2019 o 14:34, Alberto Bursi pisze: > > On 08/04/19 11:42, Petr Štetiar wrote: >> Tomasz Maciej Nowak [2019-04-07 18:35:01]: >> >> Hi, >> >> thanks for trying to unbreak currently failing Geode builds. >> >>> Building images for geode has been failing because of missing >>> dependencies: >>> backlight.ko >>> drm_kms_helper.ko >>> fb.ko >>> ttm.ko >>> Being geode a speciffic hardware, where drm-radeon and drm-amdgpu modules >>> will probably never be used, disable both. >> Fixing the kernel module dependencies is PITA, I know, but this simply >> doesn't >> look like a proper fix to me, rather just like a workaround. Yes, adding those modules to dependencies would solve the issue, but for how long? If AMD people would decide to add another module to dependencies, we would need to fix it again and fix something not one would ever use on this target, only for the sake of it? >> >> -- ynezz >> >> > It is indeed a workaround, but is it worth to spend time troubleshooting > something that is never going to be used? > > I don't see why these modules were built at all. It's pretty hard or even > impossible > to run any addon graphics card on a Geode system. > > At most they have PCI slots, many (the networking alix boards from PCEngines) > only have mini PCI slots. > > drm-amdgpu will 100% never be used as it runs modern PCIe cards. > > I don't find any good reason to mount an ancient AMD card over a > PCI slot (or mini pci slot + adapter) as they have their own integrated > graphics with a VGA port already. > > -Alberto Thanks, this is more or less what I had in mind deciding how to approach this, and form this POV calling it workaround is debatable. I'll leave patch in this form, if anyone wants to take different approach, please do. Regards -- TMN ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] x86: disable kmod-drm-radeon and kmod-drm-amdgpu for geode
On 08/04/19 11:42, Petr Štetiar wrote: Tomasz Maciej Nowak [2019-04-07 18:35:01]: Hi, thanks for trying to unbreak currently failing Geode builds. Building images for geode has been failing because of missing dependencies: backlight.ko drm_kms_helper.ko fb.ko ttm.ko Being geode a speciffic hardware, where drm-radeon and drm-amdgpu modules will probably never be used, disable both. Fixing the kernel module dependencies is PITA, I know, but this simply doesn't look like a proper fix to me, rather just like a workaround. -- ynezz It is indeed a workaround, but is it worth to spend time troubleshooting something that is never going to be used? I don't see why these modules were built at all. It's pretty hard or even impossible to run any addon graphics card on a Geode system. At most they have PCI slots, many (the networking alix boards from PCEngines) only have mini PCI slots. drm-amdgpu will 100% never be used as it runs modern PCIe cards. I don't find any good reason to mount an ancient AMD card over a PCI slot (or mini pci slot + adapter) as they have their own integrated graphics with a VGA port already. -Alberto ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] x86: disable kmod-drm-radeon and kmod-drm-amdgpu for geode
Tomasz Maciej Nowak [2019-04-07 18:35:01]: Hi, thanks for trying to unbreak currently failing Geode builds. > Building images for geode has been failing because of missing > dependencies: > backlight.ko > drm_kms_helper.ko > fb.ko > ttm.ko > Being geode a speciffic hardware, where drm-radeon and drm-amdgpu modules > will probably never be used, disable both. Fixing the kernel module dependencies is PITA, I know, but this simply doesn't look like a proper fix to me, rather just like a workaround. -- ynezz ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[OpenWrt-Devel] [PATCH] x86: disable kmod-drm-radeon and kmod-drm-amdgpu for geode
Building images for geode has been failing because of missing
dependencies:
backlight.ko
drm_kms_helper.ko
fb.ko
ttm.ko
Being geode a speciffic hardware, where drm-radeon and drm-amdgpu modules
will probably never be used, disable both.
Fixes: 2f239c0 ("x86: video: add amdgpu DRM kernel package")
Fixes: 2f6918e ("x86: video: add radeon DRM module support")
Signed-off-by: Tomasz Maciej Nowak
---
package/kernel/linux/modules/video.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/kernel/linux/modules/video.mk
b/package/kernel/linux/modules/video.mk
index f11431dc2d..9814cb0bde 100644
--- a/package/kernel/linux/modules/video.mk
+++ b/package/kernel/linux/modules/video.mk
@@ -242,7 +242,7 @@ $(eval $(call KernelPackage,drm))
define KernelPackage/drm-amdgpu
SUBMENU:=$(VIDEO_MENU)
TITLE:=AMDGPU DRM support
- DEPENDS:=@TARGET_x86 @DISPLAY_SUPPORT +kmod-drm +kmod-i2c-algo-bit
+amdgpu-firmware
+ DEPENDS:=@TARGET_x86 @!TARGET_x86_geode @DISPLAY_SUPPORT +kmod-drm
+kmod-i2c-algo-bit +amdgpu-firmware
KCONFIG:=CONFIG_DRM_AMDGPU \
CONFIG_DRM_AMDGPU_SI=y \
CONFIG_DRM_AMDGPU_CIK=y \
@@ -342,7 +342,7 @@ $(eval $(call KernelPackage,drm-imx-ldb))
define KernelPackage/drm-radeon
SUBMENU:=$(VIDEO_MENU)
TITLE:=Radeon DRM support
- DEPENDS:=@TARGET_x86 @DISPLAY_SUPPORT +kmod-drm +kmod-i2c-algo-bit
+radeon-firmware
+ DEPENDS:=@TARGET_x86 @!TARGET_x86_geode @DISPLAY_SUPPORT +kmod-drm
+kmod-i2c-algo-bit +radeon-firmware
KCONFIG:=CONFIG_DRM_RADEON
FILES:=$(LINUX_DIR)/drivers/gpu/drm/radeon/radeon.ko
AUTOLOAD:=$(call AutoProbe,radeon)
--
2.21.0
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
