Re: [OpenWrt-Devel] [PATCH 00/13] ramips: massive code cleanups

2015-07-30 Thread Piotr Dymacz 
2015-07-30 14:24 GMT+02:00 John Crispin blo...@openwrt.org:
[...]

 big diff stat. i like it. can you do the same for lantiq ? :)

Maybe... and ar71xx too? ;)

 i will stop merging new board to ramips target untilt his series is in
 the tree to save you having to rebase too often.

OK.

 when can we expect a v2 ?

There was a discussion about upstream LED naming convention and this patch:
[PATCH 05/13] ramips: use consistent naming scheme for LEDs, for
various manufacturers

I sent my idea about diag.sh and 01_leds scripts optimization, but it
hasn't got any positive or negative feedback yet... so I decided to
wait.

I want to reorder my patches in v2 series (move other small changes in
the front of that LED naming related stuff, so eventually they can be
omitted without breaking other changes).
I should be able to prepare v2 during the weekend.

 how do you create the patch ? i am a bit worried that cp bugs or similar can 
 sneak in.

In some cases by hand... in other, using available tools (sed, awk,
grep, git grep etc.).

My original series contained more than 30 patches (one change = one
commit) and I verified every single one.
I merged logically related commits into one change before sending whole series.

I hope I didn't make more bugs than I'm trying to fix.

Piotr
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH 00/13] ramips: massive code cleanups

2015-07-30 Thread John Crispin 


On 26/07/2015 18:24, Piotr Dymacz wrote:
 The following changes fix different mistakes in ramips target and
 try to make the code more clean and consistent.
 
 The patches affect:
  * dts{,i} files
  * base-files/* scripts
  * image Makefile
 
 Piotr Dymacz (13):
   ramips: fix indentation and other mistakes in .dts{,i} files
   ramips: remove leading spaces and sort boards alphabetically in
 base-files/lib/ramips.sh
   ramips: fix indentation, case statements structure and optimize
 base-files/etc/board.d/* scripts
   ramips: sort boards alphabetically and optimize
 base-files/etc/{diag.sh,board.d/*} scripts
   ramips: use consistent naming scheme for LEDs, for various
 manufacturers
   ramips: fix UPVEL model names
   ramips: change board name for Zbtlink WR8305RT to ZBT-WR8305RT
   ramips: remove unnecessary LED declaration for WT1520 in diag.sh
   ramips: use consistent naming scheme for LEDs in the remaining,
 branded devices
   ramips: change board name for Asus WL-330N{,3G} to WL-330N{,3G}
   ramips: rename dts file for Asus RT-N56U to RT-N56U.dts
   ramips: be consistent with case statement in
 base-files/lib/upgrade/platform.sh
   ramips: fix image name for Belkin F7C027

big diff stat. i like it. can you do the same for lantiq ? :)

i will stop merging new board to ramips target untilt his series is in
the tree to save you having to rebase too often.

when can we expect a v2 ? how do you create the patch ? i am a bit
worried that cp bugs or similar can sneak in.

John

 
  target/linux/ramips/base-files/etc/board.d/01_leds | 496 
 ++---
  .../linux/ramips/base-files/etc/board.d/02_network | 398 -
  target/linux/ramips/base-files/etc/diag.sh | 207 +
  target/linux/ramips/base-files/lib/ramips.sh   | 288 ++--
  .../ramips/base-files/lib/upgrade/platform.sh  | 234 +-
  target/linux/ramips/dts/ALL0239-3G.dts |   8 +-
  target/linux/ramips/dts/ALL0256N-4M.dts|   6 +-
  target/linux/ramips/dts/ALL0256N-8M.dts|   6 +-
  target/linux/ramips/dts/AR670W.dts |   4 +-
  target/linux/ramips/dts/AR725W.dts |   6 +-
  target/linux/ramips/dts/ARGUS_ATP52B.dts   |   4 +-
  target/linux/ramips/dts/ASL26555-16M.dts   |  16 +-
  target/linux/ramips/dts/ASL26555-8M.dts|  16 +-
  target/linux/ramips/dts/AWAPN2403.dts  |   2 +-
  target/linux/ramips/dts/AWM002-EVB-4M.dts  |   6 +-
  target/linux/ramips/dts/AWM002-EVB-8M.dts  |   6 +-
  target/linux/ramips/dts/AWM003-EVB.dts |   6 +-
  target/linux/ramips/dts/BC2.dts|   2 +-
  target/linux/ramips/dts/BROADWAY.dts   |   4 +-
  target/linux/ramips/dts/CF-WR800N.dts  |  24 +-
  target/linux/ramips/dts/D105.dts   |   4 +-
  target/linux/ramips/dts/DCS-930L-B1.dts|   2 +-
  target/linux/ramips/dts/DIR-300-B7.dts |  65 ++-
  target/linux/ramips/dts/DIR-320-B1.dts |  20 +-
  target/linux/ramips/dts/DIR-610-A1.dts |  20 +-
  target/linux/ramips/dts/ESR-9753.dts   |   4 +-
  target/linux/ramips/dts/F5D8235_V1.dts |   6 +-
  target/linux/ramips/dts/F5D8235_V2.dts |  18 +-
  target/linux/ramips/dts/FONERA20N.dts  |   6 +-
  target/linux/ramips/dts/FREESTATION5.dts   |   6 +-
  target/linux/ramips/dts/HG255D.dts |  12 +-
  target/linux/ramips/dts/HLKRM04.dts|   2 +-
  target/linux/ramips/dts/HT-TM02.dts|   4 +-
  target/linux/ramips/dts/HW550-3G.dts   |   8 +-
  target/linux/ramips/dts/IP2202.dts |   4 +-
  target/linux/ramips/dts/M2M.dts|   4 +-
  target/linux/ramips/dts/M3.dts |   2 +-
  target/linux/ramips/dts/M4-4M.dts  |   2 +-
  target/linux/ramips/dts/M4-8M.dts  |   2 +-
  target/linux/ramips/dts/MOFI3500-3GN.dts   |   8 +-
  target/linux/ramips/dts/MR-102N.dts|   6 +-
  target/linux/ramips/dts/MZK-750DHP.dts |   4 +-
  target/linux/ramips/dts/MZK-DP150N.dts |   2 +-
  target/linux/ramips/dts/MZK-W300NH2.dts|   6 +-
  target/linux/ramips/dts/MicroWRT.dts   |   2 +-
  target/linux/ramips/dts/NA930.dts  |   8 +-
  target/linux/ramips/dts/NBG-419N.dts   |   4 +-
  target/linux/ramips/dts/NCS601W.dts|   4 +-
  target/linux/ramips/dts/NW718.dts  |   6 +-
  target/linux/ramips/dts/OLINUXINO-RT5350F-EVB.dts  | 190 
  target/linux/ramips/dts/OLINUXINO-RT5350F.dts  | 122 ++---
  target/linux/ramips/dts/OMNI-EMB-HPM.dts   |  12 +-
  target/linux/ramips/dts/OMNI-EMB.dts   |   4 +-
  target/linux/ramips/dts/OMNI-PLUG.dts  |   4 +-
  target/linux/ramips/dts/OY-0001.dts