Re: [OpenWrt-Devel] [PATCH 3/5] [packages] libjpeg-turbo: fix binary names to match what is built

2013-01-19 Thread Daniel Petre 
btw: mjpg-streamer looks to me a bit smoother with libjpeg-turbo than libjpeg, 
the only drawback is l-t is a little bigger than the old lib..

On Jan 19, 2013, at 6:13 PM, Russell Senior  wrote:

>> "Ian" == Ian Leonard  writes:
> 
>>> Signed-off-by: Russell Senior 
>>> PKG_NAME:=libjpeg-turbo PKG_VERSION:=1.2.1 -PKG_RELEASE:=1
>>> +PKG_RELEASE:=2
> 
>>> define Package/jpeg-tools/install $(INSTALL_DIR) $(1)/usr/bin
>>> $(INSTALL_BIN) $(PKG_BUILD_DIR)/.libs/{c,d}jpeg $(1)/usr/bin/ -
>>> $(INSTALL_BIN) $(PKG_BUILD_DIR)/.libs/jpeg{tran,gut} $(1)/usr/bin/
>>> + $(INSTALL_BIN) $(PKG_BUILD_DIR)/.libs/jpegtran $(1)/usr/bin/
>>> $(INSTALL_BIN) $(PKG_BUILD_DIR)/.libs/{rd,wr}jpgcom $(1)/usr/bin/ -
>>> $(INSTALL_BIN) $(PKG_BUILD_DIR)/.libs/jpgtest $(1)/usr/bin/ +
>>> $(INSTALL_BIN) $(PKG_BUILD_DIR)/.libs/jcstest $(1)/usr/bin/
> 
> Ian> Looks good to me.
> 
> I just found the change to the binary names in the libjpeg-turbo SVN
> repository in r643.  The binary jpeggut was actually jpegut (where ut
> stands for unit test), and was renamed to tjunittest.  jpegtest became
> tjbench.  Arguably, tjunittest shouldn't be installed anyway.
> Makefile.am lists it in noinst_PROGRAM.  Or perhaps it should only be
> installed in a separate testing/debugging package.
> 
> jcstest stands for jpeg color space extentions tests, see r733.  Maybe
> should go into the separate testing/debugging package.
> 
> I'll try to whip up a better patch.
> 
> I don't use this package but, to quote David Woodhouse, "it offended
> me by not building".
> 
> 
> -- 
> Russell Senior, President
> russ...@personaltelco.net
> ___
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH 3/5] [packages] libjpeg-turbo: fix binary names to match what is built

2013-01-19 Thread Russell Senior 
> "Ian" == Ian Leonard  writes:

>> Signed-off-by: Russell Senior 
>> PKG_NAME:=libjpeg-turbo PKG_VERSION:=1.2.1 -PKG_RELEASE:=1
>> +PKG_RELEASE:=2

>> define Package/jpeg-tools/install $(INSTALL_DIR) $(1)/usr/bin
>> $(INSTALL_BIN) $(PKG_BUILD_DIR)/.libs/{c,d}jpeg $(1)/usr/bin/ -
>> $(INSTALL_BIN) $(PKG_BUILD_DIR)/.libs/jpeg{tran,gut} $(1)/usr/bin/
>> + $(INSTALL_BIN) $(PKG_BUILD_DIR)/.libs/jpegtran $(1)/usr/bin/
>> $(INSTALL_BIN) $(PKG_BUILD_DIR)/.libs/{rd,wr}jpgcom $(1)/usr/bin/ -
>> $(INSTALL_BIN) $(PKG_BUILD_DIR)/.libs/jpgtest $(1)/usr/bin/ +
>> $(INSTALL_BIN) $(PKG_BUILD_DIR)/.libs/jcstest $(1)/usr/bin/

Ian> Looks good to me.

I just found the change to the binary names in the libjpeg-turbo SVN
repository in r643.  The binary jpeggut was actually jpegut (where ut
stands for unit test), and was renamed to tjunittest.  jpegtest became
tjbench.  Arguably, tjunittest shouldn't be installed anyway.
Makefile.am lists it in noinst_PROGRAM.  Or perhaps it should only be
installed in a separate testing/debugging package.

jcstest stands for jpeg color space extentions tests, see r733.  Maybe
should go into the separate testing/debugging package.

I'll try to whip up a better patch.

I don't use this package but, to quote David Woodhouse, "it offended
me by not building".


-- 
Russell Senior, President
russ...@personaltelco.net
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH 3/5] [packages] libjpeg-turbo: fix binary names to match what is built

2013-01-19 Thread Ian Leonard 
> Signed-off-by: Russell Senior 
>  PKG_NAME:=libjpeg-turbo
>  PKG_VERSION:=1.2.1
> -PKG_RELEASE:=1
> +PKG_RELEASE:=2

>  define Package/jpeg-tools/install
>   $(INSTALL_DIR) $(1)/usr/bin
>   $(INSTALL_BIN) $(PKG_BUILD_DIR)/.libs/{c,d}jpeg $(1)/usr/bin/
> - $(INSTALL_BIN) $(PKG_BUILD_DIR)/.libs/jpeg{tran,gut} $(1)/usr/bin/
> + $(INSTALL_BIN) $(PKG_BUILD_DIR)/.libs/jpegtran $(1)/usr/bin/
>   $(INSTALL_BIN) $(PKG_BUILD_DIR)/.libs/{rd,wr}jpgcom $(1)/usr/bin/
> - $(INSTALL_BIN) $(PKG_BUILD_DIR)/.libs/jpgtest $(1)/usr/bin/
> + $(INSTALL_BIN) $(PKG_BUILD_DIR)/.libs/jcstest $(1)/usr/bin/

Looks good to me.

-Ian
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

[OpenWrt-Devel] [PATCH 3/5] [packages] libjpeg-turbo: fix binary names to match what is built

2013-01-17 Thread Russell Senior 

Signed-off-by: Russell Senior 
---
 libs/libjpeg-turbo/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/libs/libjpeg-turbo/Makefile b/libs/libjpeg-turbo/Makefile
index 9ae15a6..6adbe84 100644
--- a/libs/libjpeg-turbo/Makefile
+++ b/libs/libjpeg-turbo/Makefile
@@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk
 
 PKG_NAME:=libjpeg-turbo
 PKG_VERSION:=1.2.1
-PKG_RELEASE:=1
+PKG_RELEASE:=2
 
 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
 PKG_SOURCE_URL:=@SF/libjpeg-turbo
@@ -75,9 +75,9 @@ endef
 define Package/jpeg-tools/install
$(INSTALL_DIR) $(1)/usr/bin
$(INSTALL_BIN) $(PKG_BUILD_DIR)/.libs/{c,d}jpeg $(1)/usr/bin/
-   $(INSTALL_BIN) $(PKG_BUILD_DIR)/.libs/jpeg{tran,gut} $(1)/usr/bin/
+   $(INSTALL_BIN) $(PKG_BUILD_DIR)/.libs/jpegtran $(1)/usr/bin/
$(INSTALL_BIN) $(PKG_BUILD_DIR)/.libs/{rd,wr}jpgcom $(1)/usr/bin/
-   $(INSTALL_BIN) $(PKG_BUILD_DIR)/.libs/jpgtest $(1)/usr/bin/
+   $(INSTALL_BIN) $(PKG_BUILD_DIR)/.libs/jcstest $(1)/usr/bin/
 endef
 
 $(eval $(call HostBuild))
-- 
1.7.12


-- 
Russell Senior, President
russ...@personaltelco.net
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel