[OpenWrt-Devel] [PATCH v3] brcm-wl: fix bash comparison error

2014-10-17 Thread Álvaro Fernández Rojas 
wlc returns a string number ending with \n, making it impossible to compare 
this value to a number.

Signed-off-by: Álvaro Fernández Rojas nolt...@gmail.com
---
v3: avoid using an extra variable.
v2: use string comparison.

diff --git a/package/kernel/broadcom-wl/files/lib/wifi/broadcom.sh 
b/package/kernel/broadcom-wl/files/lib/wifi/broadcom.sh
index 69e3132..5994e26 100644
--- a/package/kernel/broadcom-wl/files/lib/wifi/broadcom.sh
+++ b/package/kernel/broadcom-wl/files/lib/wifi/broadcom.sh
@@ -209,7 +209,7 @@ enable_broadcom() {
}
 
local leddc=$(wlc ifname $device leddc)
-   [ $leddc -eq 0x ] || {
+   [ $leddc == 0x\n ] || {
leddc=0x005a000a;
}
 
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH v3] brcm-wl: fix bash comparison error

2014-10-17 Thread Bastian Bittorf 
* Álvaro Fernández Rojas nolt...@gmail.com [17.10.2014 15:11]:
 - [ $leddc -eq 0x ] || {
 + [ $leddc == 0x\n ] || {

this is a bashism, use:
[ $leddc = '0x\n' ] || {

bye, bastian
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel