Re: [OpenWrt-Devel] Preinit fixes
> As for improving the docs...While docs can always be better, I prefer > development, and I think I've already greatly improved the state of > documentation compared to what it was, as far as preinit goes. I'm sorry if my posts came thorugh as requests for you to improve the doc. I haven't looked closely at your changes, but they seem great. Next time I built a new firmware, I'll have a chance to check it more closely (I've been using local patches for ide-root on wl-700ge, so hopefully that won't be needed any more, or at least will be done more cleanly). > It's on the wiki, so if you feel you understand the code well enough to > improve it or the documention, please feel free to do so. I'm pretty Actually the questions in the previous message were truly questions to which I do not know the answer (even though I have spent some time through /sbin/mount_root and friends to figure out where to put my patch to get ide-root working). Stefan ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Preinit fixes
> satisfied with the work I've done, and while there may be some things > that need changing, or bugs fixed, I'm moving on to other things (as Jo To clarify I mean that except for the things that need changing, or bugs fixed, I'm moving on to other thing. Regards, Daniel -- And that's my crabbing done for the day. Got it out of the way early, now I have the rest of the afternoon to sniff fragrant tea-roses or strangle cute bunnies or something. -- Michael Devore GnuPG Key Fingerprint 86 F5 81 A5 D4 2E 1F 1C http://gnupg.org The C Shore (Daniel Dickinson's Website) http://cshore.is-a-geek.com signature.asc Description: This is a digitally signed message part ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Preinit fixes
On Tue, 2010-01-26 at 21:09 -0500, Stefan Monnier wrote: > > See, http://cshore.is-a-geek.com/openwrt/preinit_mount.html > > It's fully documented along with an example. > > Thanks. It's much better, but it still leaves several questions open: The doc is now on the wiki. Feel free to improve it as you can. It's at http://wiki.openwrt.org/doc/techref/preinit_mount Except for the modularization the preinit does the same thing, with the same code, as the previous preinit. I didn't change anything, except to make it modular, because the goal was a drop in replacement that would add a feature (ability to do addons) without causing devs or users to have to do anything (to the extent possible...preinit replacement obviously will have to be rewritten, but that would happen when there were any preinit changes, and now that should happen less often). Point is, complaints about how preinit works would have applied without these changes. Of course I think now it's easier to change certain bits. If you have specific thing you'd like to see changed file a ticket (or post to this list), preferably with patches. As for improving the docs...While docs can always be better, I prefer development, and I think I've already greatly improved the state of documentation compared to what it was, as far as preinit goes. It's on the wiki, so if you feel you understand the code well enough to improve it or the documention, please feel free to do so. I'm pretty satisfied with the work I've done, and while there may be some things that need changing, or bugs fixed, I'm moving on to other things (as Jo put it, "a router should route, not boot, if you know what I mean"). As always if you care about something I haven't worked on, well constructed patches and documentation changes are always welcome. -- And that's my crabbing done for the day. Got it out of the way early, now I have the rest of the afternoon to sniff fragrant tea-roses or strangle cute bunnies or something. -- Michael Devore GnuPG Key Fingerprint 86 F5 81 A5 D4 2E 1F 1C http://gnupg.org The C Shore (Daniel Dickinson's Website) http://cshore.is-a-geek.com signature.asc Description: This is a digitally signed message part ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Preinit fixes
> See, http://cshore.is-a-geek.com/openwrt/preinit_mount.html > It's fully documented along with an example. Thanks. It's much better, but it still leaves several questions open: - where is the "failsafe" code (it has its own subsection in the doc, but it doesn't say to which file it corresponds). - same thing for "mount root filesystem". - the "mount root filesystem" paraphrases the code without explaining the underlying design. E.g. it would be helpful to state the "preconditions" and "postconditions", i.e. what is the expected input state and what is the expected output state. - first boot also paraphrases the code. Here again stating the expected input state and resulting output state would help. Some of the relevant "state" could be for example be whether udev (aka hotplug) is expected to be running before/after. - Actually the fact that firstboot can be called in different ways and behaves differently for each seems terribly odd and confusing, so either it should be split into different files, or there should be some explanation for why it's all kept within that single file. -- Stefan ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Preinit fixes
On Tue, 2010-01-26 at 14:19 +0100, Luigi 'Comio' Mantellini wrote: > Hi All, > > Hi Daniel, > > thanks for this improvement. > > I have just a request from the documentation point of view: can anyone > formalize a document with the init sequence, the hooks that can be > used and any other useful information to customize the init process. I > know that the source code is better a document... but I formal > document can be easily reviewed in order to have a standard. > Have you seen http://wiki.openwrt.org/doc/techref/preinit_mount ? -- And that's my crabbing done for the day. Got it out of the way early, now I have the rest of the afternoon to sniff fragrant tea-roses or strangle cute bunnies or something. -- Michael Devore GnuPG Key Fingerprint 86 F5 81 A5 D4 2E 1F 1C http://gnupg.org The C Shore (Daniel Dickinson's Website) http://cshore.is-a-geek.com signature.asc Description: This is a digitally signed message part ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Preinit fixes
On Tue, Jan 26, 2010 at 10:59:53AM -0800, Marc Abrams wrote: > Otto: > > I don't think so currently, but it should be pretty easy to add. Currently > the main development branch for brcm63xx uses 2.6.30.10. > > marc. Ok, hopefully all platforms will switch to 2.6.32 as it is a long term release by the stable kernel maintainer. Your, - Otto > On Tue, Jan 26, 2010 at 10:54 AM, Otto Solares wrote: > > > On Tue, Jan 26, 2010 at 07:28:18AM -0800, Marc Abrams wrote: > > > See, http://cshore.is-a-geek.com/openwrt/preinit_mount.html > > > > > > It's fully documented along with an example. > > > > Hi Marc, > > > > I read the following: > > > > Preinit > > 3. Initializes device tree (/dev) > > > > Does that takes into account the new devtmpfs on 2.6.32+? > > > > My WRT160NL with OpenWRT, 2.6.32 kernel and trunk before your code's > > commit reads: > > > > devtmpfs on /dev type devtmpfs (rw,size=14692k,nr_inodes=3673) > > > > I think it was mounted automagically by the kernel himself like old > > devfs. > > > > Regards, > > - > > Otto > > ___ > > openwrt-devel mailing list > > openwrt-devel@lists.openwrt.org > > https://lists.openwrt.org/mailman/listinfo/openwrt-devel > > > ___ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Preinit fixes
Otto: I don't think so currently, but it should be pretty easy to add. Currently the main development branch for brcm63xx uses 2.6.30.10. marc. On Tue, Jan 26, 2010 at 10:54 AM, Otto Solares wrote: > On Tue, Jan 26, 2010 at 07:28:18AM -0800, Marc Abrams wrote: > > See, http://cshore.is-a-geek.com/openwrt/preinit_mount.html > > > > It's fully documented along with an example. > > Hi Marc, > > I read the following: > > Preinit > 3. Initializes device tree (/dev) > > Does that takes into account the new devtmpfs on 2.6.32+? > > My WRT160NL with OpenWRT, 2.6.32 kernel and trunk before your code's > commit reads: > > devtmpfs on /dev type devtmpfs (rw,size=14692k,nr_inodes=3673) > > I think it was mounted automagically by the kernel himself like old > devfs. > > Regards, > - > Otto > ___ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel > ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Preinit fixes
On Tue, Jan 26, 2010 at 07:28:18AM -0800, Marc Abrams wrote: > See, http://cshore.is-a-geek.com/openwrt/preinit_mount.html > > It's fully documented along with an example. Hi Marc, I read the following: Preinit 3. Initializes device tree (/dev) Does that takes into account the new devtmpfs on 2.6.32+? My WRT160NL with OpenWRT, 2.6.32 kernel and trunk before your code's commit reads: devtmpfs on /dev type devtmpfs (rw,size=14692k,nr_inodes=3673) I think it was mounted automagically by the kernel himself like old devfs. Regards, - Otto ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Preinit fixes
:) I agree. Take a look-- it's all there. marc. On Tue, Jan 26, 2010 at 7:29 AM, Stefan Monnier wrote: > > I have just a request from the documentation point of view: can anyone > > formalize a document with the init sequence, the hooks that can be used > and > > any other useful information to customize the init process. I know that > the > > source code is better a document... but I formal document can be easily > > reviewed in order to have a standard. > > Oh, yes, that would be wonderful. The code can be helpful, but it's > never clear from it which part is an intended feature and which part is > just an accident. So a little document that explains the *design* would > be help both users and maintainers/contributors. > > >Stefan > > ___ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel > ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Preinit fixes
> I have just a request from the documentation point of view: can anyone > formalize a document with the init sequence, the hooks that can be used and > any other useful information to customize the init process. I know that the > source code is better a document... but I formal document can be easily > reviewed in order to have a standard. Oh, yes, that would be wonderful. The code can be helpful, but it's never clear from it which part is an intended feature and which part is just an accident. So a little document that explains the *design* would be help both users and maintainers/contributors. Stefan ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Preinit fixes
Hi, Luigi: See, http://cshore.is-a-geek.com/openwrt/preinit_mount.html It's fully documented along with an example. marc. On Tue, Jan 26, 2010 at 5:33 AM, Luigi 'Comio' Mantellini < luigi.mantellini...@gmail.com> wrote: > Hi All, > Hi Daniel, > > thanks for this improvement. > I have just a request from the documentation point of view: can anyone > formalize a document with the init sequence, the hooks that can be used and > any other useful information to customize the init process. I know that the > source code is better a document... but I formal document can be easily > reviewed in order to have a standard. > > Sorry again for my strange question. > > best regards, > > ciao > > luigi > > Il lunedì 25 gennaio 2010 06:46:16 Daniel Dickinson ha scritto: > > Felix detected two problems with parts of the patch I couldn't fix. The > > first was definitely a typo, and I believe the second was type-type > > mistake as well, though I can't test the fix. It seems I forgot to > > remove a ' when I switched from ' to ". > > > > Anyway I am attaching both the patch that applies (via -p1) on top of > > the other patch, and a completely refreshed patch (via -p0). > > > > Regards, > > > > Daniel > > > > -- > > Luigi 'Comio' Mantellini > R&D - Software > > Industrie Dial Face S.p.A. > Via Canzo, 4 > 20068 Peschiera Borromeo (MI) Italy > Tel.: +39 02 5167 2813 > Fax: +39 02 5167 2459 > E-mail: luigi.mantell...@idf-hit.com > > Questo messaggio e i suoi allegati sono indirizzati esclusivamente alle > persone indicate. La diffusione, copia o qualsiasi altra azione derivante > dalla conoscenza di queste informazioni sono rigorosamente vietate. Qualora > abbiate ricevuto questo documento per errore siete cortesemente pregati di > darne immediata comunicazione al mittente e di provvedere alla sua > distruzione, Grazie. > > Rispetta l'ambiente. Non stampare questa mail se non è realmente > necessario. > > This e-mail and any attachments is confidential and may contain privileged > information intended for the addressee(s) only. Dissemination, copying, > printing or use by anybody else is unauthorized. If you are not the > intended > recipient, please delete this message and any attachments and advise the > sender by return e-mail, Thanks. > > Help the environment. Please do not print this email unless it is > absolutely > necessary. > ___ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel > ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Preinit fixes
Hi All, Hi Daniel, thanks for this improvement. I have just a request from the documentation point of view: can anyone formalize a document with the init sequence, the hooks that can be used and any other useful information to customize the init process. I know that the source code is better a document... but I formal document can be easily reviewed in order to have a standard. Sorry again for my strange question. best regards, ciao luigi Il lunedì 25 gennaio 2010 06:46:16 Daniel Dickinson ha scritto: > Felix detected two problems with parts of the patch I couldn't fix. The > first was definitely a typo, and I believe the second was type-type > mistake as well, though I can't test the fix. It seems I forgot to > remove a ' when I switched from ' to ". > > Anyway I am attaching both the patch that applies (via -p1) on top of > the other patch, and a completely refreshed patch (via -p0). > > Regards, > > Daniel > -- Luigi 'Comio' Mantellini R&D - Software Industrie Dial Face S.p.A. Via Canzo, 4 20068 Peschiera Borromeo (MI) Italy Tel.: +39 02 5167 2813 Fax: +39 02 5167 2459 E-mail: luigi.mantell...@idf-hit.com Questo messaggio e i suoi allegati sono indirizzati esclusivamente alle persone indicate. La diffusione, copia o qualsiasi altra azione derivante dalla conoscenza di queste informazioni sono rigorosamente vietate. Qualora abbiate ricevuto questo documento per errore siete cortesemente pregati di darne immediata comunicazione al mittente e di provvedere alla sua distruzione, Grazie. Rispetta l'ambiente. Non stampare questa mail se non è realmente necessario. This e-mail and any attachments is confidential and may contain privileged information intended for the addressee(s) only. Dissemination, copying, printing or use by anybody else is unauthorized. If you are not the intended recipient, please delete this message and any attachments and advise the sender by return e-mail, Thanks. Help the environment. Please do not print this email unless it is absolutely necessary. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
