Re: [PATCH] util-linux: fix build when libmagic is present
Op 4 sep. 2020, om 09:03 heeft Rosen Penev het volgende geschreven: > > On Thu, Sep 3, 2020 at 11:29 PM Petr Štetiar wrote: >> >> Rosen Penev [2020-09-01 15:37:03]: >> >> From https://openwrt.org/submitting-patches, section about commit >> description: >> >> "it will be committed to the source changelog, so it should explain to a >> competent reader why you made this commit. Include symptoms of the failure >> you are fixing (log messages, error messages, etc.), it will be useful for >> people searching the commit logs looking for a fix for their issue. If a >> patch fixes a compile failure, include only the most relevant part of the >> failure log" > Hahaha I don't think so. This is truly provocative. As you produce astounding amounts of patches - so many it becomes almost inconceivable that one person only can produce that many - some polite criticism must be taken seriously. This does not feel right. Regards from a bystander, Paul >> >> Thanks. >> >>> Signed-off-by: Rosen Penev >>> --- >>> package/utils/util-linux/Makefile | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/package/utils/util-linux/Makefile >>> b/package/utils/util-linux/Makefile >>> index 0fc9819c58..05ceaa413e 100644 >>> --- a/package/utils/util-linux/Makefile >>> +++ b/package/utils/util-linux/Makefile >>> @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk >>> >>> PKG_NAME:=util-linux >>> PKG_VERSION:=2.36 >>> -PKG_RELEASE:=1 >>> +PKG_RELEASE:=2 >>> >>> PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz >>> PKG_SOURCE_URL:=@KERNEL/linux/utils/$(PKG_NAME)/v2.36 >>> @@ -526,6 +526,7 @@ CONFIGURE_ARGS += \ >>> --without-python\ >>> --without-udev \ >>> --without-readline \ >>> + --without-libmagic \ >>> --with-ncursesw >>> >>> TARGET_CFLAGS += $(FPIC) -std=gnu99 >>> -- >>> 2.26.2 >>> >>> >>> ___ >>> openwrt-devel mailing list >>> openwrt-devel@lists.openwrt.org >>> https://lists.openwrt.org/mailman/listinfo/openwrt-devel >>> >> >> -- >> ynezz > > ___ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH] util-linux: fix build when libmagic is present
On Thu, Sep 3, 2020 at 11:29 PM Petr Štetiar wrote: > > Rosen Penev [2020-09-01 15:37:03]: > > From https://openwrt.org/submitting-patches, section about commit description: > > "it will be committed to the source changelog, so it should explain to a > competent reader why you made this commit. Include symptoms of the failure > you are fixing (log messages, error messages, etc.), it will be useful for > people searching the commit logs looking for a fix for their issue. If a > patch fixes a compile failure, include only the most relevant part of the > failure log" Hahaha I don't think so. > > Thanks. > > > Signed-off-by: Rosen Penev > > --- > > package/utils/util-linux/Makefile | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/package/utils/util-linux/Makefile > > b/package/utils/util-linux/Makefile > > index 0fc9819c58..05ceaa413e 100644 > > --- a/package/utils/util-linux/Makefile > > +++ b/package/utils/util-linux/Makefile > > @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk > > > > PKG_NAME:=util-linux > > PKG_VERSION:=2.36 > > -PKG_RELEASE:=1 > > +PKG_RELEASE:=2 > > > > PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz > > PKG_SOURCE_URL:=@KERNEL/linux/utils/$(PKG_NAME)/v2.36 > > @@ -526,6 +526,7 @@ CONFIGURE_ARGS += \ > > --without-python\ > > --without-udev \ > > --without-readline \ > > + --without-libmagic \ > > --with-ncursesw > > > > TARGET_CFLAGS += $(FPIC) -std=gnu99 > > -- > > 2.26.2 > > > > > > ___ > > openwrt-devel mailing list > > openwrt-devel@lists.openwrt.org > > https://lists.openwrt.org/mailman/listinfo/openwrt-devel > > > > -- > ynezz ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH] util-linux: fix build when libmagic is present
Rosen Penev [2020-09-01 15:37:03]: >From https://openwrt.org/submitting-patches, section about commit description: "it will be committed to the source changelog, so it should explain to a competent reader why you made this commit. Include symptoms of the failure you are fixing (log messages, error messages, etc.), it will be useful for people searching the commit logs looking for a fix for their issue. If a patch fixes a compile failure, include only the most relevant part of the failure log" Thanks. > Signed-off-by: Rosen Penev > --- > package/utils/util-linux/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/package/utils/util-linux/Makefile > b/package/utils/util-linux/Makefile > index 0fc9819c58..05ceaa413e 100644 > --- a/package/utils/util-linux/Makefile > +++ b/package/utils/util-linux/Makefile > @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk > > PKG_NAME:=util-linux > PKG_VERSION:=2.36 > -PKG_RELEASE:=1 > +PKG_RELEASE:=2 > > PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz > PKG_SOURCE_URL:=@KERNEL/linux/utils/$(PKG_NAME)/v2.36 > @@ -526,6 +526,7 @@ CONFIGURE_ARGS += \ > --without-python\ > --without-udev \ > --without-readline \ > + --without-libmagic \ > --with-ncursesw > > TARGET_CFLAGS += $(FPIC) -std=gnu99 > -- > 2.26.2 > > > ___ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel > -- ynezz ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH] util-linux: fix build when libmagic is present
On Tue, Sep 01, 2020 at 03:37:03PM -0700, Rosen Penev wrote: > Signed-off-by: Rosen Penev > --- Acked-by: Sebastian Kemper Please apply to get util-linux building. We need libuuid for telephony and others :-) Regards, Seb > package/utils/util-linux/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/package/utils/util-linux/Makefile > b/package/utils/util-linux/Makefile > index 0fc9819c58..05ceaa413e 100644 > --- a/package/utils/util-linux/Makefile > +++ b/package/utils/util-linux/Makefile > @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk > > PKG_NAME:=util-linux > PKG_VERSION:=2.36 > -PKG_RELEASE:=1 > +PKG_RELEASE:=2 > > PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz > PKG_SOURCE_URL:=@KERNEL/linux/utils/$(PKG_NAME)/v2.36 > @@ -526,6 +526,7 @@ CONFIGURE_ARGS += \ > --without-python\ > --without-udev \ > --without-readline \ > + --without-libmagic \ > --with-ncursesw > > TARGET_CFLAGS += $(FPIC) -std=gnu99 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[PATCH] util-linux: fix build when libmagic is present
Signed-off-by: Rosen Penev --- package/utils/util-linux/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package/utils/util-linux/Makefile b/package/utils/util-linux/Makefile index 0fc9819c58..05ceaa413e 100644 --- a/package/utils/util-linux/Makefile +++ b/package/utils/util-linux/Makefile @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=util-linux PKG_VERSION:=2.36 -PKG_RELEASE:=1 +PKG_RELEASE:=2 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz PKG_SOURCE_URL:=@KERNEL/linux/utils/$(PKG_NAME)/v2.36 @@ -526,6 +526,7 @@ CONFIGURE_ARGS += \ --without-python\ --without-udev \ --without-readline \ + --without-libmagic \ --with-ncursesw TARGET_CFLAGS += $(FPIC) -std=gnu99 -- 2.26.2 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
