Re: [PATCH 0/4] realtek: fix multiple issues with L2 forwarding
Hi Sander, Thank you for reviewing the patches! On 2023-0430 at 22:39, Sander Vanheule wrote: Hi Jan, On Sun, 2023-03-12 at 23:57 +0100, Jan Hoffmann wrote: realtek: fix standalone ports in presence of static fdb entries realtek: handle changed flags in VLAN configuration These patches are triggering checkpatch.pl. Could you resolve the style issues, so these things don't pollute future changes? Well, that's embarassing. I'll send an updated version soon. I also double-checked the previous patch series with the multicast changes again, but there aren't any warnings for that one. But I'm going to also send a revised version of that one, to remove the redundant branch entirely (second commit of that series). Best, Jan Otherwise the changes look good to me. Best, Sander ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH 0/4] realtek: fix multiple issues with L2 forwarding
Hi Jan, On Sun, 2023-03-12 at 23:57 +0100, Jan Hoffmann wrote: > realtek: fix standalone ports in presence of static fdb entries > realtek: handle changed flags in VLAN configuration These patches are triggering checkpatch.pl. Could you resolve the style issues, so these things don't pollute future changes? Otherwise the changes look good to me. Best, Sander ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
[PATCH 0/4] realtek: fix multiple issues with L2 forwarding
This series fixes several bugs that can result in packets being forwarded incorrectly. The port isolation and VLAN issues probably remained unnoticed so far, because they only manifest when after a port leaves a bridge, or an existing VLAN membership is changed. Jan Hoffmann (4): realtek: properly update port masks when port leaves bridge realtek: initialize port masks to match the default state realtek: fix standalone ports in presence of static fdb entries realtek: handle changed flags in VLAN configuration .../files-5.10/drivers/net/dsa/rtl83xx/dsa.c | 89 --- .../drivers/net/dsa/rtl83xx/rtl838x.c | 10 +++ .../drivers/net/dsa/rtl83xx/rtl838x.h | 14 +++ .../drivers/net/dsa/rtl83xx/rtl839x.c | 11 +++ .../files-5.15/drivers/net/dsa/rtl83xx/dsa.c | 85 +++--- .../drivers/net/dsa/rtl83xx/rtl838x.c | 10 +++ .../drivers/net/dsa/rtl83xx/rtl838x.h | 14 +++ .../drivers/net/dsa/rtl83xx/rtl839x.c | 11 +++ 8 files changed, 179 insertions(+), 65 deletions(-) -- 2.39.1 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
