Re: Unknown licensing terms for binary blobs [Was: Re: [PATCH 1/2] firmware: Add cavium CPT hardware crypto firmware]

2022-02-22 Thread Tim Harvey
On Sat, Feb 19, 2022 at 11:22 PM Daniel Danzberger  wrote:
>
> On Sat, 2022-02-19 at 20:21 +0100, Petr Štetiar wrote:
> > Hauke Mehrtens  [2021-05-22 20:31:27]:
> >
> > Hi Daniel, Tim,
> >
> > > On 4/18/21 9:46 AM, Daniel Danzberger wrote:
> > > > The firmware consists of 2 images:
> > > >   - cpt8x-mc-ae.out
> > > >   - cpt8x-mc-se.out
> > > >
> > > > Both are required and requests by the kernel module 'cptpf'
> > > > (drivers/crypto/cavium/cpt) to provide hardware crpyto support
> > > > on cavium platforms like the octeontx
> > > >
> > > > Signed-off-by: Daniel Danzberger 
> > > > ---
> > > >   package/firmware/cavium-cpt/Makefile | 52
> > > > 
> > > >   1 file changed, 52 insertions(+)
> > > >   create mode 100644 package/firmware/cavium-cpt/Makefile
> > > Hi,
> > >
> > > Under which license are these two files distributed?
> >
> > do you've have an idea? Thanks!
> Hi,
>
> I couldn't find any information about the license, but I played around
> with this hardware crypto on some devices a while ago and found that
> they are performing terrible :)
> Much worse than the CPU. Gateworks even notices this on their website:
> http://trac.gateworks.com/wiki/linux/encryption#PerformaceComparisons
> http://trac.gateworks.com/wiki/newport/encryption
>
> With that in mind I think my 2 original patches can be dropped.

Correct, the performance is not good and the only benefit of using it
is if you need to offload crypto because your CPU is constrained (and
don't care about the crypto performance).

Tim

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: Unknown licensing terms for binary blobs [Was: Re: [PATCH 1/2] firmware: Add cavium CPT hardware crypto firmware]

2022-02-19 Thread Daniel Danzberger
On Sat, 2022-02-19 at 20:21 +0100, Petr Štetiar wrote:
> Hauke Mehrtens  [2021-05-22 20:31:27]:
> 
> Hi Daniel, Tim,
> 
> > On 4/18/21 9:46 AM, Daniel Danzberger wrote:
> > > The firmware consists of 2 images:
> > >   - cpt8x-mc-ae.out
> > >   - cpt8x-mc-se.out
> > > 
> > > Both are required and requests by the kernel module 'cptpf'
> > > (drivers/crypto/cavium/cpt) to provide hardware crpyto support
> > > on cavium platforms like the octeontx
> > > 
> > > Signed-off-by: Daniel Danzberger 
> > > ---
> > >   package/firmware/cavium-cpt/Makefile | 52
> > > 
> > >   1 file changed, 52 insertions(+)
> > >   create mode 100644 package/firmware/cavium-cpt/Makefile
> > Hi,
> > 
> > Under which license are these two files distributed?
> 
> do you've have an idea? Thanks!
Hi,

I couldn't find any information about the license, but I played around
with this hardware crypto on some devices a while ago and found that
they are performing terrible :)
Much worse than the CPU. Gateworks even notices this on their website:
http://trac.gateworks.com/wiki/linux/encryption#PerformaceComparisons
http://trac.gateworks.com/wiki/newport/encryption

With that in mind I think my 2 original patches can be dropped.


> 
> Cheers,
> 
> Petr
> 

-- 
Regards

Daniel Danzberger
embeDD GmbH, Alter Postplatz 2, CH-6370 Stans

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Unknown licensing terms for binary blobs [Was: Re: [PATCH 1/2] firmware: Add cavium CPT hardware crypto firmware]

2022-02-19 Thread Petr Štetiar
Hauke Mehrtens  [2021-05-22 20:31:27]:

Hi Daniel, Tim,

> On 4/18/21 9:46 AM, Daniel Danzberger wrote:
> > The firmware consists of 2 images:
> >   - cpt8x-mc-ae.out
> >   - cpt8x-mc-se.out
> > 
> > Both are required and requests by the kernel module 'cptpf'
> > (drivers/crypto/cavium/cpt) to provide hardware crpyto support
> > on cavium platforms like the octeontx
> > 
> > Signed-off-by: Daniel Danzberger 
> > ---
> >   package/firmware/cavium-cpt/Makefile | 52 
> >   1 file changed, 52 insertions(+)
> >   create mode 100644 package/firmware/cavium-cpt/Makefile
> Hi,
> 
> Under which license are these two files distributed?

do you've have an idea? Thanks!

Cheers,

Petr

___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


Re: [PATCH 1/2] firmware: Add cavium CPT hardware crypto firmware

2021-05-22 Thread Hauke Mehrtens

On 4/18/21 9:46 AM, Daniel Danzberger wrote:

The firmware consists of 2 images:
  - cpt8x-mc-ae.out
  - cpt8x-mc-se.out

Both are required and requests by the kernel module 'cptpf'
(drivers/crypto/cavium/cpt) to provide hardware crpyto support
on cavium platforms like the octeontx

Signed-off-by: Daniel Danzberger 
---
  package/firmware/cavium-cpt/Makefile | 52 
  1 file changed, 52 insertions(+)
  create mode 100644 package/firmware/cavium-cpt/Makefile

Hi,

Under which license are these two files distributed?

Hauke


OpenPGP_0x93DD20630910B515.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


[PATCH 1/2] firmware: Add cavium CPT hardware crypto firmware

2021-04-18 Thread Daniel Danzberger
The firmware consists of 2 images:
 - cpt8x-mc-ae.out
 - cpt8x-mc-se.out

Both are required and requests by the kernel module 'cptpf'
(drivers/crypto/cavium/cpt) to provide hardware crpyto support
on cavium platforms like the octeontx

Signed-off-by: Daniel Danzberger 
---
 package/firmware/cavium-cpt/Makefile | 52 
 1 file changed, 52 insertions(+)
 create mode 100644 package/firmware/cavium-cpt/Makefile

diff --git a/package/firmware/cavium-cpt/Makefile 
b/package/firmware/cavium-cpt/Makefile
new file mode 100644
index 00..7a0a36d54c
--- /dev/null
+++ b/package/firmware/cavium-cpt/Makefile
@@ -0,0 +1,52 @@
+include $(TOPDIR)/rules.mk
+
+PKG_NAME:=cavium-firmware-cpt
+PKG_VERSION:=2021-04-17
+PKG_RELEASE:=1
+
+include $(INCLUDE_DIR)/package.mk
+
+define Package/cavium-firmware-cpt-default
+  TITLE:=Cavium firmware for CPT HW crypto ($(1) part)
+  SECTION:=firmware
+  CATEGORY:=Firmware
+endef
+
+define Download/cavium-firmware-cpt-ae
+  URL:=http://dev.gateworks.com/newport/cpt/1.0.0/
+  FILE:=cpt8x-mc-ae.out
+  HASH:=39063984d5f47e997ec2f15cef87394d719501e53ed121e0373161b86e72ad22
+endef
+$(eval $(call Download,cavium-firmware-cpt-ae))
+
+define Download/cavium-firmware-cpt-se
+  URL:=http://dev.gateworks.com/newport/cpt/1.0.0/
+  FILE:=cpt8x-mc-se.out
+  HASH:=7927b69eb693b7de67a3cc867083c1f5a3f2c3c586cfa11a542e6551091f7cc7
+endef
+$(eval $(call Download,cavium-firmware-cpt-se))
+
+define Package/cavium-firmware-cpt-ae
+  $(call Package/cavium-firmware-cpt-default,ae)
+endef
+
+define Package/cavium-firmware-cpt-se
+  $(call Package/cavium-firmware-cpt-default,se)
+endef
+
+define Build/Compile
+
+endef
+
+define Package/cavium-firmware-cpt-ae/install
+   $(INSTALL_DIR) $(1)/lib/firmware
+   $(INSTALL_DATA) $(DL_DIR)/cpt8x-mc-ae.out $(1)/lib/firmware
+endef
+
+define Package/cavium-firmware-cpt-se/install
+   $(INSTALL_DIR) $(1)/lib/firmware
+   $(INSTALL_DATA) $(DL_DIR)/cpt8x-mc-se.out $(1)/lib/firmware
+endef
+
+$(eval $(call BuildPackage,cavium-firmware-cpt-ae))
+$(eval $(call BuildPackage,cavium-firmware-cpt-se))
-- 
2.30.2


___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel