Re: [OpenWrt-Devel] [PATCH] kernel: fix hw-crypto detection of qce driver
On Mon, Sep 23, 2019 at 2:12 PM Rosen Penev wrote: > > On Mon, Sep 23, 2019 at 5:28 AM Eneas Queiroz wrote: > > > > On Fri, Sep 20, 2019 at 5:48 PM Eneas U de Queiroz > > wrote: > > > > > > This adds the CRYPTO_ALG_KERN_DRIVER_ONLY flag to Qualcomm crypto engine > > > driver algorithms, so that openssl devcrypto can recognize them as > > > hardware-accelerated. > > > > > > Signed-off-by: Eneas U de Queiroz > > > > I noticed this was moved to ipq40xx, but ipq806x is also enabling the > > qce driver: > > https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=target/linux/ipq806x/config-4.14#l119 > > > > So I imagine we need to either copy the patch to ipq806x, or disable > > the qce driver in ipq806x/config-4.14. I don't have enough knowledge > > to decide what to do, so can someone more knowledgeable, please, > > either do it or point me to the right direction. > Probably a mistake from the splitting of ipq targets (used to be just one). > > Also see: > > https://github.com/openwrt/openwrt/commit/fff65dbe2436351ea1feee6c79110971ec4d5881 I thought about that, but then I saw the specs here: https://www.qualcomm.com/products/ipq8064 It does list the crypto engine for ipq8064, but not for the rest of the ipq806x family. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] kernel: fix hw-crypto detection of qce driver
On Mon, Sep 23, 2019 at 2:28 PM Eneas Queiroz wrote: > > On Fri, Sep 20, 2019 at 5:48 PM Eneas U de Queiroz > wrote: > > > > This adds the CRYPTO_ALG_KERN_DRIVER_ONLY flag to Qualcomm crypto engine > > driver algorithms, so that openssl devcrypto can recognize them as > > hardware-accelerated. > > > > Signed-off-by: Eneas U de Queiroz > > I noticed this was moved to ipq40xx, but ipq806x is also enabling the > qce driver: > https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=target/linux/ipq806x/config-4.14#l119 > > So I imagine we need to either copy the patch to ipq806x, or disable > the qce driver in ipq806x/config-4.14. I don't have enough knowledge > to decide what to do, so can someone more knowledgeable, please, > either do it or point me to the right direction. The upstream qce crypto driver does not support the IPQ806x series. The ipq806x target used to host ipq40xx, so this driver was enabled as builtin back then. But since ipq40xx moved out, it's has become a symbol of "hope" That maybe some day the NSS support of the IPQ806x can make use of it So yeah, if you want to crush the hopes and dreams of the IPQ806X users, you can disable/remove the driver for the ipq806x target. Regards, Christian ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] kernel: fix hw-crypto detection of qce driver
On Mon, Sep 23, 2019 at 5:28 AM Eneas Queiroz wrote: > > On Fri, Sep 20, 2019 at 5:48 PM Eneas U de Queiroz > wrote: > > > > This adds the CRYPTO_ALG_KERN_DRIVER_ONLY flag to Qualcomm crypto engine > > driver algorithms, so that openssl devcrypto can recognize them as > > hardware-accelerated. > > > > Signed-off-by: Eneas U de Queiroz > > I noticed this was moved to ipq40xx, but ipq806x is also enabling the > qce driver: > https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=target/linux/ipq806x/config-4.14#l119 > > So I imagine we need to either copy the patch to ipq806x, or disable > the qce driver in ipq806x/config-4.14. I don't have enough knowledge > to decide what to do, so can someone more knowledgeable, please, > either do it or point me to the right direction. Probably a mistake from the splitting of ipq targets (used to be just one). Also see: https://github.com/openwrt/openwrt/commit/fff65dbe2436351ea1feee6c79110971ec4d5881 > > Cheers, > > Eneas > > ___ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] [PATCH] kernel: fix hw-crypto detection of qce driver
On Fri, Sep 20, 2019 at 5:48 PM Eneas U de Queiroz wrote: > > This adds the CRYPTO_ALG_KERN_DRIVER_ONLY flag to Qualcomm crypto engine > driver algorithms, so that openssl devcrypto can recognize them as > hardware-accelerated. > > Signed-off-by: Eneas U de Queiroz I noticed this was moved to ipq40xx, but ipq806x is also enabling the qce driver: https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=target/linux/ipq806x/config-4.14#l119 So I imagine we need to either copy the patch to ipq806x, or disable the qce driver in ipq806x/config-4.14. I don't have enough knowledge to decide what to do, so can someone more knowledgeable, please, either do it or point me to the right direction. Cheers, Eneas ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
