Re: [OpenWrt-Devel] [PATCH] package/kernel: Build it87 hardware monitor module

[John Crispin]

you know how to write proper descriptions for patches. i have seen you
do it many times over many years. i wont even explain to you what is
wrong with this one.

please fix and resend.
John

On 16/12/2015 23:10, open...@daniel.thecshore.com wrote:
> From: Daniel Dickinson 
> 
> Fixed typo in description define.
> 
> This is easily added with no side effects, not sure why it
> was missing - oversight?
> 
> Signed-off-by: Daniel Dickinson 
> ---
>  package/kernel/linux/modules/hwmon.mk | 14 ++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/package/kernel/linux/modules/hwmon.mk 
> b/package/kernel/linux/modules/hwmon.mk
> index ca0ff66..97bef4d 100644
> --- a/package/kernel/linux/modules/hwmon.mk
> +++ b/package/kernel/linux/modules/hwmon.mk
> @@ -93,6 +93,20 @@ endef
>  $(eval $(call KernelPackage,hwmon-ina2xx))
>  
>  
> +define KernelPackage/hwmon-it87
> +  TITLE:=it87 monitoring support
> +  KCONFIG:=CONFIG_SENSORS_IT87
> +  FILES:=$(LINUX_DIR)/drivers/hwmon/it87.ko
> +  AUTOLOAD:=$(call AutoProbe,it87)
> +  $(call AddDepends/hwmon,+kmod-i2c-core +kmod-hwmod-vid)
> +endef
> +
> +define KernelPackage/hwmon-it87/description
> + Kernel module for it87 thermal and voltage monitor chip
> +endef
> +
> +$(eval $(call KernelPackage,hwmon-it87))
> +
>  define KernelPackage/hwmon-lm63
>TITLE:=LM63/64 monitoring support
>KCONFIG:=CONFIG_SENSORS_LM63
> 
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Re: [OpenWrt-Devel] [PATCH] package/kernel: Build it87 hardware monitor module

[Bjørn Mork]

open...@daniel.thecshore.com writes:

> From: Daniel Dickinson 
>
> This is easy to add with no side effects; the chip probably just got added 
> after
> the hwmon package was created

I sort of doubt that...  I remember messing with that driver a long time
ago, in a galaxy far far away.  Google tells me that was 2004 and Linux
v2.6.6.  Let's see, Google also tells me White Russian was released in
2007.

Anyway. Small typo here:

> +define KernelPackage/hwmon-i687/description


Bjørn
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel