Re: [OpenWrt-Devel] Patch submission release based on OpenWRT trunk
On 04/04/14 07:49, Matthew Fatheree wrote: our intention was to get this process started, so we could address any issues as soon as possible. Hi Matthew, Non-dev here. Just a couple of comments. Mainly that I recommend in future your team should follow patch submission style guide. https://dev.openwrt.org/wiki/SubmittingPatches This will aid others in identifying the submission, as well as accepting and documenting patches that are accepted. Personally, I missed this submission as it: 1. Subject did not contain SUMMARY with a globally-unique identifier for that patch (eg, 'WRT1900AC initial submission') 2. Was not signed 3. Did not contain diffs but contained an external link to patches (admittedly, given the binary blob submission and the 'NO MIME' rule for patches this may have been a little tricky for you at such an early stage, however the text sections could've been submitted and just the blob left on your FTP server... at a stretch... although personally I don't like that either see other's comments about blob submissions...) I look forward to seeing more submissions from Belkin and hope they can conform to the standard expected by OpenWRT hackers. Cheers, Pete. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Patch submission release based on OpenWRT trunk
* Matthew Fatheree matthew.fathe...@belkin.com [04.04.2014 08:39]: the wireless driver, but our intention was to get this process started, so we could address any issues as soon as possible. I wrote 2 times to your press-releationship person, asking for sponsoring 50 of the devices for the next OpenWrt-developer meeting[1], so we can help cleaning up the patches, but till now there was no reaction. Please push this internally again. bye, Bastian [1] http://battlemesh.org/BattleMeshV7 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Patch submission release based on OpenWRT trunk
On 03/04/14 20:52, Matthew Fatheree wrote: Belkin Inc. would like to announce the patch submission release for WRT1900AC which is based on OpenWRT trunk, the detail base revision is specified in each release. Hello Matthew, any tests on WAN - LAN (ethernet) throughput available for WRT1900AC ? I have a 500 Mbit/s Internet connection, upgrading soon to a 1 Gbit/s link, wondering if that dual cpu holds well.. Thanks! This is the release version 1.1 of WRT1900AC Openwrt patch submission OpenWRT git base revision: e97be7a104e5c809ae4638cf169823249a505698 OpenWRT svn base revision: 40006 The total size of the uncompressed files exceeds the 300k maximum for email attachments. The patch files can be accessed using the link below: Direct Link: ftp://Temp90523934364:tag43...@ftp.belkin.com/Temp90523934364 Thank you Matthew Fatheree __ Confidential This e-mail and any files transmitted with it are the property of Belkin International, Inc. and/or its affiliates, are confidential, and are intended solely for the use of the individual or entity to whom this e-mail is addressed. If you are not one of the named recipients or otherwise have reason to believe that you have received this e-mail in error, please notify the sender and delete this message immediately from your computer. Any other use, retention, dissemination, forwarding, printing or copying of this e-mail is strictly prohibited. Pour la version française: http://www.belkin.com/email-notice/French.html Für die deutsche Übersetzung: http://www.belkin.com/email-notice/German.html __ ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Patch submission release based on OpenWRT trunk
On 2014-04-03 19:52, Matthew Fatheree wrote: Belkin Inc. would like to announce the patch submission release for WRT1900AC which is based on OpenWRT trunk, the detail base revision is specified in each release. This is the release version 1.1 of WRT1900AC Openwrt patch submission OpenWRT git base revision: e97be7a104e5c809ae4638cf169823249a505698 OpenWRT svn base revision: 40006 The total size of the uncompressed files exceeds the 300k maximum for email attachments. The patch files can be accessed using the link below: Direct Link: ftp://Temp90523934364:tag43...@ftp.belkin.com/Temp90523934364 I noticed that the wifi driver is patched in as a precompiled .ko file, which is obviously unacceptable for inclusion into OpenWrt. Is the lack of available source code going to be fixed in a reasonable timeframe? Considering the amount of marketing hype created by Belkin/Linksys around this device, it would be pretty disappointing if it ends up being useless for pretty much anybody wanting to compile their own builds. - Felix ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Patch submission release based on OpenWRT trunk
On 04/03/2014 07:52 PM, Matthew Fatheree wrote: Belkin Inc. would like to announce the patch submission release for WRT1900AC which is based on OpenWRT trunk, the detail base revision is specified in each release. This is the release version 1.1 of WRT1900AC Openwrt patch submission OpenWRT git base revision: e97be7a104e5c809ae4638cf169823249a505698 OpenWRT svn base revision: 40006 The total size of the uncompressed files exceeds the 300k maximum for email attachments. The patch files can be accessed using the link below: Direct Link: ftp://Temp90523934364:tag43...@ftp.belkin.com/Temp90523934364 Thank you Matthew Fatheree I have some comments on the patches. Your fan_ctrl.c driver has a very strange architecture. You should not call a user space application from kernel space and then you should not access registers from a shell script. You should probably put the functionality you currently have in the shell script into the kernel driver and the stuff from the kernel driver into the shell script. Or put every thing into a kernel driver. Adding a binary kernel module into OpenWrt like you did with ap8x.ko module will not work, because it depends on one exact kernel version and config. When the offset of one member in e.g. skbuff changes in the kernel because I change a kernel option your module will come up with strange runtime errors. You should provide the source code of the wireless driver and build it with the OpenWrt build system. This looks like a version of the driver you are suing licensed under the terms of the GPL: https://github.com/kmihelich/wlan-smileplug I haven't done a full review of your patches. Hauke ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Patch submission release based on OpenWRT trunk
Hi Felix, Thank you for your feedback. There is still some work to be done on the wireless driver, but our intention was to get this process started, so we could address any issues as soon as possible. Again, Thank you Matt On Thu, 2014-04-03 at 21:23 +0200, Felix Fietkau wrote: On 2014-04-03 19:52, Matthew Fatheree wrote: Belkin Inc. would like to announce the patch submission release for WRT1900AC which is based on OpenWRT trunk, the detail base revision is specified in each release. This is the release version 1.1 of WRT1900AC Openwrt patch submission OpenWRT git base revision: e97be7a104e5c809ae4638cf169823249a505698 OpenWRT svn base revision: 40006 The total size of the uncompressed files exceeds the 300k maximum for email attachments. The patch files can be accessed using the link below: Direct Link: ftp://Temp90523934364:tag43...@ftp.belkin.com/Temp90523934364 I noticed that the wifi driver is patched in as a precompiled .ko file, which is obviously unacceptable for inclusion into OpenWrt. Is the lack of available source code going to be fixed in a reasonable timeframe? Considering the amount of marketing hype created by Belkin/Linksys around this device, it would be pretty disappointing if it ends up being useless for pretty much anybody wanting to compile their own builds. - Felix __ Confidential This e-mail and any files transmitted with it are the property of Belkin International, Inc. and/or its affiliates, are confidential, and are intended solely for the use of the individual or entity to whom this e-mail is addressed. If you are not one of the named recipients or otherwise have reason to believe that you have received this e-mail in error, please notify the sender and delete this message immediately from your computer. Any other use, retention, dissemination, forwarding, printing or copying of this e-mail is strictly prohibited. Pour la version française: http://www.belkin.com/email-notice/French.html Für die deutsche Übersetzung: http://www.belkin.com/email-notice/German.html __ ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
Re: [OpenWrt-Devel] Patch submission release based on OpenWRT trunk
Hi Hauke, Thank you for your comments. I will notify the development team about the issues you have identified with the fan control driver, and wireless driver. Our goal was to start this submission process early to identify any issues. Thank you again for your help Matt On Thu, 2014-04-03 at 21:26 +0200, Hauke Mehrtens wrote: On 04/03/2014 07:52 PM, Matthew Fatheree wrote: Belkin Inc. would like to announce the patch submission release for WRT1900AC which is based on OpenWRT trunk, the detail base revision is specified in each release. This is the release version 1.1 of WRT1900AC Openwrt patch submission OpenWRT git base revision: e97be7a104e5c809ae4638cf169823249a505698 OpenWRT svn base revision: 40006 The total size of the uncompressed files exceeds the 300k maximum for email attachments. The patch files can be accessed using the link below: Direct Link: ftp://Temp90523934364:tag43...@ftp.belkin.com/Temp90523934364 Thank you Matthew Fatheree I have some comments on the patches. Your fan_ctrl.c driver has a very strange architecture. You should not call a user space application from kernel space and then you should not access registers from a shell script. You should probably put the functionality you currently have in the shell script into the kernel driver and the stuff from the kernel driver into the shell script. Or put every thing into a kernel driver. Adding a binary kernel module into OpenWrt like you did with ap8x.ko module will not work, because it depends on one exact kernel version and config. When the offset of one member in e.g. skbuff changes in the kernel because I change a kernel option your module will come up with strange runtime errors. You should provide the source code of the wireless driver and build it with the OpenWrt build system. This looks like a version of the driver you are suing licensed under the terms of the GPL: https://github.com/kmihelich/wlan-smileplug I haven't done a full review of your patches. Hauke __ Confidential This e-mail and any files transmitted with it are the property of Belkin International, Inc. and/or its affiliates, are confidential, and are intended solely for the use of the individual or entity to whom this e-mail is addressed. If you are not one of the named recipients or otherwise have reason to believe that you have received this e-mail in error, please notify the sender and delete this message immediately from your computer. Any other use, retention, dissemination, forwarding, printing or copying of this e-mail is strictly prohibited. Pour la version française: http://www.belkin.com/email-notice/French.html Für die deutsche Übersetzung: http://www.belkin.com/email-notice/German.html __ ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
