Re: [PATCH v2] scripts: create kernel configuration upgrade script
On Wed, Feb 14, 2024 at 10:03:00AM +0100, Rafał Miłecki wrote: > On 7.02.2024 02:16, Elliott Mitchell wrote: > > diff --git a/scripts/kernel_upgrade.pl b/scripts/kernel_upgrade.pl > > new file mode 100755 > > index 00..b9fe5882a3 > > --- /dev/null > > +++ b/scripts/kernel_upgrade.pl > > @@ -0,0 +1,261 @@ > > +#!/usr/bin/env perl > > +# > > +# Copyright (C) 2024 Elliott Mitchell > > # > > +# # > > +# This is free software, licensed under the GNU General Public License > > # > > +# v3. See /LICENSE for more information. # > > +# > > OpenWrt is GPL 2.0 licensed. This this is GPL 3.0 only. > > It seems to be independent script (right now) but: > 1. What if one day we make it share some common code? Then you have GPLv3. Question is whether the common portion comes from this script? If yes, then we consider LGPL versus everything being GPLv3. This seems pretty unlikely as this is a rather specific task. `git fast-import` isn't likely to be useful in very many places. Also, `git` isn't something I would expect to see on a 128MB RAM device. > 2. What about using it to produce GPL 2.0 code? This is very well-understood. GPL applies to source code and the tools. GIMP is routinely used to produce non-GPL images. `git` is now used by MS for handling their source code, most of it remains non-GPL and no lawsuits have resulted. GCC is routinely used to build non-GPL software. Anything not directly linked in is completely uneffected. In particular while it does manipulate git's data, none of that is linked into the script and therefore has no license effects. This won't have any particularly notable effects. -- (\___(\___(\__ --=> 8-) EHM <=-- __/)___/)___/) \BS (| ehem+sig...@m5p.com PGP 87145445 |) / \_CS\ | _ -O #include O- _ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH v2] scripts: create kernel configuration upgrade script
On 7.02.2024 02:16, Elliott Mitchell wrote: diff --git a/scripts/kernel_upgrade.pl b/scripts/kernel_upgrade.pl new file mode 100755 index 00..b9fe5882a3 --- /dev/null +++ b/scripts/kernel_upgrade.pl @@ -0,0 +1,261 @@ +#!/usr/bin/env perl +# +# Copyright (C) 2024 Elliott Mitchell # +# # +# This is free software, licensed under the GNU General Public License # +# v3. See /LICENSE for more information. # +# OpenWrt is GPL 2.0 licensed. This this is GPL 3.0 only. It seems to be independent script (right now) but: 1. What if one day we make it share some common code? 2. What about using it to produce GPL 2.0 code? This may be more or less obvious to some of us but should we have a lawyer opinion to be sure? Personally I'm against such mixing licenses in our tools (script). Also: please use SPDX header to simplify licensing info. ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: [PATCH v2] scripts: create kernel configuration upgrade script
On Tue, Feb 06, 2024 at 05:16:41PM -0800, Elliott Mitchell wrote: > Create a script for automating kernel version changes. This > generates a pair of commits which cause history to remain attached to > all versioned configuration files. > > Crucially this makes `git blame` work without needing > --find-copies-harder, which is too slow for routine use. This also > updates *everything*, which greatly simplifies rebasing patches > which effect multiple devices. Seems I goofed and should have Cc'd Christian Marangi when sending this. The script seems to work fine. One remaining issue is whether any adjustment to the commit messages on the generated commits is desired. I'm unsure they need "Signed-off-by" since they're tool-generated. I also wonder whether the script should claim to be the author. The one difference is this does all kernel configs in one pass. This seems superior as it makes rebasing proposed patches *much* simpler. Specifically there is far less update work without continuously appearing and disappearing configs. This also means only a single commit per year which troubles bisecting. -- (\___(\___(\__ --=> 8-) EHM <=-- __/)___/)___/) \BS (| ehem+sig...@m5p.com PGP 87145445 |) / \_CS\ | _ -O #include O- _ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel