On 12/28/20 2:11 PM, Hauke Mehrtens wrote:
On 12/24/20 10:28 PM, Ben Greear wrote:
I just pushed this commit. I'm interested in feedback if anyone tests
it. It could fix some of the strange tx issues, and for the 5.10 kernel,
at least, it fixes very obvious tx-path issues.
commit b753e8bf22b94297acbaa370b4cb0be87e3da4b8 (HEAD -> master, origin/master)
Author: Ben Greear
Date: Thu Dec 24 13:24:42 2020 -0800
ath10k-ct: Fix invalid use of ath-cb struct.
This fixes some cases where -ct firmware would attempt
to transmit a fixed-rate frame, thinking the packet was
injected, when in fact it was not.
Align the ath-cb pointers on 8-byte boundaries, which may
give a minor performance boost.
5.4 kernels and higher are modified, I'll check on older
kernels later.
Signed-off-by: Ben Greear
Hi,
This change is integrated in OpenWrt master:
https://git.openwrt.org/da9beb070d112469adeb30dd79dcde3176bfb290
Should we backport this change https://github.com/greearb/ath10k-ct/commit/b753e8bf22b94297acbaa370b4cb0be87e3da4b8 to ath10k-ct 4.19 for the openwrt 19.07
stable branch?
I think 4.19 will be OK as is, because the ieee80211_tx_info->control.flags is
at offset 32,
and the sizeof ath10k_skb_cb is 28, so the ath10k skb portion should never
overwrite
the control.flags.
Thanks,
Ben
Hauke
--
Ben Greear
Candela Technologies Inc http://www.candelatech.com
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
