Re: lantiq: upstream Linux efforts
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- Hello everyone, On Sun, Apr 11, 2021 at 7:51 PM Martin Blumenstingl wrote: [...] > To improve the situation I suggest using Rafał Miłecki's approach also > for the lantiq target: > He is submitting patches upstream, then backporting them to OpenWrt. > That way backports to the -stable tree are for free. > Other patches can simply be dropped during the next major kernel > version update (instead of having to rework them every time...). it's great to hear that there's lots of positive feedback for this idea! [...] > Therefore I would like to know who is interested in upstreaming more > patches and cleaning up some of the code which already exists > upstream? I started a repository to document the upstreaming status: [0] Aleksander, Hauke, Martin Schiller and Mathias should have write-access. Please feel free to add more TODOs there The idea is that we can find topics where multiple people are interested in and also avoid duplicated work Best regards, Martin [0] https://github.com/xdarklight/ltq-upstream-status --- End Message --- ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: lantiq: upstream Linux efforts
On 4/11/21 7:51 PM, Martin Blumenstingl wrote: > Hello everyone, > > you are included in this email because you have previously worked on > patches for the Lantiq SoCs upstream. > > In the past updating the kernel version for the lantiq target in > OpenWrt was an unpleasant task. > There are many out-of-tree patches and some of them are breaking with > newer kernel versions. > > To improve the situation I suggest using Rafał Miłecki's approach also > for the lantiq target: > He is submitting patches upstream, then backporting them to OpenWrt. > That way backports to the -stable tree are for free. > Other patches can simply be dropped during the next major kernel > version update (instead of having to rework them every time...). I also like this approach. > > This approach however only works when there are active contributors upstream. > It brings the benefit of upstream code-reviews though - which in my > experience improves the quality of the resulting code. > > Therefore I would like to know who is interested in upstreaming more > patches and cleaning up some of the code which already exists > upstream? > Saying that you are not interested is fine, there is no pressure on anyone. > > > Best regards, > Martin >I have a lot of lantiq based devices (xRX200, xRX330 and xRX350) and access to a VDSL line. If anyone needs testing, I can do it. Aleksander ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: lantiq: upstream Linux efforts
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- Hi Martin, On Mon, Apr 12, 2021 at 11:59 AM Martin Schiller wrote: [...] > >> This approach however only works when there are active contributors > >> upstream. > >> It brings the benefit of upstream code-reviews though - which in my > >> experience improves the quality of the resulting code. > > I think there's quite a bit of work involved. I don't expect that it'll be an easy task in my opinion the first step is to reject new patches which are not following this approach then we need to work out how to clean up the remaining parts > If you take for example the patch with the configurability of the LEDs > on the phys: > Hauke had already started one or more attempts to bring this upstream > [1], but this was "rejected" with the reason that this belongs in the > LED subsystem. > > Now I found an interesting solution on the mailing list, which > implements this function as hw offloading of the netdev trigger. [2] I think the original author abandoned this (unfortunately) maybe there's not too many issues left with that series? > Furthermore there are some patches for the target lantiq, which > unfortunately don't contain any description and so we have to work out > the deeper sense or necessity of this patch again. yep, agreed. Best regards, Martin --- End Message --- ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: lantiq: upstream Linux efforts
On 2021-04-12 00:24, Hauke Mehrtens wrote: Hi, On 4/11/21 7:51 PM, Martin Blumenstingl wrote: Hello everyone, you are included in this email because you have previously worked on patches for the Lantiq SoCs upstream. In the past updating the kernel version for the lantiq target in OpenWrt was an unpleasant task. There are many out-of-tree patches and some of them are breaking with newer kernel versions. To improve the situation I suggest using Rafał Miłecki's approach also for the lantiq target: He is submitting patches upstream, then backporting them to OpenWrt. That way backports to the -stable tree are for free. Other patches can simply be dropped during the next major kernel version update (instead of having to rework them every time...). I like this approach. I also like this approach. This approach however only works when there are active contributors upstream. It brings the benefit of upstream code-reviews though - which in my experience improves the quality of the resulting code. I think there's quite a bit of work involved. If you take for example the patch with the configurability of the LEDs on the phys: Hauke had already started one or more attempts to bring this upstream [1], but this was "rejected" with the reason that this belongs in the LED subsystem. Now I found an interesting solution on the mailing list, which implements this function as hw offloading of the netdev trigger. [2] @Hauke: what do you think about this? Furthermore there are some patches for the target lantiq, which unfortunately don't contain any description and so we have to work out the deeper sense or necessity of this patch again. [1] https://www.spinics.net/lists/netdev/msg380196.html [2] https://www.spinics.net/lists/linux-leds/msg17241.html ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: lantiq: upstream Linux efforts
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- Hi Hauke, On Mon, Apr 12, 2021 at 12:24 AM Hauke Mehrtens wrote: [...] > > Therefore I would like to know who is interested in upstreaming more > > patches and cleaning up some of the code which already exists > > upstream? > > Saying that you are not interested is fine, there is no pressure on anyone. > > Currently I do not plan to upstream anything for the lantiq target, but > I can help someone when he works on this topic. > > Thanks for your work on the DSA switch and fixing all the bugs in there. Having someone to discuss problems and to give some answers or hints from the datasheet has been very helpful. So also thanks to you :-) > What do you plan to do about the other patches still in the lantiq > target like the PCIe driver? I do have a few patches sitting in my tree which add the necessary bits for the Lantiq SoCs to the drivers/pci/controller/dwc/pcie-intel-gw.c driver (which is upstream since Linux 5.6) unfortunately this requires some extra work, including changes to the PCI driver (which needs to move away from the MIPS specific PCI bits and over to the "generic" PCI subsystem) That said, working on that is going to be easier when we have Linux 5.10 support (even if it's just the testing kernel version) Best regards, Martin --- End Message --- ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Re: lantiq: upstream Linux efforts
Hi, On 4/11/21 7:51 PM, Martin Blumenstingl wrote: Hello everyone, you are included in this email because you have previously worked on patches for the Lantiq SoCs upstream. In the past updating the kernel version for the lantiq target in OpenWrt was an unpleasant task. There are many out-of-tree patches and some of them are breaking with newer kernel versions. To improve the situation I suggest using Rafał Miłecki's approach also for the lantiq target: He is submitting patches upstream, then backporting them to OpenWrt. That way backports to the -stable tree are for free. Other patches can simply be dropped during the next major kernel version update (instead of having to rework them every time...). I like this approach. This approach however only works when there are active contributors upstream. It brings the benefit of upstream code-reviews though - which in my experience improves the quality of the resulting code. Therefore I would like to know who is interested in upstreaming more patches and cleaning up some of the code which already exists upstream? Saying that you are not interested is fine, there is no pressure on anyone. Currently I do not plan to upstream anything for the lantiq target, but I can help someone when he works on this topic. Thanks for your work on the DSA switch and fixing all the bugs in there. What do you plan to do about the other patches still in the lantiq target like the PCIe driver? Hauke ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
lantiq: upstream Linux efforts
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- Hello everyone, you are included in this email because you have previously worked on patches for the Lantiq SoCs upstream. In the past updating the kernel version for the lantiq target in OpenWrt was an unpleasant task. There are many out-of-tree patches and some of them are breaking with newer kernel versions. To improve the situation I suggest using Rafał Miłecki's approach also for the lantiq target: He is submitting patches upstream, then backporting them to OpenWrt. That way backports to the -stable tree are for free. Other patches can simply be dropped during the next major kernel version update (instead of having to rework them every time...). This approach however only works when there are active contributors upstream. It brings the benefit of upstream code-reviews though - which in my experience improves the quality of the resulting code. Therefore I would like to know who is interested in upstreaming more patches and cleaning up some of the code which already exists upstream? Saying that you are not interested is fine, there is no pressure on anyone. Best regards, Martin --- End Message --- ___ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
