Re: [osg-users] [Toward BufferObject serialization] Geometry serializer FinishedObjectReadCallback???
I surely understand that... So Would there any test set that could ensure removal of this code doesn't break anything? (I would like to submit changes I made for BufferObject and TransformFeedBack serialization but i'd rather lever any doubts about its integration first) robertosfield wrote: > On 23 May 2016 at 12:08, Julien Valentin <> wrote: > > > Searching posts at this period -oct 2010- i found this post > > http://forum.openscenegraph.org/viewtopic.php?t=6826 > > does it recall anything? > > > > This does look relevant, I have a vague recollection, but not yet > enough of the different threads to know what specific motivations > were. 5 and half years and lots of topics covered in between so > things are a little blurred :-) > > Robert. > ___ > osg-users mailing list > > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > > -- > Post generated by Mail2Forum -- Read this topic online here: http://forum.openscenegraph.org/viewtopic.php?p=67208#67208 ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] [Toward BufferObject serialization] Geometry serializer FinishedObjectReadCallback???
On 23 May 2016 at 12:08, Julien Valentin wrote: > Searching posts at this period -oct 2010- i found this post > http://forum.openscenegraph.org/viewtopic.php?t=6826 > does it recall anything? This does look relevant, I have a vague recollection, but not yet enough of the different threads to know what specific motivations were. 5 and half years and lots of topics covered in between so things are a little blurred :-) Robert. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] [Toward BufferObject serialization] Geometry serializer FinishedObjectReadCallback???
Searching posts at this period -oct 2010- i found this post
http://forum.openscenegraph.org/viewtopic.php?t=6826
does it recall anything?
robertosfield wrote:
> Hi Julian,
>
> Thanks for tracking down the commit. I did a quick search for related
> discussions on osg-users but haven't spotted anything around the right
> time frame (late October 2010). There is probably something in
> osg-submissions and osg-users that discusses this as I don't think
> it'll be something that I would have applied without some wider issue
> discussion.
>
> Robert.
>
> On 23 May 2016 at 11:15, Julien Valentin <> wrote:
>
> > Thanks Robert
> >
> > According to the git log:
> >
> >
> > > commit 57a0065d08b3aa5b06da54a7b78ea2ae36cb2c9a
> > > Author: Robert OSFIELD <>
> > > Date: Thu Oct 28 14:04:57 2010 +
> > >
> > > Added use ObjectWrapper's FinishObjectReadCallback to fix
> > > VertexBufferObject handling in osg::Geometry
> > > and a call to the TileLoaded callback in osgTerrain.
> > >
> > >
> > >
> >
> >
> > But -and perhaps I haven't investigated enough- I still don't understand
> > what problem with VertexBufferObject it fixed...
> >
> >
> >
> > robertosfield wrote:
> >
> > > Hi Julian,
> > >
> > > I have a vague recollection that this callback had to be used to force
> > > the VBO to be built or something along those lines. Off the top of my
> > > head I don't recall the exact problem that instigated the change and
> > > the contributor that came up with this solution. Perhaps git log for
> > > the files in question might help piece together why it's done.
> > >
> > > Robert.
> > >
> > > On 20 May 2016 at 17:35, Julien Valentin <> wrote:
> > >
> > >
> > > > Hi,all
> > > > I would like to provide osg TransformFeedback serialization feature but
> > > > something weird forbid BufferObject serialization:
> > > > This callback calls setUseVertexBufferObjects(false) and just kill all
> > > > BufferObject attached the geometry's BufferDatas
> > > >
> > > >
> > > > Code:
> > > > struct GeometryFinishedObjectReadCallback : public
> > > > osgDB::FinishedObjectReadCallback
> > > > {
> > > > virtual void objectRead(osgDB::InputStream&, osg::Object& obj)
> > > > {
> > > > osg::Geometry& geometry = static_cast(obj);
> > > > if (geometry.getUseVertexBufferObjects())
> > > > {
> > > > geometry.setUseVertexBufferObjects(false);
> > > > geometry.setUseVertexBufferObjects(true);
> > > > }
> > > > }
> > > > };
> > > >
> > > >
> > > > I don't understand the utility of this callback (surely because I want
> > > > to remove it:) )
> > > > Does anyone know its purpose?
> > > >
> > > > Thank you!
> > > >
> > > > Cheers,
> > > > Julien
> > > >
> > > > --
> > > > Read this topic online here:
> > > > http://forum.openscenegraph.org/viewtopic.php?p=67181#67181
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > ___
> > > > osg-users mailing list
> > > >
> > > > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
> > > >
> > > >
> > > ___
> > > osg-users mailing list
> > >
> > > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
> > >
> > > --
> > > Post generated by Mail2Forum
> > >
> >
> >
> > --
> > Read this topic online here:
> > http://forum.openscenegraph.org/viewtopic.php?p=67204#67204
> >
> >
> >
> >
> >
> > ___
> > osg-users mailing list
> >
> > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
> >
> ___
> osg-users mailing list
>
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>
> --
> Post generated by Mail2Forum
--
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=67206#67206
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] [Toward BufferObject serialization] Geometry serializer FinishedObjectReadCallback???
Hi Julian,
Thanks for tracking down the commit. I did a quick search for related
discussions on osg-users but haven't spotted anything around the right
time frame (late October 2010). There is probably something in
osg-submissions and osg-users that discusses this as I don't think
it'll be something that I would have applied without some wider issue
discussion.
Robert.
On 23 May 2016 at 11:15, Julien Valentin wrote:
> Thanks Robert
>
> According to the git log:
>
>> commit 57a0065d08b3aa5b06da54a7b78ea2ae36cb2c9a
>> Author: Robert OSFIELD <>
>> Date: Thu Oct 28 14:04:57 2010 +
>>
>> Added use ObjectWrapper's FinishObjectReadCallback to fix
>> VertexBufferObject handling in osg::Geometry
>> and a call to the TileLoaded callback in osgTerrain.
>>
>>
>
>
> But -and perhaps I haven't investigated enough- I still don't understand what
> problem with VertexBufferObject it fixed...
>
>
>
> robertosfield wrote:
>> Hi Julian,
>>
>> I have a vague recollection that this callback had to be used to force
>> the VBO to be built or something along those lines. Off the top of my
>> head I don't recall the exact problem that instigated the change and
>> the contributor that came up with this solution. Perhaps git log for
>> the files in question might help piece together why it's done.
>>
>> Robert.
>>
>> On 20 May 2016 at 17:35, Julien Valentin <> wrote:
>>
>> > Hi,all
>> > I would like to provide osg TransformFeedback serialization feature but
>> > something weird forbid BufferObject serialization:
>> > This callback calls setUseVertexBufferObjects(false) and just kill all
>> > BufferObject attached the geometry's BufferDatas
>> >
>> >
>> > Code:
>> > struct GeometryFinishedObjectReadCallback : public
>> > osgDB::FinishedObjectReadCallback
>> > {
>> > virtual void objectRead(osgDB::InputStream&, osg::Object& obj)
>> > {
>> > osg::Geometry& geometry = static_cast(obj);
>> > if (geometry.getUseVertexBufferObjects())
>> > {
>> > geometry.setUseVertexBufferObjects(false);
>> > geometry.setUseVertexBufferObjects(true);
>> > }
>> > }
>> > };
>> >
>> >
>> > I don't understand the utility of this callback (surely because I want to
>> > remove it:) )
>> > Does anyone know its purpose?
>> >
>> > Thank you!
>> >
>> > Cheers,
>> > Julien
>> >
>> > --
>> > Read this topic online here:
>> > http://forum.openscenegraph.org/viewtopic.php?p=67181#67181
>> >
>> >
>> >
>> >
>> >
>> > ___
>> > osg-users mailing list
>> >
>> > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>> >
>> ___
>> osg-users mailing list
>>
>> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>>
>> --
>> Post generated by Mail2Forum
>
>
> --
> Read this topic online here:
> http://forum.openscenegraph.org/viewtopic.php?p=67204#67204
>
>
>
>
>
> ___
> osg-users mailing list
> osg-users@lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] [Toward BufferObject serialization] Geometry serializer FinishedObjectReadCallback???
Thanks Robert
According to the git log:
> commit 57a0065d08b3aa5b06da54a7b78ea2ae36cb2c9a
> Author: Robert OSFIELD <>
> Date: Thu Oct 28 14:04:57 2010 +
>
> Added use ObjectWrapper's FinishObjectReadCallback to fix
> VertexBufferObject handling in osg::Geometry
> and a call to the TileLoaded callback in osgTerrain.
>
>
But -and perhaps I haven't investigated enough- I still don't understand what
problem with VertexBufferObject it fixed...
robertosfield wrote:
> Hi Julian,
>
> I have a vague recollection that this callback had to be used to force
> the VBO to be built or something along those lines. Off the top of my
> head I don't recall the exact problem that instigated the change and
> the contributor that came up with this solution. Perhaps git log for
> the files in question might help piece together why it's done.
>
> Robert.
>
> On 20 May 2016 at 17:35, Julien Valentin <> wrote:
>
> > Hi,all
> > I would like to provide osg TransformFeedback serialization feature but
> > something weird forbid BufferObject serialization:
> > This callback calls setUseVertexBufferObjects(false) and just kill all
> > BufferObject attached the geometry's BufferDatas
> >
> >
> > Code:
> > struct GeometryFinishedObjectReadCallback : public
> > osgDB::FinishedObjectReadCallback
> > {
> > virtual void objectRead(osgDB::InputStream&, osg::Object& obj)
> > {
> > osg::Geometry& geometry = static_cast(obj);
> > if (geometry.getUseVertexBufferObjects())
> > {
> > geometry.setUseVertexBufferObjects(false);
> > geometry.setUseVertexBufferObjects(true);
> > }
> > }
> > };
> >
> >
> > I don't understand the utility of this callback (surely because I want to
> > remove it:) )
> > Does anyone know its purpose?
> >
> > Thank you!
> >
> > Cheers,
> > Julien
> >
> > --
> > Read this topic online here:
> > http://forum.openscenegraph.org/viewtopic.php?p=67181#67181
> >
> >
> >
> >
> >
> > ___
> > osg-users mailing list
> >
> > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
> >
> ___
> osg-users mailing list
>
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>
> --
> Post generated by Mail2Forum
--
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=67204#67204
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] [Toward BufferObject serialization] Geometry serializer FinishedObjectReadCallback???
Hi Julian,
I have a vague recollection that this callback had to be used to force
the VBO to be built or something along those lines. Off the top of my
head I don't recall the exact problem that instigated the change and
the contributor that came up with this solution. Perhaps git log for
the files in question might help piece together why it's done.
Robert.
On 20 May 2016 at 17:35, Julien Valentin wrote:
> Hi,all
> I would like to provide osg TransformFeedback serialization feature but
> something weird forbid BufferObject serialization:
> This callback calls setUseVertexBufferObjects(false) and just kill all
> BufferObject attached the geometry's BufferDatas
>
>
> Code:
> struct GeometryFinishedObjectReadCallback : public
> osgDB::FinishedObjectReadCallback
> {
> virtual void objectRead(osgDB::InputStream&, osg::Object& obj)
> {
> osg::Geometry& geometry = static_cast(obj);
> if (geometry.getUseVertexBufferObjects())
> {
> geometry.setUseVertexBufferObjects(false);
> geometry.setUseVertexBufferObjects(true);
> }
> }
> };
>
>
> I don't understand the utility of this callback (surely because I want to
> remove it:) )
> Does anyone know its purpose?
>
> Thank you!
>
> Cheers,
> Julien
>
> --
> Read this topic online here:
> http://forum.openscenegraph.org/viewtopic.php?p=67181#67181
>
>
>
>
>
> ___
> osg-users mailing list
> osg-users@lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
[osg-users] [Toward BufferObject serialization] Geometry serializer FinishedObjectReadCallback???
Hi,all
I would like to provide osg TransformFeedback serialization feature but
something weird forbid BufferObject serialization:
This callback calls setUseVertexBufferObjects(false) and just kill all
BufferObject attached the geometry's BufferDatas
Code:
struct GeometryFinishedObjectReadCallback : public
osgDB::FinishedObjectReadCallback
{
virtual void objectRead(osgDB::InputStream&, osg::Object& obj)
{
osg::Geometry& geometry = static_cast(obj);
if (geometry.getUseVertexBufferObjects())
{
geometry.setUseVertexBufferObjects(false);
geometry.setUseVertexBufferObjects(true);
}
}
};
I don't understand the utility of this callback (surely because I want to
remove it:) )
Does anyone know its purpose?
Thank you!
Cheers,
Julien
--
Read this topic online here:
http://forum.openscenegraph.org/viewtopic.php?p=67181#67181
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
