Re: [osg-users] DatabasePager priority simplifier and stats added
It works now ! Tanks ! Christophe 2007/9/4, Zach Deedler <[EMAIL PROTECTED]>: > > Or you can set the windows environment variable: > > set OSG_DATABASE_PAGER_PRIORITY=HIGH > > > > (or set it in the system settings; Start Menu->Control > Panel->System->Advanced->Environment Variables) > > > -- > > *From:* [EMAIL PROTECTED] [mailto: > [EMAIL PROTECTED] *On Behalf Of *Serge Lages > *Sent:* Monday, September 03, 2007 12:03 PM > *To:* osg-users@lists.openscenegraph.org > *Subject:* Re: [osg-users] DatabasePager priority simplifier and stats > added > > > > Hi Christophe, > > On 9/3/07, *christophe loustaunau* <[EMAIL PROTECTED]> > wrote: > > Hello, > > > > I wan't to test the new databasePager priority, but I don't know how to > use it... > > > > If I do : > > export OSG_DATABASE_PAGER_PRIORITY=HIGH; > > > > I have some errors like : > > > > warning C4237: 'export' keyword is not yet supported, but reserved for > future use > > error C2146: syntax error : missing ';' before identifier > 'OSG_DATABASE_PAGER_PRIORITY' > > > > > > What I am doing wrong ? > > > > > export OSG_DATABASE_PAGER_PRIORITY=HIGH is the Linux way to set an > environment variable. > If you want to set it into your code, you should try something like: > viewer.getDatabasePager > ()->setScedulePriority(OpenThreads::THREAD_PRIORITY_*); > (setting THREAD_PRIORITY_* the value you want). > > -- > Serge Lages > http://www.magrathea-engine.org > > ___ > osg-users mailing list > osg-users@lists.openscenegraph.org > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > > ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] DatabasePager priority simplifier and stats added
Or you can set the windows environment variable: set OSG_DATABASE_PAGER_PRIORITY=HIGH (or set it in the system settings; Start Menu->Control Panel->System->Advanced->Environment Variables) _ From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Serge Lages Sent: Monday, September 03, 2007 12:03 PM To: osg-users@lists.openscenegraph.org Subject: Re: [osg-users] DatabasePager priority simplifier and stats added Hi Christophe, On 9/3/07, christophe loustaunau <[EMAIL PROTECTED]> wrote: Hello, I wan't to test the new databasePager priority, but I don't know how to use it... If I do : export OSG_DATABASE_PAGER_PRIORITY=HIGH; I have some errors like : warning C4237: 'export' keyword is not yet supported, but reserved for future use error C2146: syntax error : missing ';' before identifier 'OSG_DATABASE_PAGER_PRIORITY' What I am doing wrong ? export OSG_DATABASE_PAGER_PRIORITY=HIGH is the Linux way to set an environment variable. If you want to set it into your code, you should try something like: viewer.getDatabasePager()->setScedulePriority(OpenThreads::THREAD_PRIORITY_* ); (setting THREAD_PRIORITY_* the value you want). -- Serge Lages http://www.magrathea-engine.org ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] DatabasePager priority simplifier and stats added
Hi Christophe, On 9/3/07, christophe loustaunau <[EMAIL PROTECTED]> wrote: > > Hello, > > I wan't to test the new databasePager priority, but I don't know how to > use it... > > If I do : > export OSG_DATABASE_PAGER_PRIORITY=HIGH; > > I have some errors like : > > warning C4237: 'export' keyword is not yet supported, but reserved for > future use > error C2146: syntax error : missing ';' before identifier > 'OSG_DATABASE_PAGER_PRIORITY' > > > What I am doing wrong ? > > export OSG_DATABASE_PAGER_PRIORITY=HIGH is the Linux way to set an environment variable. If you want to set it into your code, you should try something like: viewer.getDatabasePager ()->setScedulePriority(OpenThreads::THREAD_PRIORITY_*); (setting THREAD_PRIORITY_* the value you want). -- Serge Lages http://www.magrathea-engine.org ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] DatabasePager priority simplifier and stats added
Hello, I wan't to test the new databasePager priority, but I don't know how to use it... If I do : export OSG_DATABASE_PAGER_PRIORITY=HIGH; I have some errors like : warning C4237: 'export' keyword is not yet supported, but reserved for future use error C2146: syntax error : missing ';' before identifier 'OSG_DATABASE_PAGER_PRIORITY' What I am doing wrong ? Thanks. Christophe 2007/8/27, Adrian Egli <[EMAIL PROTECTED]>: > > Hi Robert, > > i will test it on my OS/X system, than on the same system with windows XP > (dual core), i hope i can do it tomorrow. Better means, better than the old > DB Pager implementation, before you did the changes. > > adegli > > 2007/8/27, Robert Osfield <[EMAIL PROTECTED]>: > > > > Hi Adrian, > > > > On 8/27/07, Adrian Egli <[EMAIL PROTECTED]> wrote: > > > the performance is better now with the fix you did. > > > > Thanks for the feedback. Could you qualify better, is it now good > > enough/anywhere close to paging performance under linux? > > > > I am curious about the changes you've made in your subclass from > > DatabasePager, so any of the changes now made to the core version make > > this unnecessary? > > > > Robert. > > ___ > > osg-users mailing list > > osg-users@lists.openscenegraph.org > > > > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > > > > > > -- > > Adrian Egli > ___ > osg-users mailing list > osg-users@lists.openscenegraph.org > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > > ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] DatabasePager priority simplifier and stats added
Hi Robert, i will test it on my OS/X system, than on the same system with windows XP (dual core), i hope i can do it tomorrow. Better means, better than the old DB Pager implementation, before you did the changes. adegli 2007/8/27, Robert Osfield <[EMAIL PROTECTED]>: > > Hi Adrian, > > On 8/27/07, Adrian Egli <[EMAIL PROTECTED]> wrote: > > the performance is better now with the fix you did. > > Thanks for the feedback. Could you qualify better, is it now good > enough/anywhere close to paging performance under linux? > > I am curious about the changes you've made in your subclass from > DatabasePager, so any of the changes now made to the core version make > this unnecessary? > > Robert. > ___ > osg-users mailing list > osg-users@lists.openscenegraph.org > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > -- Adrian Egli ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] DatabasePager priority simplifier and stats added
Hi Adrian, On 8/27/07, Adrian Egli <[EMAIL PROTECTED]> wrote: > the performance is better now with the fix you did. Thanks for the feedback. Could you qualify better, is it now good enough/anywhere close to paging performance under linux? I am curious about the changes you've made in your subclass from DatabasePager, so any of the changes now made to the core version make this unnecessary? Robert. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] DatabasePager priority simplifier and stats added
Hi robert, the performance is better now with the fix you did. regards 2007/8/24, Adrian Egli <[EMAIL PROTECTED]>: > > Hi Robert, > > i did the first test and it's seems working. Over this weekend i will try > to do some tests on single core systems. monday i will post next information > on this topics. > > /adegli > > 2007/8/24, Robert Osfield <[EMAIL PROTECTED]>: > > > > On 8/24/07, Robert Osfield <[EMAIL PROTECTED]> wrote: > > > I am tempted to add an env check to be able to set the priority. > > > > I have now checked this in. From osgviewer --help-env: > > > > OSG_DATABASE_PAGER_PRIORITY Set the thread priority to > > DEFAULT, MIN, LOW, > > NOMINAL, > > HIGH or MAX. > > > > > > export OSG_DATABASE_PAGER_PRIORITY=HIGH > > osgviewer mypageddata.ive > > > > With this change I have also removed the old part thats the priority > > to min so the new default thread priority for the DatabasePager will > > be that of OpenThreads::Thread. > > > > Could database paging users do an svn update and let me know how that > > new priority code (or lack of it - now just using defaults :-) and the > > stats works out. In particular I'm keen to here from Windows single > > core system users. > > > > Thanks, > > Robert. > > ___ > > osg-users mailing list > > osg-users@lists.openscenegraph.org > > > > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > > > > > > -- > > Adrian Egli -- Adrian Egli ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] DatabasePager priority simplifier and stats added
Hi Robert, i did the first test and it's seems working. Over this weekend i will try to do some tests on single core systems. monday i will post next information on this topics. /adegli 2007/8/24, Robert Osfield <[EMAIL PROTECTED]>: > > On 8/24/07, Robert Osfield <[EMAIL PROTECTED]> wrote: > > I am tempted to add an env check to be able to set the priority. > > I have now checked this in. From osgviewer --help-env: > > OSG_DATABASE_PAGER_PRIORITY Set the thread priority to > DEFAULT, MIN, LOW, > NOMINAL, > HIGH or MAX. > > > export OSG_DATABASE_PAGER_PRIORITY=HIGH > osgviewer mypageddata.ive > > With this change I have also removed the old part thats the priority > to min so the new default thread priority for the DatabasePager will > be that of OpenThreads::Thread. > > Could database paging users do an svn update and let me know how that > new priority code (or lack of it - now just using defaults :-) and the > stats works out. In particular I'm keen to here from Windows single > core system users. > > Thanks, > Robert. > ___ > osg-users mailing list > osg-users@lists.openscenegraph.org > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > -- Adrian Egli ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] DatabasePager priority simplifier and stats added
On 8/24/07, Robert Osfield <[EMAIL PROTECTED]> wrote: > I am tempted to add an env check to be able to set the priority. I have now checked this in. From osgviewer --help-env: OSG_DATABASE_PAGER_PRIORITY Set the thread priority to DEFAULT, MIN, LOW, NOMINAL, HIGH or MAX. export OSG_DATABASE_PAGER_PRIORITY=HIGH osgviewer mypageddata.ive With this change I have also removed the old part thats the priority to min so the new default thread priority for the DatabasePager will be that of OpenThreads::Thread. Could database paging users do an svn update and let me know how that new priority code (or lack of it - now just using defaults :-) and the stats works out. In particular I'm keen to here from Windows single core system users. Thanks, Robert. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
[osg-users] DatabasePager priority simplifier and stats added
Hi All, I have just simplified the thread priority management in the DatabasePager and added stats support to the DatabasePager, as well as use of this to the osgViewer::StatsHandler. An svn update will get these changes. The four new methods added to DatabasePager are: /** Get the minimum time between the first request for a tile to be loaded and the time of its merge into the main scene graph.*/ double getMinimumTimeToMergeTile() const { return _minimumTimeToMergeTile; } /** Get the maximum time between the first request for a tile to be loaded and the time of its merge into the main scene graph.*/ double getMaximumTimeToMergeTile() const { return _maximumTimeToMergeTile; } /** Get the average time between the first request for a tile to be loaded and the time of its merge into the main scene graph.*/ double getAverageTimeToMergeTiles() const { return _totalTimeToMergeTiles/static_cast(_numTilesMerges); } /** Reset the Stats variables.*/ void resetStats(); I have removed the following thread priority methods: void setUseFrameBlock(bool useFrameBlock) { _useFrameBlock = bool getUseFrameBlock() const osg::RefBlock* getFrameBlock() void setThreadPriorityDuringFrame(ThreadPriority) void setThreadPriorityOutwithFrame(ThreadPriority) To control the thread priority you now simply use the standard OpenThreads::Thread ::setSchedulePriority(..) method i.e. viewer.getDatabasePager()->setScedulePriority(OpenThreads::THREAD_PRIORITY_NORMAL); Previously the thread priority was THREAD_PRIORITY_MIN so I've left it as this so users can look at the database pager stats before we make any changes. It has been suggested that Windows on single core systems doesn't cope well with these as the default setting so something like THREAD_PRIORITY_DEFAULT would be better. I'd like to get feedback on this - upping the priority will make things page in quicker, but increase the chance of breaking frame. I am tempted to add an env check to be able to set the priority. Robert. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org