Re: [osg-users] Inconsistency for INSTALL target and BUILD_DOCUMENTATION

2009-01-24 Thread Jean-Sébastien Guay

Hi Mattias,


I don't think I can produce a fix before 2.8. Others are welcome of course ;-)


Nah, don't sweat it, as I said it's just a minor inconsistency. We could 
in fact just document it and it would be sufficient I think.


Thanks for explaining the details, it makes it clearer for me.

J-S
--
__
Jean-Sebastien Guayjean-sebastien.g...@cm-labs.com
   http://www.cm-labs.com/
http://whitestar02.webhop.org/
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


Re: [osg-users] Inconsistency for INSTALL target and BUILD_DOCUMENTATION

2009-01-24 Thread Mattias Helsing
Hi J-S,

On Fri, Jan 23, 2009 at 10:33 PM, Jean-Sébastien Guay
 wrote:
> Hi all,
>
> I just noticed a small inconsistency. Normally, the INSTALL target should
> have as dependencies any other targets that it needs to install. But it
> seems that the documentation targets (openscenegraph_doc and
> openthreads_doc) are not dependencies of the INSTALL target. But they should
> be.

yes I know. I haven't come up with a good solution for this. The
simple solution is to make the doc_* targets part of the ALL build.
This is possible but *really* bad because these targets (or doxygen)
don't have a proper dep chain. Doxygen would regenerate documentation
every time you build.

Perhaps one could come up with some clever custom_targets to get this
to work but haven't had the time yet.

>
> If I have previously built the documentation, the INSTALL target installs it
> to its proper place. But if I have not explicitly built the docs myself, the
> INSTALL target does not build them and hence does not install the docs
> (though it doesn't give any error either).

The install command used for these targets are of type
INSTALL(DIRECTORY ...) so they will put an existing directory
wherever. Yhe directory exists so cmake happily installs it and
doesn't care that it only contains a directory and an image file. The
solution to the previous problem will solve this one too.

>
> The package targets all seem to have the right dependencies though.
>
> It's a small detail, and probably not worth holding up 2.8, but I just found
> it weird... Perhaps someone with the necessary knowledge could fix it?

I don't think I can produce a fix before 2.8. Others are welcome of course ;-)

Mattias

>
> J-S
> --
> __
> Jean-Sebastien Guayjean-sebastien.g...@cm-labs.com
>   http://www.cm-labs.com/
>http://whitestar02.webhop.org/
> ___
> osg-users mailing list
> osg-users@lists.openscenegraph.org
> http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
>
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org


[osg-users] Inconsistency for INSTALL target and BUILD_DOCUMENTATION

2009-01-23 Thread Jean-Sébastien Guay

Hi all,

I just noticed a small inconsistency. Normally, the INSTALL target 
should have as dependencies any other targets that it needs to install. 
But it seems that the documentation targets (openscenegraph_doc and 
openthreads_doc) are not dependencies of the INSTALL target. But they 
should be.


If I have previously built the documentation, the INSTALL target 
installs it to its proper place. But if I have not explicitly built the 
docs myself, the INSTALL target does not build them and hence does not 
install the docs (though it doesn't give any error either).


The package targets all seem to have the right dependencies though.

It's a small detail, and probably not worth holding up 2.8, but I just 
found it weird... Perhaps someone with the necessary knowledge could fix it?


J-S
--
__
Jean-Sebastien Guayjean-sebastien.g...@cm-labs.com
   http://www.cm-labs.com/
http://whitestar02.webhop.org/
___
osg-users mailing list
osg-users@lists.openscenegraph.org
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org