Re: [osg-users] What is the policy concerning ref_ptr implicit conversion in OSG itself?
Hi JS, On Wed, Jun 17, 2009 at 2:30 PM, Jean-Sébastien Guay wrote: >> For the 2.10 release we'll need to do this same check, please don't >> assume I'll remember and test it out yourself to make sure that I >> don't miss anything. > > OK, so I assume the policy I was asking about is: keep the option and > continue to make sure OSG itself compiles cleanly with both settings. Yes this is the current policy, but it's a little informal. As long as the code base can be easily maintained to work without the implicit casts I'm happy to maintain backwards compatibility. There might be a point in the future that the pain vs gain no longer justifies this - for instance an OSG-3.0 we might just drop this as other sweeping changes would not be backwards compatible anyway. > It should really have been made explicit before, so that all contributors > remember to use .get() when necessary. Now it is, thanks. I'm note quite where little things like this might be made explicit - on the wiki, on mailing lists threds. There are lots of little things that we could potential tie down and formalize, but many things are that cast in stone and evolve, often it's just easier to take things as they come as resolve problems as they arise. Robert. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] What is the policy concerning ref_ptr implicit conversion in OSG itself?
Hi Robert, For the 2.10 release we'll need to do this same check, please don't assume I'll remember and test it out yourself to make sure that I don't miss anything. OK, so I assume the policy I was asking about is: keep the option and continue to make sure OSG itself compiles cleanly with both settings. It should really have been made explicit before, so that all contributors remember to use .get() when necessary. Now it is, thanks. J-S -- __ Jean-Sebastien Guayjean-sebastien.g...@cm-labs.com http://www.cm-labs.com/ http://whitestar02.webhop.org/ ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] What is the policy concerning ref_ptr implicit conversion in OSG itself?
Hi JS, On Wed, Jun 17, 2009 at 9:33 AM, Robert Osfield wrote: > Periodically I do test the OSG build with > OSG_USE_REF_PTR_IMPLICIT_OUTPUT_CONVERSION off, but I haven't don't it > recently - I'll fire off a build this morning and fix any problems > that arise. I've now got svn/trunk compiling cleanly with OSG_USE_REF_PTR_IMPLICIT_OUTPUT_CONVERSION set to OFF, and svn update will get these fixes. I also checked the OSG-2.8 branch and it's clean already and didn't require any mods. For the 2.10 release we'll need to do this same check, please don't assume I'll remember and test it out yourself to make sure that I don't miss anything. Cheers, Robert. ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] What is the policy concerning ref_ptr implicit conversion in OSG itself?
Hi JS, Periodically I do test the OSG build with OSG_USE_REF_PTR_IMPLICIT_OUTPUT_CONVERSION off, but I haven't don't it recently - I'll fire off a build this morning and fix any problems that arise. Robert. On Tue, Jun 16, 2009 at 8:23 PM, Jean-Sébastien Guay wrote: > Hi all, > > I'm compiling OSG with OSG_USE_REF_PTR_IMPLICIT_OUTPUT_CONVERSION off > because our own software can interchangeably use OSG 2.2, 2.6 and > (eventually) 2.10, so I need to be sure everywhere a ref_ptr is used, .get() > or .valid() is used to get it or check it. > > Unfortunately, even OSG itself doesn't compile cleanly with > OSG_USE_REF_PTR_IMPLICIT_OUTPUT_CONVERSION off right now. (I'll submit some > changed files soon to fix that) > > So I was wondering if the policy was that code inside OSG should continue to > use .get() and .valid() so that it continues to build cleanly whether > OSG_USE_REF_PTR_IMPLICIT_OUTPUT_CONVERSION is on or off, or if we should > just phase out the OSG_USE_REF_PTR_IMPLICIT_OUTPUT_CONVERSION option > altogether (always keep it on, not expose it in CMake). > > I think whatever policy is chosen within OSG, it should be made clear. > Client code could do what it wants and it's the client's responsibility to > make sure they're using the right thing with respect to the version of OSG > they link to, but within OSG, we need to pick one. > > Thanks in advance, > > J-S > -- > __ > Jean-Sebastien Guay jean-sebastien.g...@cm-labs.com > http://www.cm-labs.com/ > http://whitestar02.webhop.org/ > ___ > osg-users mailing list > osg-users@lists.openscenegraph.org > http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org > ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
[osg-users] What is the policy concerning ref_ptr implicit conversion in OSG itself?
Hi all, I'm compiling OSG with OSG_USE_REF_PTR_IMPLICIT_OUTPUT_CONVERSION off because our own software can interchangeably use OSG 2.2, 2.6 and (eventually) 2.10, so I need to be sure everywhere a ref_ptr is used, .get() or .valid() is used to get it or check it. Unfortunately, even OSG itself doesn't compile cleanly with OSG_USE_REF_PTR_IMPLICIT_OUTPUT_CONVERSION off right now. (I'll submit some changed files soon to fix that) So I was wondering if the policy was that code inside OSG should continue to use .get() and .valid() so that it continues to build cleanly whether OSG_USE_REF_PTR_IMPLICIT_OUTPUT_CONVERSION is on or off, or if we should just phase out the OSG_USE_REF_PTR_IMPLICIT_OUTPUT_CONVERSION option altogether (always keep it on, not expose it in CMake). I think whatever policy is chosen within OSG, it should be made clear. Client code could do what it wants and it's the client's responsibility to make sure they're using the right thing with respect to the version of OSG they link to, but within OSG, we need to pick one. Thanks in advance, J-S -- __ Jean-Sebastien Guayjean-sebastien.g...@cm-labs.com http://www.cm-labs.com/ http://whitestar02.webhop.org/ ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
