Re: [osg-users] removal of OSG specific environment variables from find modules
On Thu, May 14, 2009 at 10:10 AM, Jean-Sébastien Guay < jean-sebastien.g...@cm-labs.com> wrote: > Hi Philip, > > Does anyone depend on the OSG_ROOT, OSGDIR, and OSG_DIR environment and/or >> registry session variables in the non-OSG related CMake find modules in >> CMakeModules? >> > > I don't think so, it would be a bit weird wouldn't it? What was the > rationale in using those in those modules in the first place? I'm guessing it's just copy-and-paste from already existing find modules. The only other explanation is it was intentional, to pick up the import libraries distributed with the OSG 2.2/2.4 installer. This seems awfully dangerous to me (if this even works at all still for VS8 users) so I'll be submitting the fix to osg-submissions shortly. -- Philip Lowman ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] removal of OSG specific environment variables from find modules
Hi Philip, Does anyone depend on the OSG_ROOT, OSGDIR, and OSG_DIR environment and/or registry session variables in the non-OSG related CMake find modules in CMakeModules? I don't think so, it would be a bit weird wouldn't it? What was the rationale in using those in those modules in the first place? Are there any objections to removing these variables? Not from me. J-S -- __ Jean-Sebastien Guayjean-sebastien.g...@cm-labs.com http://www.cm-labs.com/ http://whitestar02.webhop.org/ ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
[osg-users] removal of OSG specific environment variables from find modules
Hi all, Does anyone depend on the OSG_ROOT, OSGDIR, and OSG_DIR environment and/or registry session variables in the non-OSG related CMake find modules in CMakeModules? Are there any objections to removing these variables? FindCOLLADA.cmake FindFFmpeg.cmake FindFLTK.cmake etc. If you have the old OSG 2.2/2.4 binary package installed, these find modules end up detecting libraries within C:\Program Files\OpenSceneGraph. This is rather annoying when configuring a MinGW build and could cause weird errors on newer builds of the OSG as well as dependencies, compilers, etc. are updated. -- Philip Lowman ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org