Re: [osg-users] request for small source change in StandardShadowMap
Hi Nick, There isn't any way of me judging changes I haven't seen. In general if there is part of the OSG that isn't able to do what a users need it to do but a small change that is consistent with the overall design can achieve this then I'll be open to considering it to be merged. However, I have to see the code to know. It could also be that what you are trying to do can be done without any mods. Robert. On 14 April 2014 19:58, Trajce Nikolov NICK trajce.nikolov.n...@gmail.com wrote: Hi Robert, I am not sure if you are familiar with this code ( I bet You are ;-) ). I have a case where I want to mix shaders with the one that are provided to this class and I need access through the interface to the osg::Program which holds these shaders and it is instantiated locally in the scope of some method - StandardShadowMap.cpp Line: 544. I would welcome something like getProgram() and expose this object to the interface. Are you friendly to such a change - it won't brake anything. Please let me know Nick -- trajce nikolov nick ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
Re: [osg-users] request for small source change in StandardShadowMap
Hi Robert, let me do the changes then and I will send them to You so You decide. And thanks! Nick On Thu, Apr 17, 2014 at 10:44 AM, Robert Osfield robert.osfi...@gmail.comwrote: Hi Nick, There isn't any way of me judging changes I haven't seen. In general if there is part of the OSG that isn't able to do what a users need it to do but a small change that is consistent with the overall design can achieve this then I'll be open to considering it to be merged. However, I have to see the code to know. It could also be that what you are trying to do can be done without any mods. Robert. On 14 April 2014 19:58, Trajce Nikolov NICK trajce.nikolov.n...@gmail.com wrote: Hi Robert, I am not sure if you are familiar with this code ( I bet You are ;-) ). I have a case where I want to mix shaders with the one that are provided to this class and I need access through the interface to the osg::Program which holds these shaders and it is instantiated locally in the scope of some method - StandardShadowMap.cpp Line: 544. I would welcome something like getProgram() and expose this object to the interface. Are you friendly to such a change - it won't brake anything. Please let me know Nick -- trajce nikolov nick ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org -- trajce nikolov nick ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
[osg-users] request for small source change in StandardShadowMap
Hi Robert, I am not sure if you are familiar with this code ( I bet You are ;-) ). I have a case where I want to mix shaders with the one that are provided to this class and I need access through the interface to the osg::Program which holds these shaders and it is instantiated locally in the scope of some method - StandardShadowMap.cpp Line: 544. I would welcome something like getProgram() and expose this object to the interface. Are you friendly to such a change - it won't brake anything. Please let me know Nick -- trajce nikolov nick ___ osg-users mailing list osg-users@lists.openscenegraph.org http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org