Re: [osmosis-dev] use classworlds-Loader fort start script?
On Sat, Dec 12, 2009 at 12:06 AM, Hakan Tandogan wrote: > >> Final point to note: the paths in plexus.conf are relative to the > >> current working directory. Launching osmosis from anywhere else than > >> the root of the source directory results in a FileNotFoundException. > >> > > > > Cool, thanks for checking this out. By the way, I'm still trying to fix > > the postgis problem ... > > > > Hakan, if it has to be launched from within the right directory we'll > have > > to back the change out until we find a solution ... > > Thanks to Sarah for finding the MYAPP_HOME-problem in the Unix shell > script. > > Tonight, I'll check how other applications solve the problem with the > "right directory" problem and get back to you. > I *think* I've fixed this one. At least it appears to be working on Windows now. Let me know if you run into any issues on Linux. Brett ___ osmosis-dev mailing list osmosis-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/osmosis-dev
Re: [osmosis-dev] use classworlds-Loader fort start script?
>> Final point to note: the paths in plexus.conf are relative to the >> current working directory. Launching osmosis from anywhere else than >> the root of the source directory results in a FileNotFoundException. >> > > Cool, thanks for checking this out. By the way, I'm still trying to fix > the postgis problem ... > > Hakan, if it has to be launched from within the right directory we'll have > to back the change out until we find a solution ... Thanks to Sarah for finding the MYAPP_HOME-problem in the Unix shell script. Tonight, I'll check how other applications solve the problem with the "right directory" problem and get back to you. Regards, Hakan -- The key to immortality is first living a life worth remembering... ___ osmosis-dev mailing list osmosis-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/osmosis-dev
Re: [osmosis-dev] use classworlds-Loader fort start script?
On Fri, Dec 11, 2009 at 7:48 AM, Sarah Hoffmann wrote: > Uh, > > On Tue, 08 Dec 2009 02:04:55 +0100, Hakan Tandogan gurkensalat.com> > wrote: > > Brett Henderson wrote: > >> If it isn't too invasive it should be fine. I guess the best way is to > >> try it out and see if any problems crop up. > > > > I committed my changes to use the classworlds launcher a few hours ago. > > > > The configuration is in the file config/plexus.conf and instructs the > > launcher to load all jars from lib and lib/default ; I also modified the > > windows and unix scripts to use the classworlds launcher. > > I'm really out of luck today. That didn't work on my virgin build of > osmosis, either. > > First of all, it couldn't find the plexus-classworlds*.jar, then it was > looking for a lib/plexus.conf instead of a config/plexus.conf and, finally, > the osmosis.jar itself was missing in the plexus.conf. The attached patch > finally did the trick. > > Final point to note: the paths in plexus.conf are relative to the > current working directory. Launching osmosis from anywhere else than > the root of the source directory results in a FileNotFoundException. > Cool, thanks for checking this out. By the way, I'm still trying to fix the postgis problem ... Hakan, if it has to be launched from within the right directory we'll have to back the change out until we find a solution ... Brett ___ osmosis-dev mailing list osmosis-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/osmosis-dev
Re: [osmosis-dev] use classworlds-Loader fort start script?
Uh, On Tue, 08 Dec 2009 02:04:55 +0100, Hakan Tandogan wrote: > Brett Henderson wrote: >> If it isn't too invasive it should be fine. I guess the best way is to >> try it out and see if any problems crop up. > > I committed my changes to use the classworlds launcher a few hours ago. > > The configuration is in the file config/plexus.conf and instructs the > launcher to load all jars from lib and lib/default ; I also modified the > windows and unix scripts to use the classworlds launcher. I'm really out of luck today. That didn't work on my virgin build of osmosis, either. First of all, it couldn't find the plexus-classworlds*.jar, then it was looking for a lib/plexus.conf instead of a config/plexus.conf and, finally, the osmosis.jar itself was missing in the plexus.conf. The attached patch finally did the trick. Final point to note: the paths in plexus.conf are relative to the current working directory. Launching osmosis from anywhere else than the root of the source directory results in a FileNotFoundException. Sarah Index: config/plexus.conf === --- config/plexus.conf (revision 19027) +++ config/plexus.conf (working copy) @@ -3,3 +3,4 @@ [osmosis.core] load lib/*.jar load lib/default/*.jar +load osmosis.jar Index: ivy.xml === --- ivy.xml (revision 19027) +++ ivy.xml (working copy) @@ -19,6 +19,7 @@ + Index: bin/osmosis === --- bin/osmosis (revision 19027) +++ bin/osmosis (working copy) @@ -89,6 +89,6 @@ MYAPP_CLASSPATH=$MYAPP_HOME/lib/default/plexus-classworlds-*.jar MAINCLASS=org.codehaus.classworlds.Launcher -EXEC="$JAVACMD $JAVACMD_OPTIONS -cp $MYAPP_CLASSPATH -Dclassworlds.conf=$MYAPP_HOME/lib/plexus.conf $MAINCLASS $OSMOSIS_OPTIONS $@" +EXEC="$JAVACMD $JAVACMD_OPTIONS -cp $MYAPP_CLASSPATH -Dclassworlds.conf=$MYAPP_HOME/config/plexus.conf $MAINCLASS $OSMOSIS_OPTIONS $@" exec $EXEC ___ osmosis-dev mailing list osmosis-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/osmosis-dev
Re: [osmosis-dev] use classworlds-Loader fort start script?
On Tue, Dec 8, 2009 at 11:28 PM, Brett Henderson wrote: > On Tue, Dec 8, 2009 at 7:39 PM, wrote: > >> On Tue, 08 Dec 2009 02:04:55 +0100, Hakan Tandogan > > >> wrote: >> > Brett Henderson wrote: >> >> If it isn't too invasive it should be fine. I guess the best way is to >> >> try it out and see if any problems crop up. >> > >> > I committed my changes to use the classworlds launcher a few hours ago. >> > >> > The configuration is in the file config/plexus.conf and instructs the >> > launcher to load all jars from lib and lib/default ; I also modified the >> > windows and unix scripts to use the classworlds launcher. >> >> >> Is this just in SVN or a part of 0.32? >> > > It's just SVN for now. Once the tag transform patch is in (I haven't had > time to check it in tonight, and need to fix the bzip2 ivy problem first), > this classworlds launcher doesn't cause any complaints, and I get around to > documenting all the new tasks on the wiki then a new 0.33 release could be > made. > Sorry, I mean TagFilter not TagTransform ... Brett ___ osmosis-dev mailing list osmosis-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/osmosis-dev
Re: [osmosis-dev] use classworlds-Loader fort start script?
On Tue, Dec 8, 2009 at 7:39 PM, wrote: > On Tue, 08 Dec 2009 02:04:55 +0100, Hakan Tandogan > wrote: > > Brett Henderson wrote: > >> If it isn't too invasive it should be fine. I guess the best way is to > >> try it out and see if any problems crop up. > > > > I committed my changes to use the classworlds launcher a few hours ago. > > > > The configuration is in the file config/plexus.conf and instructs the > > launcher to load all jars from lib and lib/default ; I also modified the > > windows and unix scripts to use the classworlds launcher. > > > Is this just in SVN or a part of 0.32? > It's just SVN for now. Once the tag transform patch is in (I haven't had time to check it in tonight, and need to fix the bzip2 ivy problem first), this classworlds launcher doesn't cause any complaints, and I get around to documenting all the new tasks on the wiki then a new 0.33 release could be made. Brett ___ osmosis-dev mailing list osmosis-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/osmosis-dev
Re: [osmosis-dev] use classworlds-Loader fort start script?
On Tue, 08 Dec 2009 02:04:55 +0100, Hakan Tandogan wrote: > Brett Henderson wrote: >> If it isn't too invasive it should be fine. I guess the best way is to >> try it out and see if any problems crop up. > > I committed my changes to use the classworlds launcher a few hours ago. > > The configuration is in the file config/plexus.conf and instructs the > launcher to load all jars from lib and lib/default ; I also modified the > windows and unix scripts to use the classworlds launcher. Is this just in SVN or a part of 0.32? Marcus ___ osmosis-dev mailing list osmosis-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/osmosis-dev
Re: [osmosis-dev] use classworlds-Loader fort start script?
Brett Henderson wrote: > If it isn't too invasive it should be fine. I guess the best way is to > try it out and see if any problems crop up. I committed my changes to use the classworlds launcher a few hours ago. The configuration is in the file config/plexus.conf and instructs the launcher to load all jars from lib and lib/default ; I also modified the windows and unix scripts to use the classworlds launcher. The CommandLineTest unit tests are green, but I'd love if someone else tests the scripts, too. I might be too blind to notice problems :-) > Um, I don't tend to use the options file myself because I don't need it > ... It's typically used to adjust default VM memory size or register a > plugin class, neither of which I need. > > Does anybody else have an options file handy? I guess we'll need one > for Windows and Linux. > > We don't *have* to maintain compatibility with the existing option files > although it would be preferable. The main thing is to make sure they're > still easy to use. Regards, Hakan ___ osmosis-dev mailing list osmosis-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/osmosis-dev
Re: [osmosis-dev] use classworlds-Loader fort start script?
Sounds awesome. I assume no code changes are required? One thing to check is whether it will still allow osmosis options to be loaded from the existing config files. On 12/4/09, Hakan Tandogan wrote: > Hi, > > > At the moment, we use an explicit list of all JARs in the start script(s). > > I'd like to use the classworlds launcher like maven does. Basically, you > have a config file that tells the launcher to load all jars from a given > directory (e.g. "lib/default") without needing to write down every jar > file name. > > This way, if you upgrade the version of some dependency, the launcher > still works instead of failing mysteriously. > > Is anyone opposed to this? If not, I would commit my changes to the trunk. > > > Regards, > Hakan > > > -- > The key to immortality is first living a life worth remembering... > > > > ___ > osmosis-dev mailing list > osmosis-dev@openstreetmap.org > http://lists.openstreetmap.org/listinfo/osmosis-dev > ___ osmosis-dev mailing list osmosis-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/osmosis-dev
[osmosis-dev] use classworlds-Loader fort start script?
Hi, At the moment, we use an explicit list of all JARs in the start script(s). I'd like to use the classworlds launcher like maven does. Basically, you have a config file that tells the launcher to load all jars from a given directory (e.g. "lib/default") without needing to write down every jar file name. This way, if you upgrade the version of some dependency, the launcher still works instead of failing mysteriously. Is anyone opposed to this? If not, I would commit my changes to the trunk. Regards, Hakan -- The key to immortality is first living a life worth remembering... ___ osmosis-dev mailing list osmosis-dev@openstreetmap.org http://lists.openstreetmap.org/listinfo/osmosis-dev
