from:"Igor Zhukov"

Re: [ovs-dev] [PATCH ovn] docs: Typo. Remove duplicated "to".

2024-05-09 Thread Igor Zhukov

Great!

Thank you for the fast review!

Could you also look at https://github.com/ovn-org/ovn-website/pull/81 ?

> On Wed, May 8, 2024 at 1:38 PM Igor Zhukov  wrote:
> 
>> I came across a new patch recently: 
>> https://patchwork.ozlabs.org/project/ovn/patch/20240423095006.24429-1-martin.kal...@canonical.com/
>> After that, I searched the OVN source code for instances of "to to" and 
>> discovered two more occurrences of the same typo.
> 
> Thanks. Applied to main.
> 
> Numan
> 
>> Signed-off-by: Igor Zhukov 
>> ---
>> MAINTAINERS.rst | 2 +-
>> controller/if-status.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst
>> index 624aebb9d..f72c8b5ed 100644
>> --- a/MAINTAINERS.rst
>> +++ b/MAINTAINERS.rst
>> @@ -26,7 +26,7 @@ Committers
>> ==
>>
>> OVN committers are the people who have been granted access to push
>> -changes to to the OVN git repository.
>> +changes to the OVN git repository.
>>
>> The responsibilities of an OVN committer are documented here:
>> |responsibilities|.
>> diff --git a/controller/if-status.c b/controller/if-status.c
>> index 6e8aa1f7e..9a7488057 100644
>> --- a/controller/if-status.c
>> +++ b/controller/if-status.c
>> @@ -582,7 +582,7 @@ if_status_mgr_update(struct if_status_mgr *mgr,
>> if (!sb_readonly) {
>> HMAPX_FOR_EACH_SAFE (node, &mgr->ifaces_per_state[OIF_CLAIMED]) {
>> struct ovs_iface *iface = node->data;
>> - /* No need to to update pb->chassis as already done
>> + /* No need to update pb->chassis as already done
>> * in if_status_handle_claims or if_status_mgr_claim_iface
>> */
>> if (iface->is_vif) {
>> --
>> 2.43.0.windows.1
>> ___
>> dev mailing list
>> d...@openvswitch.org
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn] docs: Typo. Remove duplicated "to".

2024-05-08 Thread Igor Zhukov

I came across a new patch recently: 
https://patchwork.ozlabs.org/project/ovn/patch/20240423095006.24429-1-martin.kal...@canonical.com/
After that, I searched the OVN source code for instances of "to to" and 
discovered two more occurrences of the same typo.

Signed-off-by: Igor Zhukov 
---
 MAINTAINERS.rst| 2 +-
 controller/if-status.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst
index 624aebb9d..f72c8b5ed 100644
--- a/MAINTAINERS.rst
+++ b/MAINTAINERS.rst
@@ -26,7 +26,7 @@ Committers
 ==
 
 OVN committers are the people who have been granted access to push
-changes to to the OVN git repository.
+changes to the OVN git repository.
 
 The responsibilities of an OVN committer are documented here:
 |responsibilities|.
diff --git a/controller/if-status.c b/controller/if-status.c
index 6e8aa1f7e..9a7488057 100644
--- a/controller/if-status.c
+++ b/controller/if-status.c
@@ -582,7 +582,7 @@ if_status_mgr_update(struct if_status_mgr *mgr,
 if (!sb_readonly) {
 HMAPX_FOR_EACH_SAFE (node, &mgr->ifaces_per_state[OIF_CLAIMED]) {
 struct ovs_iface *iface = node->data;
-/* No need to to update pb->chassis as already done
+/* No need to update pb->chassis as already done
  * in if_status_handle_claims or if_status_mgr_claim_iface
  */
 if (iface->is_vif) {
-- 
2.43.0.windows.1
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn] Documentation: change link from ovs to ovn in the "Submitted-at" example.

2024-05-08 Thread Igor Zhukov

It's a mega nitpick, but I observed that the example URL in the "Submitted-at" 
points to the OVS repository instead of OVN.

Signed-off-by: Igor Zhukov 
---
 Documentation/internals/contributing/submitting-patches.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/internals/contributing/submitting-patches.rst 
b/Documentation/internals/contributing/submitting-patches.rst
index aef8bcd70..c82e49124 100644
--- a/Documentation/internals/contributing/submitting-patches.rst
+++ b/Documentation/internals/contributing/submitting-patches.rst
@@ -278,7 +278,7 @@ Examples of common tags follow.
 
   ::
 
-  Submitted-at: https://github.com/openvswitch/ovs/pull/92
+  Submitted-at: https://github.com/ovn-org/ovn/pull/138
 
 ``VMware-BZ: #1234567``
 
-- 
2.43.0.windows.1
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] Add dh-python to debian/control.

2024-04-25 Thread Igor Zhukov

You're welcome.

> On Fri, Apr 12, 2024 at 7:49 AM Dumitru Ceara  wrote:
> 
>> On 4/11/24 17:28, Igor Zhukov wrote:
>>> I tried to build OVN in a fresh Ubuntu 24.04 Docker container.
>>>
>>> I only installed the Build-Depends.
>>>
>>> I ran:
>>>
>>> $ dpkg-buildpackage -us -uc -ui -b
>>>
>>> And I received the following output:
>>>
>>> dpkg-buildpackage: info: source package ovn
>>> dpkg-buildpackage: info: source version 24.03.90-1
>>> dpkg-buildpackage: info: source distribution unstable
>>> dpkg-buildpackage: info: source changed by OVN team 
>>> dpkg-source --before-build .
>>> dpkg-buildpackage: info: host architecture amd64
>>> debian/rules clean
>>> dh clean --with autoreconf,python3 --parallel
>>> dh: warning: Compatibility levels before 10 are deprecated (level 9 in use)
>>> dh: error: unable to load addon python3: Can't locate 
>>> Debian/Debhelper/Sequence/python3.pm in @INC (you may need to install the 
>>> Debian::Debhelper::Sequence::python3 module) (@INC entries checked: 
>>> /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.38.2 
>>> /usr/local/share/perl/5.38.2 /usr/lib/x86_64-linux-gnu/perl5/5.38 
>>> /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base 
>>> /usr/lib/x86_64-linux-gnu/perl/5.38 /usr/share/perl/5.38 
>>> /usr/local/lib/site_perl) at (eval 12) line 1.
>>> BEGIN failed--compilation aborted at (eval 12) line 1.
>>>
>>> make: *** [debian/rules:25: clean] Error 255
>>> dpkg-buildpackage: error: debian/rules clean subprocess returned exit 
>>> status 2
>>> debuild: fatal error at line 1184:
>>> dpkg-buildpackage -us -uc -ui -b failed
>>>
>>>
>>> After researching a solution, I discovered that we need to add dh-python to 
>>> the Build-Depends in debian/control.
>>>
>>> Signed-off-by: Igor Zhukov 
>>> ---
>>
>> Hi Igor,
>>
>> Thanks for the patch!
>>
>> Frode, would you have some cycles by any chance to review this?
> 
> I went ahead and applied this patch to main and branch-24.03.
> 
> Thanks
> Numan
> 
>> Thanks,
>> Dumitru
>>
>>> debian/control | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/debian/control b/debian/control
>>> index 6ee2192..d99b483 100644
>>> --- a/debian/control
>>> +++ b/debian/control
>>> @@ -9,6 +9,7 @@ Build-Depends: graphviz,
>>> bzip2,
>>> debhelper (>= 8),
>>> dh-autoreconf,
>>> + dh-python,
>>> libssl-dev,
>>> libtool,
>>> openssl,
>>> --
>>> 2.43.0
>>> ___
>>> dev mailing list
>>> d...@openvswitch.org
>>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>>>
>>
>> ___
>> dev mailing list
>> d...@openvswitch.org
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn] Add dh-python to debian/control.

2024-04-11 Thread Igor Zhukov

I tried to build OVN in a fresh Ubuntu 24.04 Docker container.

I only installed the Build-Depends.

I ran:

$ dpkg-buildpackage -us -uc -ui -b

And I received the following output:

dpkg-buildpackage: info: source package ovn
dpkg-buildpackage: info: source version 24.03.90-1
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by OVN team 
dpkg-source --before-build .
dpkg-buildpackage: info: host architecture amd64
debian/rules clean
dh clean --with autoreconf,python3 --parallel
dh: warning: Compatibility levels before 10 are deprecated (level 9 in use)
dh: error: unable to load addon python3: Can't locate 
Debian/Debhelper/Sequence/python3.pm in @INC (you may need to install the 
Debian::Debhelper::Sequence::python3 module) (@INC entries checked: /etc/perl 
/usr/local/lib/x86_64-linux-gnu/perl/5.38.2 /usr/local/share/perl/5.38.2 
/usr/lib/x86_64-linux-gnu/perl5/5.38 /usr/share/perl5 
/usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.38 
/usr/share/perl/5.38 /usr/local/lib/site_perl) at (eval 12) line 1.
BEGIN failed--compilation aborted at (eval 12) line 1.

make: *** [debian/rules:25: clean] Error 255
dpkg-buildpackage: error: debian/rules clean subprocess returned exit status 2
debuild: fatal error at line 1184:
dpkg-buildpackage -us -uc -ui -b failed


After researching a solution, I discovered that we need to add dh-python to the 
Build-Depends in debian/control.

Signed-off-by: Igor Zhukov 
---
 debian/control | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/control b/debian/control
index 6ee2192..d99b483 100644
--- a/debian/control
+++ b/debian/control
@@ -9,6 +9,7 @@ Build-Depends: graphviz,
bzip2,
debhelper (>= 8),
dh-autoreconf,
+   dh-python,
libssl-dev,
libtool,
openssl,
--
2.43.0
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] Fix broken link for LTS release.

2024-03-20 Thread Igor Zhukov

Great! You're welcome!
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn] Fix broken link for LTS release.

2024-03-04 Thread Igor Zhukov

I found the broken link at 
https://docs.ovn.org/en/latest/internals/release-process.html.

I believe the correct link is https://www.ovn.org/en/releases/#long-term-support

Signed-off-by: Igor Zhukov 
---
 Documentation/internals/release-process.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/internals/release-process.rst 
b/Documentation/internals/release-process.rst
index 26d3f8d4d..988257975 100644
--- a/Documentation/internals/release-process.rst
+++ b/Documentation/internals/release-process.rst
@@ -203,5 +203,5 @@ Contact
 
 Use d...@openvswitch.org to discuss the OVN development and release process.
 
-__ https://www.ovn.org/en/releases/long_term_support/
+__ https://www.ovn.org/en/releases/#long-term-support
 __ https://www.ovn.org
-- 
2.43.0.windows.1
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn] Update copyright year to 2024.

2024-02-29 Thread Igor Zhukov

I noticed the copyright year at the bottom of 
https://docs.ovn.org/en/latest/contents.html

Signed-off-by: Igor Zhukov 
---
 Documentation/conf.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/conf.py b/Documentation/conf.py
index f8fc0125f..828e9443b 100644
--- a/Documentation/conf.py
+++ b/Documentation/conf.py
@@ -46,7 +46,7 @@ master_doc = 'contents'
 
 # General information about the project.
 project = u'Open Virtual Network (OVN)'
-copyright = u'2020-2023, The Open Virtual Network (OVN) Development Community'
+copyright = u'2020-2024, The Open Virtual Network (OVN) Development Community'
 author = u'The Open Virtual Network (OVN) Development Community'
 
 # The version info for the project you're documenting, acts as replacement for
-- 
2.43.0.windows.1
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn] Update copyright year to 2024

2024-02-29 Thread Igor Zhukov

I noticed the copyright year at the bottom of 
https://docs.ovn.org/en/latest/contents.html

Signed-off-by: Igor Zhukov 
---
 Documentation/conf.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/conf.py b/Documentation/conf.py
index f8fc0125f..828e9443b 100644
--- a/Documentation/conf.py
+++ b/Documentation/conf.py
@@ -46,7 +46,7 @@ master_doc = 'contents'
 
 # General information about the project.
 project = u'Open Virtual Network (OVN)'
-copyright = u'2020-2023, The Open Virtual Network (OVN) Development Community'
+copyright = u'2020-2024, The Open Virtual Network (OVN) Development Community'
 author = u'The Open Virtual Network (OVN) Development Community'
 
 # The version info for the project you're documenting, acts as replacement for
-- 
2.43.0.windows.1
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn v2] fix a copy-paste typo

2023-10-20 Thread Igor Zhukov

Sure, you are welcome.

> Thank you Igor,
> 
> Acked-by: Mark Michelson 
> 
> On 10/19/23 00:31, Igor Zhukov wrote:
> 
>> Although this typo does not cause a real error.
>>
>> Look at my test: https://gcc.godbolt.org/z/hdKc389vd
>>
>> Signed-off-by: Igor Zhukov 
>> ---
>> controller/ofctrl.c | 2 +-
>> northd/northd.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/controller/ofctrl.c b/controller/ofctrl.c
>> index a1676a788..63b0aa975 100644
>> --- a/controller/ofctrl.c
>> +++ b/controller/ofctrl.c
>> @@ -2202,7 +2202,7 @@ ofctrl_meter_bands_alloc(const struct sbrec_meter 
>> *sb_meter,
>> struct ovn_extend_table_info *entry,
>> struct ovs_list *msgs)
>> {
>> - struct meter_band_entry *mb = mb = xzalloc(sizeof *mb);
>> + struct meter_band_entry *mb = xzalloc(sizeof *mb);
>> mb->n_bands = sb_meter->n_bands;
>> mb->bands = xcalloc(mb->n_bands, sizeof *mb->bands);
>> for (int i = 0; i < sb_meter->n_bands; i++) {
>> diff --git a/northd/northd.c b/northd/northd.c
>> index 916068d44..f8b046d83 100644
>> --- a/northd/northd.c
>> +++ b/northd/northd.c
>> @@ -15765,7 +15765,7 @@ build_lrouter_nat_defrag_and_lb(struct ovn_datapath 
>> *od, struct hmap *lflows,
>> !lport_addresses_is_empty(&od->lb_force_snat_addrs);
>>
>> for (int i = 0; i < od->nbr->n_nat; i++) {
>> - const struct nbrec_nat *nat = nat = od->nbr->nat[i];
>> + const struct nbrec_nat *nat = od->nbr->nat[i];
>> struct eth_addr mac = eth_addr_broadcast;
>> bool is_v6, distributed_nat;
>> ovs_be32 mask;
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn v2] fix a copy-paste typo

2023-10-18 Thread Igor Zhukov

Although this typo does not cause a real error.

Look at my test: https://gcc.godbolt.org/z/hdKc389vd

Signed-off-by: Igor Zhukov 
---
 controller/ofctrl.c | 2 +-
 northd/northd.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/controller/ofctrl.c b/controller/ofctrl.c
index a1676a788..63b0aa975 100644
--- a/controller/ofctrl.c
+++ b/controller/ofctrl.c
@@ -2202,7 +2202,7 @@ ofctrl_meter_bands_alloc(const struct sbrec_meter 
*sb_meter,
  struct ovn_extend_table_info *entry,
  struct ovs_list *msgs)
 {
-struct meter_band_entry *mb = mb = xzalloc(sizeof *mb);
+struct meter_band_entry *mb = xzalloc(sizeof *mb);
 mb->n_bands = sb_meter->n_bands;
 mb->bands = xcalloc(mb->n_bands, sizeof *mb->bands);
 for (int i = 0; i < sb_meter->n_bands; i++) {
diff --git a/northd/northd.c b/northd/northd.c
index 916068d44..f8b046d83 100644
--- a/northd/northd.c
+++ b/northd/northd.c
@@ -15765,7 +15765,7 @@ build_lrouter_nat_defrag_and_lb(struct ovn_datapath 
*od, struct hmap *lflows,
 !lport_addresses_is_empty(&od->lb_force_snat_addrs);
 
 for (int i = 0; i < od->nbr->n_nat; i++) {
-const struct nbrec_nat *nat = nat = od->nbr->nat[i];
+const struct nbrec_nat *nat = od->nbr->nat[i];
 struct eth_addr mac = eth_addr_broadcast;
 bool is_v6, distributed_nat;
 ovs_be32 mask;
-- 
2.37.0.windows.1
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn] fix a copy-paste typo

2023-10-18 Thread Igor Zhukov

Although this typo does not cause a real error.

Look at my test: https://gcc.godbolt.org/z/hdKc389vd

Signed-off-by: Igor Zhukov 
---
 northd/northd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/northd/northd.c b/northd/northd.c
index 916068d44..f8b046d83 100644
--- a/northd/northd.c
+++ b/northd/northd.c
@@ -15765,7 +15765,7 @@ build_lrouter_nat_defrag_and_lb(struct ovn_datapath 
*od, struct hmap *lflows,
 !lport_addresses_is_empty(&od->lb_force_snat_addrs);
 
 for (int i = 0; i < od->nbr->n_nat; i++) {
-const struct nbrec_nat *nat = nat = od->nbr->nat[i];
+const struct nbrec_nat *nat = od->nbr->nat[i];
 struct eth_addr mac = eth_addr_broadcast;
 bool is_v6, distributed_nat;
 ovs_be32 mask;
-- 
2.37.0.windows.1
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn] Fix a link.

2023-08-12 Thread Igor Zhukov

The server returns 404 for the previous link.

Signed-off-by: Igor Zhukov 
---
 ovn-architecture.7.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml
index a2a87ec28..96294fe2b 100644
--- a/ovn-architecture.7.xml
+++ b/ovn-architecture.7.xml
@@ -1806,7 +1806,7 @@
 
   
 For more information on L3 gateway high availability, please refer to
-http://docs.ovn.org/en/latest/topics/high-availability.
+http://docs.ovn.org/en/latest/topics/high-availability.html.
   
 
   Restrictions of Distributed Gateway Ports
-- 
2.37.0.windows.1
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn branch-22.03] Revert "call ovsrcu_exit() before exit in ovn-northd and ovn-controller to make valgrind happy"

2023-06-14 Thread Igor Zhukov

Sure.

Acked-by: Igor Zhukov 
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] call ovsrcu_exit() before exit in ovn-northd and ovn-controller to make valgrind happy

2023-06-14 Thread Igor Zhukov

I agree.

Yes, we needed to check the build on version 22.03.

Sorry.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn branch-22.03] Revert "call ovsrcu_exit() before exit in ovn-northd and ovn-controller to make valgrind happy"

2023-06-14 Thread Igor Zhukov

I agree.

Yes, we needed to check the build on version 22.03.

Sorry.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] call ovsrcu_exit() before exit in ovn-northd and ovn-controller to make valgrind happy

2023-06-09 Thread Igor Zhukov

Great!

You are welcome!

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn] call ovsrcu_exit() before exit in ovn-northd and ovn-controller to make valgrind happy

2023-06-06 Thread Igor Zhukov

From: Igor Zhukov 

You can check logs by running: make check-valgrind TESTSUITEFLAGS="246"

(Actually almost every test affected but for example we need one test)

Valgrind message looks like

==65437== 304 bytes in 1 blocks are possibly lost in loss record 265 of 289
==65437==at 0x483DD99: calloc (in 
/usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==65437==by 0x40149DA: allocate_dtv (dl-tls.c:286)
==65437==by 0x40149DA: _dl_allocate_tls (dl-tls.c:532)
==65437==by 0x4BE2322: allocate_stack (allocatestack.c:622)
==65437==by 0x4BE2322: pthread_create@@GLIBC_2.2.5 (pthread_create.c:660)
==65437==by 0x283D46: ovs_thread_create (in 
/home/ivzhukov/upstream/ovn/controller/ovn-controller)
==65437==by 0x27FFB0: ovsrcu_quiesced (in 
/home/ivzhukov/upstream/ovn/controller/ovn-controller)
==65437==by 0x28000B: ovsrcu_quiesce_start (in 
/home/ivzhukov/upstream/ovn/controller/ovn-controller)
==65437==by 0x2AFE04: time_poll (in 
/home/ivzhukov/upstream/ovn/controller/ovn-controller)
==65437==by 0x2A16A2: poll_block (in 
/home/ivzhukov/upstream/ovn/controller/ovn-controller)
==65437==by 0x165019: pinctrl_handler (in 
/home/ivzhukov/upstream/ovn/controller/ovn-controller)
==65437==by 0x283BB1: ovsthread_wrapper (in 
/home/ivzhukov/upstream/ovn/controller/ovn-controller)
==65437==by 0x4BE1608: start_thread (pthread_create.c:477)
==65437==by 0x4F5F132: clone (clone.S:95)

or

==63926== 304 bytes in 1 blocks are possibly lost in loss record 128 of 130
==63926==at 0x483DD99: calloc (in 
/usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==63926==by 0x40149DA: allocate_dtv (dl-tls.c:286)
==63926==by 0x40149DA: _dl_allocate_tls (dl-tls.c:532)
==63926==by 0x4BE2322: allocate_stack (allocatestack.c:622)
==63926==by 0x4BE2322: pthread_create@@GLIBC_2.2.5 (pthread_create.c:660)
==63926==by 0x24EE4B: ovs_thread_create (in 
/home/ivzhukov/upstream/ovn/northd/ovn-northd)
==63926==by 0x24CB63: ovsrcu_quiesced (in 
/home/ivzhukov/upstream/ovn/northd/ovn-northd)
==63926==by 0x24CBBE: ovsrcu_quiesce_start (in 
/home/ivzhukov/upstream/ovn/northd/ovn-northd)
==63926==by 0x276DE6: time_poll (in 
/home/ivzhukov/upstream/ovn/northd/ovn-northd)
==63926==by 0x26BA03: poll_block (in 
/home/ivzhukov/upstream/ovn/northd/ovn-northd)
==63926==by 0x26A9FD: stopwatch_thread (in 
/home/ivzhukov/upstream/ovn/northd/ovn-northd)
==63926==by 0x24ECB6: ovsthread_wrapper (in 
/home/ivzhukov/upstream/ovn/northd/ovn-northd)
==63926==by 0x4BE1608: start_thread (pthread_create.c:477)
==63926==by 0x4F5F132: clone (clone.S:95)

I also noticed that ovs-vswitchd calls ovsrcu_exit() before exit: 
https://github.com/openvswitch/ovs/blob/0187eadfce4505d502e57c0e688b830f0a1ec728/vswitchd/ovs-vswitchd.c#L150

I also stopped a thread pool by calling run_update_worker_pool(0); because 
ovsrcu_exit(); stucks without it.

Signed-off-by: Igor Zhukov 
---
 controller/ovn-controller.c | 1 +
 northd/ovn-northd.c | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/controller/ovn-controller.c b/controller/ovn-controller.c
index 3a81a13fb..a47406979 100644
--- a/controller/ovn-controller.c
+++ b/controller/ovn-controller.c
@@ -5620,6 +5620,7 @@ loop_done:
 free(cli_system_id);
 }
 service_stop();
+ovsrcu_exit();
 
 exit(retval);
 }
diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
index 3515b68a2..de807c0a4 100644
--- a/northd/ovn-northd.c
+++ b/northd/ovn-northd.c
@@ -33,6 +33,7 @@
 #include "lib/ovn-l7.h"
 #include "lib/ovn-nb-idl.h"
 #include "lib/ovn-sb-idl.h"
+#include "lib/ovs-rcu.h"
 #include "openvswitch/poll-loop.h"
 #include "simap.h"
 #include "stopwatch.h"
@@ -1030,6 +1031,8 @@ main(int argc, char *argv[])
 ovsdb_idl_loop_destroy(&ovnnb_idl_loop);
 ovsdb_idl_loop_destroy(&ovnsb_idl_loop);
 service_stop();
+run_update_worker_pool(0);
+ovsrcu_exit();
 
 exit(res);
 }
-- 
2.25.1

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] MAINTAINERS: fix links

2023-01-05 Thread Igor Zhukov

We also can copy the content of maintainers.rst with new links instead of ` 
include:: ../../MAINTAINERS.rst `

so https://github.com/ovn-org/ovn/blob/main/MAINTAINERS.rst and 
https://github.com/ovn-org/ovn/blob/main/Documentation/internals/maintainers.rst
 will be independent.

But then we need to update the maintainers.rst changes in two places...

> On Thu, Dec 29, 2022 at 7:20 AM Igor Zhukov  wrote:
>>
>> From: Igor Zhukov 
>>
>> Found at https://docs.ovn.org/en/latest/internals/maintainers.html
>>
>> Signed-off-by: Igor Zhukov 
>>
>> ---
>> MAINTAINERS.rst | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst
>> index a4012a5cf..adb4ffca2 100644
>> --- a/MAINTAINERS.rst
>> +++ b/MAINTAINERS.rst
>> @@ -29,10 +29,10 @@ OVN committers are the people who have been granted 
>> access to push
>> changes to to the OVN git repository.
>>
>> The responsibilities of an OVN committer are documented
>> -`here `__.
>> +:doc:`committer-responsibilities`.
>>
>> The process for adding or removing committers is documented
>> -`here `__.
>> +:doc:`committer-grant-revocation`.
>>
>> This is the current list of active OVN committers:
>>
>> @@ -60,7 +60,7 @@ This is the current list of active OVN committers:
>>
>> The project also maintains a list of Emeritus Committers (or Maintainers).
>> More information about Emeritus Committers can be found
>> -`here `__.
>> +:doc:`committer-emeritus-status`.
>>
>> .. list-table:: OVS Emeritus Maintainers
>> :header-rows: 0
>> --
>> 2.34.1
>>
>> ___
>> dev mailing list
>> d...@openvswitch.org
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> 
> Hi Igor,
> 
> Thanks for fixing. However, here is a dilemma. The :doc: extension doesn't 
> work on github, so for root level documents it is not recommended to be used, 
> as mentioned at:
> 
> https://docs.ovn.org/en/latest/internals/contributing/documentation-style.html#restructuredtext-vs-sphinx
> 
> The MAINTAINERS.rst is a root level document but it is included by the 
> Documents/internals/maintainers.rst. The current format works well on github:
> 
> https://github.com/ovn-org/ovn/blob/main/MAINTAINERS.rst
> 
> So, I don't have a good solution to make both work. One idea is probably to 
> include both types of links in the document, but it would make both versions 
> look weird.
> Another idea may be, just remove the Documents/internals/maintainers.rst.
> 
> What do you think?
> 
> @Mark Michelson@Numan Siddique@Dumitru Ceara
> 
> Thanks,
> 
> Han
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] MAINTAINERS: fix links

2023-01-05 Thread Igor Zhukov

Oh, sorry. You're right. The links don't work on github.

For some reason I thought it works.

Yes, I don't know what should we do. Broken links are bad. For both github and 
https://docs.ovn.org/
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn] MAINTAINERS: fix links

2022-12-29 Thread Igor Zhukov

From: Igor Zhukov 

Found at https://docs.ovn.org/en/latest/internals/maintainers.html

Signed-off-by: Igor Zhukov 

---
 MAINTAINERS.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst
index a4012a5cf..adb4ffca2 100644
--- a/MAINTAINERS.rst
+++ b/MAINTAINERS.rst
@@ -29,10 +29,10 @@ OVN committers are the people who have been granted access 
to push
 changes to to the OVN git repository.
 
 The responsibilities of an OVN committer are documented
-`here `__.
+:doc:`committer-responsibilities`.
 
 The process for adding or removing committers is documented
-`here `__.
+:doc:`committer-grant-revocation`.
 
 This is the current list of active OVN committers:
 
@@ -60,7 +60,7 @@ This is the current list of active OVN committers:
 
 The project also maintains a list of Emeritus Committers (or Maintainers).
 More information about Emeritus Committers can be found
-`here `__.
+:doc:`committer-emeritus-status`.
 
 .. list-table:: OVS Emeritus Maintainers
:header-rows: 0
-- 
2.34.1

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn v3] Don't test python3.4, python3.5 binaries in OVN_CHECK_PYTHON3 m4 check.

2022-11-22 Thread Igor Zhukov

Great! You're welcome!
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn v3] Don't test python3.4, python3.5 binaries in OVN_CHECK_PYTHON3 m4 check.

2022-11-07 Thread Igor Zhukov

From: Igor Zhukov 

Also add python 3.11

Just a some cleanup of the commit: 
https://github.com/ovn-org/ovn/commit/6cbda808a2dc1f5beda39cbe50451f8d834d609a

Signed-off-by: Igor Zhukov 
---
 m4/ovn.m4 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/m4/ovn.m4 b/m4/ovn.m4
index bc2ac1aef..a92f4ceda 100644
--- a/m4/ovn.m4
+++ b/m4/ovn.m4
@@ -303,13 +303,13 @@ AC_DEFUN([OVN_CHECK_VALGRIND],
 dnl Checks for Python 3.6 or later.
 AC_DEFUN([OVN_CHECK_PYTHON3],
   [AC_CACHE_CHECK(
- [for Python 3 (version 3.4 or later)],
+ [for Python 3 (version 3.6 or later)],
  [ovs_cv_python3],
  [if test -n "$PYTHON3"; then
 ovs_cv_python3=$PYTHON3
   else
 ovs_cv_python3=no
-for binary in python3 python3.4 python3.5 python3.6 python3.7 
python3.8 python3.9 python 3.10; do
+for binary in python3 python3.6 python3.7 python3.8 python3.9 python 
3.10 python 3.11; do
   ovs_save_IFS=$IFS; IFS=$PATH_SEPARATOR
   for dir in $PATH; do
 IFS=$ovs_save_IFS
-- 
2.34.1

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn v2] Don't test python3.4, python3.5 binaries in OVN_CHECK_PYTHON3 m4 check.

2022-11-07 Thread Igor Zhukov

From: Igor Zhukov 

Also add python 3.11

Just a some cleanup of the commit: 
https://github.com/ovn-org/ovn/commit/6cbda808a2dc1f5beda39cbe50451f8d834d609a

Signed-off-by: Igor Zhukov 
---
 m4/ovn.m4 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/m4/ovn.m4 b/m4/ovn.m4
index bc2ac1aef..a92f4ceda 100644
--- a/m4/ovn.m4
+++ b/m4/ovn.m4
@@ -303,13 +303,13 @@ AC_DEFUN([OVN_CHECK_VALGRIND],
 dnl Checks for Python 3.6 or later.
 AC_DEFUN([OVN_CHECK_PYTHON3],
   [AC_CACHE_CHECK(
- [for Python 3 (version 3.4 or later)],
+ [for Python 3 (version 3.6 or later)],
  [ovs_cv_python3],
  [if test -n "$PYTHON3"; then
 ovs_cv_python3=$PYTHON3
   else
 ovs_cv_python3=no
- for binary in python3 python3.4 python3.5 python3.6 python3.7 python3.8 
python3.9 python 3.10; do
+ for binary in python3 python3.6 python3.7 python3.8 python3.9 python 3.10 
python 3.11; do
   ovs_save_IFS=$IFS; IFS=$PATH_SEPARATOR
   for dir in $PATH; do
 IFS=$ovs_save_IFS
-- 
2.34.1
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn 2/2] Don't test python3.4, python3.5 binaries in OVN_CHECK_PYTHON3 m4 check.

2022-11-07 Thread Igor Zhukov

From: Igor Zhukov 

Also add python 3.11

Just a some cleanup of the commit: 
https://github.com/ovn-org/ovn/commit/6cbda808a2dc1f5beda39cbe50451f8d834d609a

Signed-off-by: Igor Zhukov 
---
 m4/ovn.m4 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/m4/ovn.m4 b/m4/ovn.m4
index bc2ac1aef..a92f4ceda 100644
--- a/m4/ovn.m4
+++ b/m4/ovn.m4
@@ -303,13 +303,13 @@ AC_DEFUN([OVN_CHECK_VALGRIND],
 dnl Checks for Python 3.6 or later.
 AC_DEFUN([OVN_CHECK_PYTHON3],
   [AC_CACHE_CHECK(
- [for Python 3 (version 3.4 or later)],
+ [for Python 3 (version 3.6 or later)],
  [ovs_cv_python3],
  [if test -n "$PYTHON3"; then
 ovs_cv_python3=$PYTHON3
   else
 ovs_cv_python3=no
-for binary in python3 python3.4 python3.5 python3.6 python3.7 
python3.8 python3.9 python 3.10; do
+for binary in python3 python3.6 python3.7 python3.8 python3.9 python 
3.10 python 3.11; do
   ovs_save_IFS=$IFS; IFS=$PATH_SEPARATOR
   for dir in $PATH; do
 IFS=$ovs_save_IFS
-- 
2.34.1

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn] Don't test python3.4, python3.5 binaries in OVN_CHECK_PYTHON3 m4 check.

2022-11-07 Thread Igor Zhukov

From: Igor Zhukov 

Signed-off-by: Igor Zhukov 
---
 m4/ovn.m4 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/m4/ovn.m4 b/m4/ovn.m4
index bc2ac1aef..6667e5e4d 100644
--- a/m4/ovn.m4
+++ b/m4/ovn.m4
@@ -303,13 +303,13 @@ AC_DEFUN([OVN_CHECK_VALGRIND],
 dnl Checks for Python 3.6 or later.
 AC_DEFUN([OVN_CHECK_PYTHON3],
   [AC_CACHE_CHECK(
- [for Python 3 (version 3.4 or later)],
+ [for Python 3 (version 3.6 or later)],
  [ovs_cv_python3],
  [if test -n "$PYTHON3"; then
 ovs_cv_python3=$PYTHON3
   else
 ovs_cv_python3=no
-for binary in python3 python3.4 python3.5 python3.6 python3.7 
python3.8 python3.9 python 3.10; do
+for binary in python3 python3.6 python3.7 python3.8 python3.9 python 
3.10; do
   ovs_save_IFS=$IFS; IFS=$PATH_SEPARATOR
   for dir in $PATH; do
 IFS=$ovs_save_IFS
-- 
2.34.1
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] run CI for every commit when merging several commits, not for the latest.

2022-08-07 Thread Igor Zhukov

Great!
I see it works: https://github.com/ovn-org/ovn/commits/main 

> On Fri, Aug 5, 2022 at 1:05 AM Igor Zhukov  wrote:
> 
>> From: Igor Zhukov 
>>
>> Docs: 
>> https://docs.github.com/en/actions/using-jobs/using-concurrency#example-using-a-fallback-value
>>
>> Test: https://github.com/fsb4000/ovn/actions and https://imgur.com/a/mUBQWSO
>>
>> Signed-off-by: Igor Zhukov 
> 
> Thanks. I applied this patch to the main branch.
> 
> Numan
> 
>> ---
>> .github/workflows/ovn-kubernetes.yml | 2 +-
>> .github/workflows/test.yml | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/.github/workflows/ovn-kubernetes.yml 
>> b/.github/workflows/ovn-kubernetes.yml
>> index 03f35d7a3..32eb2350b 100644
>> --- a/.github/workflows/ovn-kubernetes.yml
>> +++ b/.github/workflows/ovn-kubernetes.yml
>> @@ -9,7 +9,7 @@ on:
>> - cron: '0 0 * * 0'
>>
>> concurrency:
>> - group: ${{ github.workflow }}-${{ github.event.pull_request.number || 
>> github.ref }}
>> + group: ${{ github.workflow }}-${{ github.event.pull_request.number || 
>> github.run_id }}
>> cancel-in-progress: true
>>
>> env:
>> diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
>> index 3b7283229..76a7ce090 100644
>> --- a/.github/workflows/test.yml
>> +++ b/.github/workflows/test.yml
>> @@ -8,7 +8,7 @@ on:
>> - cron: '0 0 * * 0'
>>
>> concurrency:
>> - group: ${{ github.workflow }}-${{ github.event.pull_request.number || 
>> github.ref }}
>> + group: ${{ github.workflow }}-${{ github.event.pull_request.number || 
>> github.run_id }}
>> cancel-in-progress: true
>>
>> jobs:
>> --
>> 2.30.2
>>
>> ___
>> dev mailing list
>> d...@openvswitch.org
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] Cancel previous runs in the PR when you push new commits

2022-08-05 Thread Igor Zhukov

Yesterday I created a patch: 
https://patchwork.ozlabs.org/project/ovn/patch/20220804145543.8294-1-fsb4...@yandex.ru/
 
I hope it solves all the problems. 
Maybe I should have written to this thread right away, because you might not see

> On 8/4/22 15:19, Igor Zhukov wrote:
> 
>> Hi. Yes, I confirm.
>> I'm sorry :(
> 
> No problem. :)
> 
>> Probably removing
>> `|| github.ref`
>> will help.
> 
> Makes sense to me to limit it to PRs. But what would be the generated
> group name for a plain push event (no PR)?
> 
> Thanks,
> Dumitru
> 
>>> Hi guys,
>>>
>>> It seems to me that this is breaking a bit the patchwork + ovsrobot
>>> workflow. For example, for a series of patches the robot will push them
>>> one by one, to trigger test runs with each individual patch.
>>>
>>> Taking a random patch series as example:
>>> https://patchwork.ozlabs.org/project/ovn/list/?series=311230
>>>
>>> Patch 4/4 failed some tests:
>>> https://mail.openvswitch.org/pipermail/ovs-build/2022-July/024055.html
>>> https://github.com/ovsrobot/ovn/runs/7509525379?check_suite_focus=true
>>>
>>> And this caused the runs for patches 1-3/4 to be cancelled:
>>> https://github.com/ovsrobot/ovn/actions/runs/2735541538
>>> https://github.com/ovsrobot/ovn/actions/runs/2735538404
>>> https://github.com/ovsrobot/ovn/actions/runs/2735531275
>>>
>>> I think it's quite useful to run tests on each individual patch of the
>>> series. It makes bisecting a failure easier.
>>>
>>> Also, it might be a personal preference, but it gives me more confidence
>>> if I see a patch series in patchwork having more green icons than red.
>>>
>>> Do you guys have any other thoughts on this matter?
>>>
>>> Thanks,
>>> Dumitru
>>>
>>> On 7/14/22 22:02, Numan Siddique wrote:
>>>
>>>> On Wed, Jul 13, 2022 at 6:53 AM Ales Musil  wrote:
>>>>
>>>>> Ok, thanks.
>>>>>
>>>>> Acked-by: Ales Musil 
>>>>
>>>> Thanks. I applied this patch to the main branch.
>>>>
>>>> Numan
>>>>
>>>>> On Wed, Jul 13, 2022 at 1:50 PM Igor Zhukov  wrote:
>>>>>
>>>>>> Yes, as far as I understand.
>>>>>> I found some github repos also use it:
>>>>>> https://github.com/TeamAmaze/AmazeFileManager/blob/release/3.7/.github/workflows/android-feature.yml#L10-L12
>>>>>>
>>>>>>> Hi Igor,
>>>>>>>
>>>>>>> IIUC this applies only to PR right? I mean there's no harm in having 
>>>>>>> that
>>>>>>>
>>>>>>> just to be sure.
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> Ales
>>>>>>>
>>>>>>> On Wed, Jul 13, 2022 at 1:25 PM Igor Zhukov  wrote:
>>>>>>>
>>>>>>>> From: Igor Zhukov 
>>>>>>>>
>>>>>>>> While implementing https://github.com/ovn-org/ovn/pull/139 I sometimes
>>>>>>
>>>>>> pushed
>>>>>>
>>>>>>>> several commits quickly and after that I noticed that previous run was
>>>>>>
>>>>>> still in
>>>>>>
>>>>>>>> progress and the most recent run was waiting in line.
>>>>>>>>
>>>>>>>> I googled some solutions and
>>>>>>>>
>>>>>>>> I found the answer: https://stackoverflow.com/a/72408109/4544798
>>>>>>>>
>>>>>>>> Github docs:
>>>>>>
>>>>>> https://docs.github.com/en/actions/using-jobs/using-concurrency
>>>>>>
>>>>>>>> Signed-off-by: Igor Zhukov 
>>>>>>>>
>>>>>>>> Submitted-at: https://github.com/ovn-org/ovn/pull/145
>>>>>>>>
>>>>>>>> ---
>>>>>>>>
>>>>>>>> .github/workflows/ovn-kubernetes.yml | 4 
>>>>>>>>
>>>>>>>> .github/workflows/test.yml | 4 
>>>>>>>>
>>>>>>>> 2 files changed, 8 insertions(+)
>>>>>>>>
>>>>>>>> diff --git a/.gi

[ovs-dev] [PATCH ovn] run CI for every commit when merging several commits, not for the latest.

2022-08-04 Thread Igor Zhukov

From: Igor Zhukov 

Docs: 
https://docs.github.com/en/actions/using-jobs/using-concurrency#example-using-a-fallback-value

Test: https://github.com/fsb4000/ovn/actions and https://imgur.com/a/mUBQWSO

Signed-off-by: Igor Zhukov 
---
 .github/workflows/ovn-kubernetes.yml | 2 +-
 .github/workflows/test.yml   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/ovn-kubernetes.yml 
b/.github/workflows/ovn-kubernetes.yml
index 03f35d7a3..32eb2350b 100644
--- a/.github/workflows/ovn-kubernetes.yml
+++ b/.github/workflows/ovn-kubernetes.yml
@@ -9,7 +9,7 @@ on:
   - cron: '0 0 * * 0'
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.event.pull_request.number || 
github.ref }}
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || 
github.run_id }}
   cancel-in-progress: true
 
 env:
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 3b7283229..76a7ce090 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -8,7 +8,7 @@ on:
 - cron: '0 0 * * 0'
 
 concurrency:
-  group: ${{ github.workflow }}-${{ github.event.pull_request.number || 
github.ref }}
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || 
github.run_id }}
   cancel-in-progress: true
 
 jobs:
-- 
2.30.2

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] Cancel previous runs in the PR when you push new commits

2022-08-04 Thread Igor Zhukov

Yes, some tests needed. I will try to test later today.

> On 8/4/22 15:19, Igor Zhukov wrote:
> 
>> Hi. Yes, I confirm.
>> I'm sorry :(
> 
> No problem. :)
> 
>> Probably removing
>> `|| github.ref`
>> will help.
> 
> Makes sense to me to limit it to PRs. But what would be the generated
> group name for a plain push event (no PR)?
> 
> Thanks,
> Dumitru
> 
>>> Hi guys,
>>>
>>> It seems to me that this is breaking a bit the patchwork + ovsrobot
>>> workflow. For example, for a series of patches the robot will push them
>>> one by one, to trigger test runs with each individual patch.
>>>
>>> Taking a random patch series as example:
>>> https://patchwork.ozlabs.org/project/ovn/list/?series=311230
>>>
>>> Patch 4/4 failed some tests:
>>> https://mail.openvswitch.org/pipermail/ovs-build/2022-July/024055.html
>>> https://github.com/ovsrobot/ovn/runs/7509525379?check_suite_focus=true
>>>
>>> And this caused the runs for patches 1-3/4 to be cancelled:
>>> https://github.com/ovsrobot/ovn/actions/runs/2735541538
>>> https://github.com/ovsrobot/ovn/actions/runs/2735538404
>>> https://github.com/ovsrobot/ovn/actions/runs/2735531275
>>>
>>> I think it's quite useful to run tests on each individual patch of the
>>> series. It makes bisecting a failure easier.
>>>
>>> Also, it might be a personal preference, but it gives me more confidence
>>> if I see a patch series in patchwork having more green icons than red.
>>>
>>> Do you guys have any other thoughts on this matter?
>>>
>>> Thanks,
>>> Dumitru
>>>
>>> On 7/14/22 22:02, Numan Siddique wrote:
>>>
>>>> On Wed, Jul 13, 2022 at 6:53 AM Ales Musil  wrote:
>>>>
>>>>> Ok, thanks.
>>>>>
>>>>> Acked-by: Ales Musil 
>>>>
>>>> Thanks. I applied this patch to the main branch.
>>>>
>>>> Numan
>>>>
>>>>> On Wed, Jul 13, 2022 at 1:50 PM Igor Zhukov  wrote:
>>>>>
>>>>>> Yes, as far as I understand.
>>>>>> I found some github repos also use it:
>>>>>> https://github.com/TeamAmaze/AmazeFileManager/blob/release/3.7/.github/workflows/android-feature.yml#L10-L12
>>>>>>
>>>>>>> Hi Igor,
>>>>>>>
>>>>>>> IIUC this applies only to PR right? I mean there's no harm in having 
>>>>>>> that
>>>>>>>
>>>>>>> just to be sure.
>>>>>>>
>>>>>>> Thanks,
>>>>>>>
>>>>>>> Ales
>>>>>>>
>>>>>>> On Wed, Jul 13, 2022 at 1:25 PM Igor Zhukov  wrote:
>>>>>>>
>>>>>>>> From: Igor Zhukov 
>>>>>>>>
>>>>>>>> While implementing https://github.com/ovn-org/ovn/pull/139 I sometimes
>>>>>>
>>>>>> pushed
>>>>>>
>>>>>>>> several commits quickly and after that I noticed that previous run was
>>>>>>
>>>>>> still in
>>>>>>
>>>>>>>> progress and the most recent run was waiting in line.
>>>>>>>>
>>>>>>>> I googled some solutions and
>>>>>>>>
>>>>>>>> I found the answer: https://stackoverflow.com/a/72408109/4544798
>>>>>>>>
>>>>>>>> Github docs:
>>>>>>
>>>>>> https://docs.github.com/en/actions/using-jobs/using-concurrency
>>>>>>
>>>>>>>> Signed-off-by: Igor Zhukov 
>>>>>>>>
>>>>>>>> Submitted-at: https://github.com/ovn-org/ovn/pull/145
>>>>>>>>
>>>>>>>> ---
>>>>>>>>
>>>>>>>> .github/workflows/ovn-kubernetes.yml | 4 
>>>>>>>>
>>>>>>>> .github/workflows/test.yml | 4 
>>>>>>>>
>>>>>>>> 2 files changed, 8 insertions(+)
>>>>>>>>
>>>>>>>> diff --git a/.github/workflows/ovn-kubernetes.yml
>>>>>>
>>>>>> b/.github/workflows/ovn-kubernetes.yml
>>>>>>
>>>>>>>> index c

Re: [ovs-dev] [PATCH ovn] Cancel previous runs in the PR when you push new commits

2022-08-04 Thread Igor Zhukov

Hi. Yes, I confirm.
I'm sorry :(

 Probably removing 
`|| github.ref`
will help.

> Hi guys,
> 
> It seems to me that this is breaking a bit the patchwork + ovsrobot
> workflow. For example, for a series of patches the robot will push them
> one by one, to trigger test runs with each individual patch.
> 
> Taking a random patch series as example:
> https://patchwork.ozlabs.org/project/ovn/list/?series=311230
> 
> Patch 4/4 failed some tests:
> https://mail.openvswitch.org/pipermail/ovs-build/2022-July/024055.html
> https://github.com/ovsrobot/ovn/runs/7509525379?check_suite_focus=true
> 
> And this caused the runs for patches 1-3/4 to be cancelled:
> https://github.com/ovsrobot/ovn/actions/runs/2735541538
> https://github.com/ovsrobot/ovn/actions/runs/2735538404
> https://github.com/ovsrobot/ovn/actions/runs/2735531275
> 
> I think it's quite useful to run tests on each individual patch of the
> series. It makes bisecting a failure easier.
> 
> Also, it might be a personal preference, but it gives me more confidence
> if I see a patch series in patchwork having more green icons than red.
> 
> Do you guys have any other thoughts on this matter?
> 
> Thanks,
> Dumitru
> 
> On 7/14/22 22:02, Numan Siddique wrote:
> 
>> On Wed, Jul 13, 2022 at 6:53 AM Ales Musil  wrote:
>>
>>> Ok, thanks.
>>>
>>> Acked-by: Ales Musil 
>>
>> Thanks. I applied this patch to the main branch.
>>
>> Numan
>>
>>> On Wed, Jul 13, 2022 at 1:50 PM Igor Zhukov  wrote:
>>>
>>>> Yes, as far as I understand.
>>>> I found some github repos also use it:
>>>> https://github.com/TeamAmaze/AmazeFileManager/blob/release/3.7/.github/workflows/android-feature.yml#L10-L12
>>>>
>>>>> Hi Igor,
>>>>>
>>>>> IIUC this applies only to PR right? I mean there's no harm in having that
>>>>>
>>>>> just to be sure.
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Ales
>>>>>
>>>>> On Wed, Jul 13, 2022 at 1:25 PM Igor Zhukov  wrote:
>>>>>
>>>>>> From: Igor Zhukov 
>>>>>>
>>>>>> While implementing https://github.com/ovn-org/ovn/pull/139 I sometimes
>>>>
>>>> pushed
>>>>
>>>>>> several commits quickly and after that I noticed that previous run was
>>>>
>>>> still in
>>>>
>>>>>> progress and the most recent run was waiting in line.
>>>>>>
>>>>>> I googled some solutions and
>>>>>>
>>>>>> I found the answer: https://stackoverflow.com/a/72408109/4544798
>>>>>>
>>>>>> Github docs:
>>>>
>>>> https://docs.github.com/en/actions/using-jobs/using-concurrency
>>>>
>>>>>> Signed-off-by: Igor Zhukov 
>>>>>>
>>>>>> Submitted-at: https://github.com/ovn-org/ovn/pull/145
>>>>>>
>>>>>> ---
>>>>>>
>>>>>> .github/workflows/ovn-kubernetes.yml | 4 
>>>>>>
>>>>>> .github/workflows/test.yml | 4 
>>>>>>
>>>>>> 2 files changed, 8 insertions(+)
>>>>>>
>>>>>> diff --git a/.github/workflows/ovn-kubernetes.yml
>>>>
>>>> b/.github/workflows/ovn-kubernetes.yml
>>>>
>>>>>> index c05bbd3f9..431e47660 100644
>>>>>>
>>>>>> --- a/.github/workflows/ovn-kubernetes.yml
>>>>>>
>>>>>> +++ b/.github/workflows/ovn-kubernetes.yml
>>>>>>
>>>>>> @@ -8,6 +8,10 @@ on:
>>>>>>
>>>>>> # Run Sunday at midnight
>>>>>>
>>>>>> - cron: '0 0 * * 0'
>>>>>>
>>>>>> +concurrency:
>>>>>>
>>>>>> + group: ${{ github.workflow }}-${{ github.event.pull_request.number ||
>>>>
>>>> github.ref }}
>>>>
>>>>>> + cancel-in-progress: true
>>>>>>
>>>>>> +
>>>>>>
>>>>>> env:
>>>>>>
>>>>>> GO_VERSION: "1.17.6"
>>>>>>
>>>>>> K8S_VERSION: v1.23.3
>>>>>>
>>>>>> diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
>>>>>>
>>>>>> index e0de7c60e..56e8ba870 100644
>>>>>>
>>>>>> --- a/.github/workflows/test.yml
>>>>>>
>>>>>> +++ b/.github/workflows/test.yml
>>>>>>
>>>>>> @@ -7,6 +7,10 @@ on:
>>>>>>
>>>>>> # Run Sunday at midnight
>>>>>>
>>>>>> - cron: '0 0 * * 0'
>>>>>>
>>>>>> +concurrency:
>>>>>>
>>>>>> + group: ${{ github.workflow }}-${{ github.event.pull_request.number ||
>>>>
>>>> github.ref }}
>>>>
>>>>>> + cancel-in-progress: true
>>>>>>
>>>>>> +
>>>>>>
>>>>>> jobs:
>>>>>>
>>>>>> build-linux:
>>>>>>
>>>>>> env:
>>>>>>
>>>>>> --
>>>>>>
>>>>>> 2.30.2
>>>>>>
>>>>>> ___
>>>>>>
>>>>>> dev mailing list
>>>>>>
>>>>>> d...@openvswitch.org
>>>>>>
>>>>>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>>>>>
>>>>> --
>>>>>
>>>>> Ales Musil
>>>>>
>>>>> Senior Software Engineer - OVN Core
>>>>>
>>>>> Red Hat EMEA
>>>>>
>>>>> amu...@redhat.com
>>>>>
>>>>> IM: amusil
>>>
>>> --
>>>
>>> Ales Musil
>>>
>>> Senior Software Engineer - OVN Core
>>>
>>> Red Hat EMEA <https://www.redhat.com>
>>>
>>> amu...@redhat.com IM: amusil
>>> <https://red.ht/sig>
>>> ___
>>> dev mailing list
>>> d...@openvswitch.org
>>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>>
>> ___
>> dev mailing list
>> d...@openvswitch.org
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] Cancel previous runs in the PR when you push new commits

2022-07-14 Thread Igor Zhukov

Great!

You are welcome!

Igor Zhukov
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn] Cancel previous runs in the PR when you push new commits

2022-07-13 Thread Igor Zhukov

Yes, as far as I understand.
I found some github repos also use it: 
https://github.com/TeamAmaze/AmazeFileManager/blob/release/3.7/.github/workflows/android-feature.yml#L10-L12

> Hi Igor,
> 
> IIUC this applies only to PR right? I mean there's no harm in having that
> 
> just to be sure.
> 
> Thanks,
> 
> Ales
> 
> On Wed, Jul 13, 2022 at 1:25 PM Igor Zhukov  wrote:
> 
>> From: Igor Zhukov 
>>
>> While implementing https://github.com/ovn-org/ovn/pull/139 I sometimes pushed
>>
>> several commits quickly and after that I noticed that previous run was still 
>> in
>>
>> progress and the most recent run was waiting in line.
>>
>> I googled some solutions and
>>
>> I found the answer: https://stackoverflow.com/a/72408109/4544798
>>
>> Github docs: https://docs.github.com/en/actions/using-jobs/using-concurrency
>>
>> Signed-off-by: Igor Zhukov 
>>
>> Submitted-at: https://github.com/ovn-org/ovn/pull/145
>>
>> ---
>>
>> .github/workflows/ovn-kubernetes.yml | 4 
>>
>> .github/workflows/test.yml | 4 
>>
>> 2 files changed, 8 insertions(+)
>>
>> diff --git a/.github/workflows/ovn-kubernetes.yml 
>> b/.github/workflows/ovn-kubernetes.yml
>>
>> index c05bbd3f9..431e47660 100644
>>
>> --- a/.github/workflows/ovn-kubernetes.yml
>>
>> +++ b/.github/workflows/ovn-kubernetes.yml
>>
>> @@ -8,6 +8,10 @@ on:
>>
>> # Run Sunday at midnight
>>
>> - cron: '0 0 * * 0'
>>
>> +concurrency:
>>
>> + group: ${{ github.workflow }}-${{ github.event.pull_request.number || 
>> github.ref }}
>>
>> + cancel-in-progress: true
>>
>> +
>>
>> env:
>>
>> GO_VERSION: "1.17.6"
>>
>> K8S_VERSION: v1.23.3
>>
>> diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
>>
>> index e0de7c60e..56e8ba870 100644
>>
>> --- a/.github/workflows/test.yml
>>
>> +++ b/.github/workflows/test.yml
>>
>> @@ -7,6 +7,10 @@ on:
>>
>> # Run Sunday at midnight
>>
>> - cron: '0 0 * * 0'
>>
>> +concurrency:
>>
>> + group: ${{ github.workflow }}-${{ github.event.pull_request.number || 
>> github.ref }}
>>
>> + cancel-in-progress: true
>>
>> +
>>
>> jobs:
>>
>> build-linux:
>>
>> env:
>>
>> --
>>
>> 2.30.2
>>
>> ___
>>
>> dev mailing list
>>
>> d...@openvswitch.org
>>
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> 
> --
> 
> Ales Musil
> 
> Senior Software Engineer - OVN Core
> 
> Red Hat EMEA
> 
> amu...@redhat.com
> 
> IM: amusil
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn] Cancel previous runs in the PR when you push new commits

2022-07-13 Thread Igor Zhukov

From: Igor Zhukov 

While implementing https://github.com/ovn-org/ovn/pull/139 I sometimes pushed 
several commits quickly and after that I noticed that previous run was still in
progress and the most recent run was waiting in line.

I googled some solutions and 
I found the answer: https://stackoverflow.com/a/72408109/4544798

Github docs: https://docs.github.com/en/actions/using-jobs/using-concurrency

Signed-off-by: Igor Zhukov 
Submitted-at: https://github.com/ovn-org/ovn/pull/145
---
 .github/workflows/ovn-kubernetes.yml | 4 
 .github/workflows/test.yml   | 4 
 2 files changed, 8 insertions(+)

diff --git a/.github/workflows/ovn-kubernetes.yml 
b/.github/workflows/ovn-kubernetes.yml
index c05bbd3f9..431e47660 100644
--- a/.github/workflows/ovn-kubernetes.yml
+++ b/.github/workflows/ovn-kubernetes.yml
@@ -8,6 +8,10 @@ on:
   # Run Sunday at midnight
   - cron: '0 0 * * 0'
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || 
github.ref }}
+  cancel-in-progress: true
+
 env:
   GO_VERSION: "1.17.6"
   K8S_VERSION: v1.23.3
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index e0de7c60e..56e8ba870 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -7,6 +7,10 @@ on:
 # Run Sunday at midnight
 - cron: '0 0 * * 0'
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || 
github.ref }}
+  cancel-in-progress: true
+
 jobs:
   build-linux:
 env:
-- 
2.30.2

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn] Build tests with asan and ubsan together to reduce CI time.

2022-07-11 Thread Igor Zhukov

From: Igor Zhukov 

Also fix typo in comments

Also fix memory leak in utilities/ovn-dbctl.c

Also add "-g" to CFLAGS to forbid autotools from adding "-g -O2" (temporary 
solution)

Signed-off-by: Igor Zhukov 
Acked-by: Dumitru Ceara 
Submitted-at: https://github.com/ovn-org/ovn/pull/139
---
 .ci/linux-build.sh | 16 +---
 .github/workflows/test.yml | 10 --
 tests/atlocal.in   |  4 ++--
 tests/automake.mk  |  3 +--
 tests/ovs-macros.at| 11 +++
 utilities/ovn-dbctl.c  |  4 
 6 files changed, 19 insertions(+), 29 deletions(-)

diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index 570ddbace..8c6d751dc 100755
--- a/.ci/linux-build.sh
+++ b/.ci/linux-build.sh
@@ -28,20 +28,14 @@ function configure_ovn()
 save_OPTS="${OPTS} $*"
 OPTS="${EXTRA_OPTS} ${save_OPTS}"
 
-# If AddressSanitizer or UdefinedBehaviorSanitizer is requested, enable it,
+# If AddressSanitizer and UndefinedBehaviorSanitizer are requested, enable 
them,
 # but only for OVN, not for OVS.  However, disable some optimizations for
 # OVS, to make sanitizer reports user friendly.
-if [ "$ASAN" ]; then
-CFLAGS="-O1 -fno-omit-frame-pointer -fno-common"
-CFLAGS_ASAN="-fsanitize=address"
-OVN_CFLAGS="${OVN_CFLAGS} ${CFLAGS_ASAN}"
-fi
-
-if [ "$UBSAN" ]; then
+if [ "$SANITIZERS" ]; then
 # Use the default options configured in tests/atlocal.in, in UBSAN_OPTIONS.
-CFLAGS="-O1 -fno-omit-frame-pointer -fno-common"
-CFLAGS_UBSAN="-fsanitize=undefined"
-OVN_CFLAGS="${OVN_CFLAGS} ${CFLAGS_UBSAN}"
+CFLAGS="-O1 -fno-omit-frame-pointer -fno-common -g"
+CFLAGS_SANITIZERS="-fsanitize=address,undefined"
+OVN_CFLAGS="${OVN_CFLAGS} ${CFLAGS_SANITIZERS}"
 fi
 
 if [ "$CC" = "clang" ]; then
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index b24bc7a3b..e0de7c60e 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -20,8 +20,8 @@ jobs:
   M32: ${{ matrix.m32 }}
   OPTS:${{ matrix.opts }}
   TESTSUITE:   ${{ matrix.testsuite }}
-  ASAN:${{ matrix.asan }}
-  UBSAN:   ${{ matrix.ubsan }}
+  SANITIZERS:  ${{ matrix.sanitizers }}
+  CFLAGS:  ${{ matrix.cflags }}
 
 name: linux ${{ join(matrix.*, ' ') }}
 runs-on: ubuntu-20.04
@@ -41,10 +41,8 @@ jobs:
 testsuite:system-test
   - compiler: clang
 testsuite:test
-asan: asan
-  - compiler: clang
-testsuite:test
-ubsan:ubsan
+sanitizers:   sanitizers
+cflags:   -g
 
   - compiler: gcc
 testsuite:test
diff --git a/tests/atlocal.in b/tests/atlocal.in
index b3a011f41..0b9a31276 100644
--- a/tests/atlocal.in
+++ b/tests/atlocal.in
@@ -211,10 +211,10 @@ export OVS_CTL_TIMEOUT
 
 # Add some default flags to make the tests run better under Address
 # Sanitizer, if it was used for the build.
-ASAN_OPTIONS=detect_leaks=1:abort_on_error=true:log_path=asan:$ASAN_OPTIONS
+ASAN_OPTIONS=detect_leaks=1:abort_on_error=true:log_path=sanitizers:$ASAN_OPTIONS
 export ASAN_OPTIONS
 
 # Add some default flags for UndefinedBehaviorSanitizer, if it was used
 # for the build.
-UBSAN_OPTIONS=print_stacktrace=1:halt_on_error=true:log_path=ubsan:$UBSAN_OPTIONS
+UBSAN_OPTIONS=print_stacktrace=1:halt_on_error=true:log_path=sanitizers:$UBSAN_OPTIONS
 export UBSAN_OPTIONS
diff --git a/tests/automake.mk b/tests/automake.mk
index 9733e8fa0..dce9c9108 100644
--- a/tests/automake.mk
+++ b/tests/automake.mk
@@ -80,8 +80,7 @@ export ovs_srcdir
 check-local:
set $(SHELL) '$(TESTSUITE)' -C tests AUTOTEST_PATH=$(AUTOTEST_PATH); \
"$$@" $(TESTSUITEFLAGS) || \
-   (test -z "$$(find $(TESTSUITE_DIR) -name 'asan.*')" && \
-test -z "$$(find $(TESTSUITE_DIR) -name 'ubsan.*')" && \
+   (test -z "$$(find $(TESTSUITE_DIR) -name 'sanitizers.*')" && \
 test X'$(RECHECK)' = Xyes && "$$@" --recheck)
 
 # Python Coverage support.
diff --git a/tests/ovs-macros.at b/tests/ovs-macros.at
index 1bb31f315..5a06fe956 100644
--- a/tests/ovs-macros.at
+++ b/tests/ovs-macros.at
@@ -224,14 +224,9 @@ m4_divert_pop([PREPARE_TESTS])
 
 OVS_START_SHELL_HELPERS
 ovs_cleanup() {
-if test "$(echo asan.*)" != 'asan.*'; then
-echo "Address Sanitizer reported errors in:" asan.*
-cat asan.*
-AT_FAIL_IF([:])
-fi
-if test "$(echo ubsan.*)" != 'ubsan.*'; then
-echo "Undefined Behavior Sanitizer reported errors in:" ubsan.*
-cat ubsan.*
+if test &quo

Re: [ovs-dev] [PATCH ovn] fix typo

2022-07-11 Thread Igor Zhukov

You're welcome!
I sent this patch via `git send-email` 
:)
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn] fix typo

2022-07-11 Thread Igor Zhukov

From: Igor Zhukov 

Signed-off-by: Igor Zhukov 
Acked-by: Dumitru Ceara 
---
 tests/system-ovn.at | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/system-ovn.at b/tests/system-ovn.at
index 1cabf1f31..4a8fdede8 100644
--- a/tests/system-ovn.at
+++ b/tests/system-ovn.at
@@ -4505,7 +4505,7 @@ ovn-sbctl list service_monitor
 OVS_WAIT_UNTIL([test 2 = `ovn-sbctl --bare --columns status find \
 service_monitor protocol=udp | sed '/^$/d' | grep offline | wc -l`])
 
-# Stop webserer in sw1-p1
+# Stop webserver in sw1-p1
 pid_file=$(cat l7_pid_file)
 NS_CHECK_EXEC([sw1-p1], [kill $(cat $pid_file)])
 
-- 
2.30.2

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn] fix typo

2022-07-08 Thread Igor Zhukov

Signed-off-by: Igor Zhukov 
Acked-by: Dumitru Ceara 
---
 tests/system-ovn.at | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/system-ovn.at b/tests/system-ovn.at
index 1cabf1f31..4a8fdede8 100644
--- a/tests/system-ovn.at
+++ b/tests/system-ovn.at
@@ -4505,7 +4505,7 @@ ovn-sbctl list service_monitor
 OVS_WAIT_UNTIL([test 2 = `ovn-sbctl --bare --columns status find \
 service_monitor protocol=udp | sed '/^$/d' | grep offline | wc -l`])
 
-# Stop webserer in sw1-p1
+# Stop webserver in sw1-p1
 pid_file=$(cat l7_pid_file)
 NS_CHECK_EXEC([sw1-p1], [kill $(cat $pid_file)])
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn] fix typo

2022-07-08 Thread Igor Zhukov

Signed-off-by: Igor Zhukov 
Acked-by: Dumitru Ceara 
---
 tests/system-ovn.at | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/system-ovn.at b/tests/system-ovn.at
index 1cabf1f31..4a8fdede8 100644
--- a/tests/system-ovn.at
+++ b/tests/system-ovn.at
@@ -4505,7 +4505,7 @@ ovn-sbctl list service_monitor
 OVS_WAIT_UNTIL([test 2 = `ovn-sbctl --bare --columns status find \
 service_monitor protocol=udp | sed '/^$/d' | grep offline | wc -l`])
 
-# Stop webserer in sw1-p1
+# Stop webserver in sw1-p1
 pid_file=$(cat l7_pid_file)
 NS_CHECK_EXEC([sw1-p1], [kill $(cat $pid_file)])
 
-- 
2.30.2

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

39 matches

Mail list logo