Re: [ovs-dev] [PATCH] Avoid update probe interval to non-zero for unix socket.
sorry :D I will update it. On Tue, Apr 18, 2017 at 10:25 AM, Russell Bryantwrote: > On Tue, Apr 18, 2017 at 1:08 PM, Han Zhou wrote: > > In commit it disables probe when not needed, but commit > > I assume you meant to update this "xxx" with a commit ID? > > > 715038b6 updates ovn-controller probe interval for OVNSB DB > > periodically according to ovn-remote-probe-interval config, and sets > > it to DEFAULT_PROBE_INTERVAL_MSEC if not configured, even if the > > connection type is unix socket which doesn't need probe. > > > > This fix avoids probe interval update if not needed (always set to 0). > > > > Signed-off-by: Han Zhou > > --- > > lib/reconnect.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/lib/reconnect.c b/lib/reconnect.c > > index 471fb7f..6b52481 100644 > > --- a/lib/reconnect.c > > +++ b/lib/reconnect.c > > @@ -16,6 +16,7 @@ > > > > #include > > #include "reconnect.h" > > +#include "stream.h" > > > > #include > > > > @@ -243,6 +244,9 @@ reconnect_set_backoff(struct reconnect *fsm, int > min_backoff, int max_backoff) > > void > > reconnect_set_probe_interval(struct reconnect *fsm, int probe_interval) > > { > > +if (!stream_or_pstream_needs_probes(fsm->name)) { > > +probe_interval = 0; > > +} > > fsm->probe_interval = probe_interval ? MAX(1000, probe_interval) : > 0; > > } > > > > -- > > 2.1.0 > > > > ___ > > dev mailing list > > d...@openvswitch.org > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > > > -- > Russell Bryant > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] Avoid update probe interval to non-zero for unix socket.
On Tue, Apr 18, 2017 at 1:08 PM, Han Zhouwrote: > In commit it disables probe when not needed, but commit I assume you meant to update this "xxx" with a commit ID? > 715038b6 updates ovn-controller probe interval for OVNSB DB > periodically according to ovn-remote-probe-interval config, and sets > it to DEFAULT_PROBE_INTERVAL_MSEC if not configured, even if the > connection type is unix socket which doesn't need probe. > > This fix avoids probe interval update if not needed (always set to 0). > > Signed-off-by: Han Zhou > --- > lib/reconnect.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/lib/reconnect.c b/lib/reconnect.c > index 471fb7f..6b52481 100644 > --- a/lib/reconnect.c > +++ b/lib/reconnect.c > @@ -16,6 +16,7 @@ > > #include > #include "reconnect.h" > +#include "stream.h" > > #include > > @@ -243,6 +244,9 @@ reconnect_set_backoff(struct reconnect *fsm, int > min_backoff, int max_backoff) > void > reconnect_set_probe_interval(struct reconnect *fsm, int probe_interval) > { > +if (!stream_or_pstream_needs_probes(fsm->name)) { > +probe_interval = 0; > +} > fsm->probe_interval = probe_interval ? MAX(1000, probe_interval) : 0; > } > > -- > 2.1.0 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH] Avoid update probe interval to non-zero for unix socket.
In commit it disables probe when not needed, but commit 715038b6 updates ovn-controller probe interval for OVNSB DB periodically according to ovn-remote-probe-interval config, and sets it to DEFAULT_PROBE_INTERVAL_MSEC if not configured, even if the connection type is unix socket which doesn't need probe. This fix avoids probe interval update if not needed (always set to 0). Signed-off-by: Han Zhou--- lib/reconnect.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/reconnect.c b/lib/reconnect.c index 471fb7f..6b52481 100644 --- a/lib/reconnect.c +++ b/lib/reconnect.c @@ -16,6 +16,7 @@ #include #include "reconnect.h" +#include "stream.h" #include @@ -243,6 +244,9 @@ reconnect_set_backoff(struct reconnect *fsm, int min_backoff, int max_backoff) void reconnect_set_probe_interval(struct reconnect *fsm, int probe_interval) { +if (!stream_or_pstream_needs_probes(fsm->name)) { +probe_interval = 0; +} fsm->probe_interval = probe_interval ? MAX(1000, probe_interval) : 0; } -- 2.1.0 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev