Re: [ovs-dev] [PATCH] Bareudp Tunnel Support
On Mon, Apr 27, 2020 at 09:02:16AM +0530, Martin Varghese wrote: > On Sat, Apr 25, 2020 at 06:40:18AM -0700, William Tu wrote: > > On Fri, Apr 24, 2020 at 02:54:00PM +0530, Martin Varghese wrote: > > > On Fri, Apr 24, 2020 at 01:06:21AM -0700, Pravin Shelar wrote: > > > > On Sun, Apr 19, 2020 at 8:11 PM Martin Varghese > > > > wrote: > > > > > > > > > > From: Martin Varghese > > > > > > > > > > UDP tunnel encapsulation module for tunnelling different protocols > > > > > like > > > > > MPLS, IP, NSH etc > > > > > > > > > > The Bareudp tunnel module provides a generic UDP L3 encapsulation > > > > > tunnelling module for tunnelling different protocols like MPLS,IP,NSH > > > > > etc. > > > > > inside a UDP tunnel. > > > > > > > > > > Signed-off-by: Martin Varghese > > > > > --- > > > > > Documentation/automake.mk | 1 + > > > > > Documentation/faq/bareudp.rst | 62 ++ > > > > > Documentation/faq/index.rst| 1 + > > > > > Documentation/faq/releases.rst | 1 + > > > > > NEWS | 3 +- > > > > > datapath/Modules.mk| 4 +- > > > > > datapath/linux/Modules.mk | 2 + > > > > > datapath/linux/compat/bareudp.c| 820 > > > > > + > > > > > datapath/linux/compat/include/linux/if_link.h | 11 + > > > > > datapath/linux/compat/include/linux/openvswitch.h | 11 + > > > > > datapath/linux/compat/include/net/bareudp.h| 59 ++ > > > > > datapath/linux/compat/include/net/ip6_tunnel.h | 9 + > > > > > datapath/linux/compat/include/net/ip_tunnels.h | 7 + > > > > > datapath/linux/compat/ip6_tunnel.c | 60 ++ > > > > > datapath/linux/compat/ip_tunnel.c | 47 ++ > > > > > datapath/vport-bareudp.c | 202 + > > > > > datapath/vport.c | 11 +- > > > > > lib/dpif-netlink-rtnl.c| 53 ++ > > > > > lib/dpif-netlink.c | 10 + > > > > > lib/netdev-vport.c | 25 +- > > > > > lib/netdev.h | 1 + > > > > > ofproto/ofproto-dpif-xlate.c | 1 + > > > > > rhel/openvswitch-kmod-fedora.spec.in | 2 +- > > > > > ...sr_share_openvswitch_scripts_ovs-kmod-manage.sh | 2 +- > > > > > tests/automake.mk | 2 +- > > > > > tests/system-layer3-tunnels.at | 47 ++ > > > > > utilities/ovs-dev.py | 1 + > > > > > 27 files changed, 1447 insertions(+), 8 deletions(-) > > > > > create mode 100644 Documentation/faq/bareudp.rst > > > > > create mode 100644 datapath/linux/compat/bareudp.c > > > > > create mode 100644 datapath/linux/compat/include/net/bareudp.h > > > > > create mode 100644 datapath/vport-bareudp.c > > > > > > > > > I do not see need to have vport-bareudp module. we can directly use > > > > bareudp dev from upstream kernel or from ovs compat module. Current > > > > vport modules are there due to legacy reasons. All new tunnel > > > > implementation should follow new design in which all tunnel devices > > > > are netdevices. > > > > > > > if flag ovs_tunnels_out_of_tree is true, the old genetlink interface is > > > used corret? > > Then it uses the kernel module under ovs/datapath/* , not the upstream > > kernel. > > In your case, it load the code from datapath/linux/compat/bareudp.c > > > > The new convention is to move the ovs_vport_ops_register to bareudp.c and > hence there > is no need of a seperate vport-bareudp module.But unlike devices from upstream > the vport type of bareudp device in compact should be OVS_VPORT_TYPE_BAREDUP > instead > of OVS_VPORT_TYPE_NETDEVICE in upstream device > > Is the above undertanding correct ? Yes. > > > How the rtnetlink interface will be used in that use .I am missing > > > something here. > > > Is there any tunnel device which does the new way with ovs-kernel tree > > > installed ? > > > > Yes, take a look at ERSPAN tunnel. > > > unlike vxlan, & geneve the ERSPAN device regiters itself with rtnl with same > name as the upstream device "ip6erspan" . Will it not create a conflict ? Yes, so only one module can be loaded. Either the upstream kernel one or the OVS compat. William ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] Bareudp Tunnel Support
On Sat, Apr 25, 2020 at 06:40:18AM -0700, William Tu wrote: > On Fri, Apr 24, 2020 at 02:54:00PM +0530, Martin Varghese wrote: > > On Fri, Apr 24, 2020 at 01:06:21AM -0700, Pravin Shelar wrote: > > > On Sun, Apr 19, 2020 at 8:11 PM Martin Varghese > > > wrote: > > > > > > > > From: Martin Varghese > > > > > > > > UDP tunnel encapsulation module for tunnelling different protocols like > > > > MPLS, IP, NSH etc > > > > > > > > The Bareudp tunnel module provides a generic UDP L3 encapsulation > > > > tunnelling module for tunnelling different protocols like MPLS,IP,NSH > > > > etc. > > > > inside a UDP tunnel. > > > > > > > > Signed-off-by: Martin Varghese > > > > --- > > > > Documentation/automake.mk | 1 + > > > > Documentation/faq/bareudp.rst | 62 ++ > > > > Documentation/faq/index.rst| 1 + > > > > Documentation/faq/releases.rst | 1 + > > > > NEWS | 3 +- > > > > datapath/Modules.mk| 4 +- > > > > datapath/linux/Modules.mk | 2 + > > > > datapath/linux/compat/bareudp.c| 820 > > > > + > > > > datapath/linux/compat/include/linux/if_link.h | 11 + > > > > datapath/linux/compat/include/linux/openvswitch.h | 11 + > > > > datapath/linux/compat/include/net/bareudp.h| 59 ++ > > > > datapath/linux/compat/include/net/ip6_tunnel.h | 9 + > > > > datapath/linux/compat/include/net/ip_tunnels.h | 7 + > > > > datapath/linux/compat/ip6_tunnel.c | 60 ++ > > > > datapath/linux/compat/ip_tunnel.c | 47 ++ > > > > datapath/vport-bareudp.c | 202 + > > > > datapath/vport.c | 11 +- > > > > lib/dpif-netlink-rtnl.c| 53 ++ > > > > lib/dpif-netlink.c | 10 + > > > > lib/netdev-vport.c | 25 +- > > > > lib/netdev.h | 1 + > > > > ofproto/ofproto-dpif-xlate.c | 1 + > > > > rhel/openvswitch-kmod-fedora.spec.in | 2 +- > > > > ...sr_share_openvswitch_scripts_ovs-kmod-manage.sh | 2 +- > > > > tests/automake.mk | 2 +- > > > > tests/system-layer3-tunnels.at | 47 ++ > > > > utilities/ovs-dev.py | 1 + > > > > 27 files changed, 1447 insertions(+), 8 deletions(-) > > > > create mode 100644 Documentation/faq/bareudp.rst > > > > create mode 100644 datapath/linux/compat/bareudp.c > > > > create mode 100644 datapath/linux/compat/include/net/bareudp.h > > > > create mode 100644 datapath/vport-bareudp.c > > > > > > > I do not see need to have vport-bareudp module. we can directly use > > > bareudp dev from upstream kernel or from ovs compat module. Current > > > vport modules are there due to legacy reasons. All new tunnel > > > implementation should follow new design in which all tunnel devices > > > are netdevices. > > > > > if flag ovs_tunnels_out_of_tree is true, the old genetlink interface is > > used corret? > Then it uses the kernel module under ovs/datapath/* , not the upstream kernel. > In your case, it load the code from datapath/linux/compat/bareudp.c > The new convention is to move the ovs_vport_ops_register to bareudp.c and hence there is no need of a seperate vport-bareudp module.But unlike devices from upstream the vport type of bareudp device in compact should be OVS_VPORT_TYPE_BAREDUP instead of OVS_VPORT_TYPE_NETDEVICE in upstream device Is the above undertanding correct ? > > How the rtnetlink interface will be used in that use .I am missing > > something here. > > Is there any tunnel device which does the new way with ovs-kernel tree > > installed ? > > Yes, take a look at ERSPAN tunnel. > unlike vxlan, & geneve the ERSPAN device regiters itself with rtnl with same name as the upstream device "ip6erspan" . Will it not create a conflict ? > > > Thanks. > > ___ > > dev mailing list > > d...@openvswitch.org > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] Bareudp Tunnel Support
On Fri, Apr 24, 2020 at 02:54:00PM +0530, Martin Varghese wrote: > On Fri, Apr 24, 2020 at 01:06:21AM -0700, Pravin Shelar wrote: > > On Sun, Apr 19, 2020 at 8:11 PM Martin Varghese > > wrote: > > > > > > From: Martin Varghese > > > > > > UDP tunnel encapsulation module for tunnelling different protocols like > > > MPLS, IP, NSH etc > > > > > > The Bareudp tunnel module provides a generic UDP L3 encapsulation > > > tunnelling module for tunnelling different protocols like MPLS,IP,NSH etc. > > > inside a UDP tunnel. > > > > > > Signed-off-by: Martin Varghese > > > --- > > > Documentation/automake.mk | 1 + > > > Documentation/faq/bareudp.rst | 62 ++ > > > Documentation/faq/index.rst| 1 + > > > Documentation/faq/releases.rst | 1 + > > > NEWS | 3 +- > > > datapath/Modules.mk| 4 +- > > > datapath/linux/Modules.mk | 2 + > > > datapath/linux/compat/bareudp.c| 820 > > > + > > > datapath/linux/compat/include/linux/if_link.h | 11 + > > > datapath/linux/compat/include/linux/openvswitch.h | 11 + > > > datapath/linux/compat/include/net/bareudp.h| 59 ++ > > > datapath/linux/compat/include/net/ip6_tunnel.h | 9 + > > > datapath/linux/compat/include/net/ip_tunnels.h | 7 + > > > datapath/linux/compat/ip6_tunnel.c | 60 ++ > > > datapath/linux/compat/ip_tunnel.c | 47 ++ > > > datapath/vport-bareudp.c | 202 + > > > datapath/vport.c | 11 +- > > > lib/dpif-netlink-rtnl.c| 53 ++ > > > lib/dpif-netlink.c | 10 + > > > lib/netdev-vport.c | 25 +- > > > lib/netdev.h | 1 + > > > ofproto/ofproto-dpif-xlate.c | 1 + > > > rhel/openvswitch-kmod-fedora.spec.in | 2 +- > > > ...sr_share_openvswitch_scripts_ovs-kmod-manage.sh | 2 +- > > > tests/automake.mk | 2 +- > > > tests/system-layer3-tunnels.at | 47 ++ > > > utilities/ovs-dev.py | 1 + > > > 27 files changed, 1447 insertions(+), 8 deletions(-) > > > create mode 100644 Documentation/faq/bareudp.rst > > > create mode 100644 datapath/linux/compat/bareudp.c > > > create mode 100644 datapath/linux/compat/include/net/bareudp.h > > > create mode 100644 datapath/vport-bareudp.c > > > > > I do not see need to have vport-bareudp module. we can directly use > > bareudp dev from upstream kernel or from ovs compat module. Current > > vport modules are there due to legacy reasons. All new tunnel > > implementation should follow new design in which all tunnel devices > > are netdevices. > > > if flag ovs_tunnels_out_of_tree is true, the old genetlink interface is used > corret? Then it uses the kernel module under ovs/datapath/* , not the upstream kernel. In your case, it load the code from datapath/linux/compat/bareudp.c > How the rtnetlink interface will be used in that use .I am missing something > here. > Is there any tunnel device which does the new way with ovs-kernel tree > installed ? Yes, take a look at ERSPAN tunnel. > > Thanks. > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] Bareudp Tunnel Support
On Fri, Apr 24, 2020 at 01:06:21AM -0700, Pravin Shelar wrote: > On Sun, Apr 19, 2020 at 8:11 PM Martin Varghese > wrote: > > > > From: Martin Varghese > > > > UDP tunnel encapsulation module for tunnelling different protocols like > > MPLS, IP, NSH etc > > > > The Bareudp tunnel module provides a generic UDP L3 encapsulation > > tunnelling module for tunnelling different protocols like MPLS,IP,NSH etc. > > inside a UDP tunnel. > > > > Signed-off-by: Martin Varghese > > --- > > Documentation/automake.mk | 1 + > > Documentation/faq/bareudp.rst | 62 ++ > > Documentation/faq/index.rst| 1 + > > Documentation/faq/releases.rst | 1 + > > NEWS | 3 +- > > datapath/Modules.mk| 4 +- > > datapath/linux/Modules.mk | 2 + > > datapath/linux/compat/bareudp.c| 820 > > + > > datapath/linux/compat/include/linux/if_link.h | 11 + > > datapath/linux/compat/include/linux/openvswitch.h | 11 + > > datapath/linux/compat/include/net/bareudp.h| 59 ++ > > datapath/linux/compat/include/net/ip6_tunnel.h | 9 + > > datapath/linux/compat/include/net/ip_tunnels.h | 7 + > > datapath/linux/compat/ip6_tunnel.c | 60 ++ > > datapath/linux/compat/ip_tunnel.c | 47 ++ > > datapath/vport-bareudp.c | 202 + > > datapath/vport.c | 11 +- > > lib/dpif-netlink-rtnl.c| 53 ++ > > lib/dpif-netlink.c | 10 + > > lib/netdev-vport.c | 25 +- > > lib/netdev.h | 1 + > > ofproto/ofproto-dpif-xlate.c | 1 + > > rhel/openvswitch-kmod-fedora.spec.in | 2 +- > > ...sr_share_openvswitch_scripts_ovs-kmod-manage.sh | 2 +- > > tests/automake.mk | 2 +- > > tests/system-layer3-tunnels.at | 47 ++ > > utilities/ovs-dev.py | 1 + > > 27 files changed, 1447 insertions(+), 8 deletions(-) > > create mode 100644 Documentation/faq/bareudp.rst > > create mode 100644 datapath/linux/compat/bareudp.c > > create mode 100644 datapath/linux/compat/include/net/bareudp.h > > create mode 100644 datapath/vport-bareudp.c > > > I do not see need to have vport-bareudp module. we can directly use > bareudp dev from upstream kernel or from ovs compat module. Current > vport modules are there due to legacy reasons. All new tunnel > implementation should follow new design in which all tunnel devices > are netdevices. > if flag ovs_tunnels_out_of_tree is true, the old genetlink interface is used corret? How the rtnetlink interface will be used in that use .I am missing something here. Is there any tunnel device which does the new way with ovs-kernel tree installed ? > Thanks. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] Bareudp Tunnel Support
On Sun, Apr 19, 2020 at 8:11 PM Martin Varghese wrote: > > From: Martin Varghese > > UDP tunnel encapsulation module for tunnelling different protocols like > MPLS, IP, NSH etc > > The Bareudp tunnel module provides a generic UDP L3 encapsulation > tunnelling module for tunnelling different protocols like MPLS,IP,NSH etc. > inside a UDP tunnel. > > Signed-off-by: Martin Varghese > --- > Documentation/automake.mk | 1 + > Documentation/faq/bareudp.rst | 62 ++ > Documentation/faq/index.rst| 1 + > Documentation/faq/releases.rst | 1 + > NEWS | 3 +- > datapath/Modules.mk| 4 +- > datapath/linux/Modules.mk | 2 + > datapath/linux/compat/bareudp.c| 820 > + > datapath/linux/compat/include/linux/if_link.h | 11 + > datapath/linux/compat/include/linux/openvswitch.h | 11 + > datapath/linux/compat/include/net/bareudp.h| 59 ++ > datapath/linux/compat/include/net/ip6_tunnel.h | 9 + > datapath/linux/compat/include/net/ip_tunnels.h | 7 + > datapath/linux/compat/ip6_tunnel.c | 60 ++ > datapath/linux/compat/ip_tunnel.c | 47 ++ > datapath/vport-bareudp.c | 202 + > datapath/vport.c | 11 +- > lib/dpif-netlink-rtnl.c| 53 ++ > lib/dpif-netlink.c | 10 + > lib/netdev-vport.c | 25 +- > lib/netdev.h | 1 + > ofproto/ofproto-dpif-xlate.c | 1 + > rhel/openvswitch-kmod-fedora.spec.in | 2 +- > ...sr_share_openvswitch_scripts_ovs-kmod-manage.sh | 2 +- > tests/automake.mk | 2 +- > tests/system-layer3-tunnels.at | 47 ++ > utilities/ovs-dev.py | 1 + > 27 files changed, 1447 insertions(+), 8 deletions(-) > create mode 100644 Documentation/faq/bareudp.rst > create mode 100644 datapath/linux/compat/bareudp.c > create mode 100644 datapath/linux/compat/include/net/bareudp.h > create mode 100644 datapath/vport-bareudp.c > I do not see need to have vport-bareudp module. we can directly use bareudp dev from upstream kernel or from ovs compat module. Current vport modules are there due to legacy reasons. All new tunnel implementation should follow new design in which all tunnel devices are netdevices. Thanks. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH] Bareudp Tunnel Support
From: Martin Varghese UDP tunnel encapsulation module for tunnelling different protocols like MPLS, IP, NSH etc The Bareudp tunnel module provides a generic UDP L3 encapsulation tunnelling module for tunnelling different protocols like MPLS,IP,NSH etc. inside a UDP tunnel. Signed-off-by: Martin Varghese --- Documentation/automake.mk | 1 + Documentation/faq/bareudp.rst | 62 ++ Documentation/faq/index.rst| 1 + Documentation/faq/releases.rst | 1 + NEWS | 3 +- datapath/Modules.mk| 4 +- datapath/linux/Modules.mk | 2 + datapath/linux/compat/bareudp.c| 820 + datapath/linux/compat/include/linux/if_link.h | 11 + datapath/linux/compat/include/linux/openvswitch.h | 11 + datapath/linux/compat/include/net/bareudp.h| 59 ++ datapath/linux/compat/include/net/ip6_tunnel.h | 9 + datapath/linux/compat/include/net/ip_tunnels.h | 7 + datapath/linux/compat/ip6_tunnel.c | 60 ++ datapath/linux/compat/ip_tunnel.c | 47 ++ datapath/vport-bareudp.c | 202 + datapath/vport.c | 11 +- lib/dpif-netlink-rtnl.c| 53 ++ lib/dpif-netlink.c | 10 + lib/netdev-vport.c | 25 +- lib/netdev.h | 1 + ofproto/ofproto-dpif-xlate.c | 1 + rhel/openvswitch-kmod-fedora.spec.in | 2 +- ...sr_share_openvswitch_scripts_ovs-kmod-manage.sh | 2 +- tests/automake.mk | 2 +- tests/system-layer3-tunnels.at | 47 ++ utilities/ovs-dev.py | 1 + 27 files changed, 1447 insertions(+), 8 deletions(-) create mode 100644 Documentation/faq/bareudp.rst create mode 100644 datapath/linux/compat/bareudp.c create mode 100644 datapath/linux/compat/include/net/bareudp.h create mode 100644 datapath/vport-bareudp.c diff --git a/Documentation/automake.mk b/Documentation/automake.mk index f85c432..ea3475f 100644 --- a/Documentation/automake.mk +++ b/Documentation/automake.mk @@ -88,6 +88,7 @@ DOC_SOURCE = \ Documentation/faq/terminology.rst \ Documentation/faq/vlan.rst \ Documentation/faq/vxlan.rst \ + Documentation/faq/bareudp.rst \ Documentation/internals/index.rst \ Documentation/internals/authors.rst \ Documentation/internals/bugs.rst \ diff --git a/Documentation/faq/bareudp.rst b/Documentation/faq/bareudp.rst new file mode 100644 index 000..7fdf05d --- /dev/null +++ b/Documentation/faq/bareudp.rst @@ -0,0 +1,62 @@ +.. + Licensed under the Apache License, Version 2.0 (the "License"); you may + not use this file except in compliance with the License. You may obtain + a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + License for the specific language governing permissions and limitations + under the License. + + Convention for heading levels in Open vSwitch documentation: + + === Heading 0 (reserved for the title in a document) + --- Heading 1 + ~~~ Heading 2 + +++ Heading 3 + ''' Heading 4 + + Avoid deeper levels because they do not render well. + +=== +Bareudp +=== + +Q: What is Bareudp? + +A: There are various L3 encapsulation standards using UDP being discussed + to leverage the UDP based load balancing capability of different + networks. MPLSoUDP (__ https://tools.ietf.org/html/rfc7510) is one among + them. + + The Bareudp tunnel provides a generic L3 encapsulation tunnelling + support for tunnelling different L3 protocols like MPLS, IP, NSH etc. + inside a UDP tunnel. + + The bareudp device supports special handling for MPLS & IP as they can + have multiple ethertypes. + MPLS procotcol can have ethertypes ETH_P_MPLS_UC (unicast) & + ETH_P_MPLS_MC (multicast). IP protocol can have ethertypes ETH_P_IP (v4) + & ETH_P_IPV6 (v6). + + An example to create bareudp device to tunnel MPLS traffic is given + below.:: + + $ ovs-vsctl add-port br_mpls udp_port -- set interface udp_port \ + type=bareudp options:remote_ip=2.1.1.3 options:local_ip=2.1.1.2 \ + options:payload_type=0x8847 options:dst_port=6635 \ + options:packet_type="legacy_l3" \ + ofport_request=$bareudp_egress_port
