Re: [ovs-dev] [PATCH] Documentation: Update DPDK doc after port naming change.
On 19/01/2017 03:12, "Loftus, Ciara"wrote: >> >> options:dpdk-devargs is always required now. This commit also changes >> some of the names from 'dpdk0' to various others. >> >> netdev-dpdk/detach accepts a PCI id instead of a port name. >> >> CC: Ciara Loftus >> Fixes: 55e075e65ef9("netdev-dpdk: Arbitrary 'dpdk' port naming") >> Signed-off-by: Daniele Di Proietto > >Patch looks good. Thanks for the fixes! > >Acked-by: Ciara Loftus Thanks! Pushed to master > >> --- >> Documentation/howto/dpdk.rst| 77 >> - >> Documentation/howto/userspace-tunneling.rst | 2 +- >> 2 files changed, 43 insertions(+), 36 deletions(-) >> >> diff --git a/Documentation/howto/dpdk.rst >> b/Documentation/howto/dpdk.rst >> index fbb4b5361..d1e6e899f 100644 >> --- a/Documentation/howto/dpdk.rst >> +++ b/Documentation/howto/dpdk.rst >> @@ -44,8 +44,10 @@ ovs-vsctl can also be used to add DPDK devices. OVS >> expects DPDK device names >> to start with ``dpdk`` and end with a portid. ovs-vswitchd should print the >> number of dpdk devices found in the log file:: >> >> -$ ovs-vsctl add-port br0 dpdk0 -- set Interface dpdk0 type=dpdk >> -$ ovs-vsctl add-port br0 dpdk1 -- set Interface dpdk1 type=dpdk >> +$ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \ >> +options:dpdk-devargs=:01:00.0 >> +$ ovs-vsctl add-port br0 dpdk-p1 -- set Interface dpdk-p1 type=dpdk \ >> +options:dpdk-devargs=:01:00.1 >> >> After the DPDK ports get added to switch, a polling thread continuously >> polls >> DPDK devices and consumes 100% of the core, as can be checked from >> ``top`` and >> @@ -55,12 +57,12 @@ DPDK devices and consumes 100% of the core, as can >> be checked from ``top`` and >> $ ps -eLo pid,psr,comm | grep pmd >> >> Creating bonds of DPDK interfaces is slightly different to creating bonds of >> -system interfaces. For DPDK, the interface type must be explicitly set. For >> -example:: >> +system interfaces. For DPDK, the interface type and devargs must be >> explicitly >> +set. For example:: >> >> -$ ovs-vsctl add-bond br0 dpdkbond dpdk0 dpdk1 \ >> --- set Interface dpdk0 type=dpdk \ >> --- set Interface dpdk1 type=dpdk >> +$ ovs-vsctl add-bond br0 dpdkbond p0 p1 \ >> +-- set Interface p0 type=dpdk options:dpdk-devargs=:01:00.0 \ >> +-- set Interface p1 type=dpdk options:dpdk-devargs=:01:00.1 >> >> To stop ovs-vswitchd & delete bridge, run:: >> >> @@ -98,7 +100,7 @@ where: >> >> For example:: >> >> -$ ovs-vsctl set interface dpdk0 options:n_rxq=4 \ >> +$ ovs-vsctl set interface dpdk-p0 options:n_rxq=4 \ >> other_config:pmd-rxq-affinity="0:3,1:7,3:8" >> >> This will ensure: >> @@ -165,27 +167,27 @@ Flow Control >> Flow control can be enabled only on DPDK physical ports. To enable flow >> control >> support at tx side while adding a port, run:: >> >> -$ ovs-vsctl add-port br0 dpdk0 -- \ >> -set Interface dpdk0 type=dpdk options:tx-flow-ctrl=true >> +$ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \ >> +options:dpdk-devargs=:01:00.0 options:tx-flow-ctrl=true >> >> Similarly, to enable rx flow control, run:: >> >> -$ ovs-vsctl add-port br0 dpdk0 -- \ >> -set Interface dpdk0 type=dpdk options:rx-flow-ctrl=true >> +$ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \ >> +options:dpdk-devargs=:01:00.0 options:rx-flow-ctrl=true >> >> To enable flow control auto-negotiation, run:: >> >> -$ ovs-vsctl add-port br0 dpdk0 -- \ >> -set Interface dpdk0 type=dpdk options:flow-ctrl-autoneg=true >> +$ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \ >> +options:dpdk-devargs=:01:00.0 options:flow-ctrl-autoneg=true >> >> To turn ON the tx flow control at run time for an existing port, run:: >> >> -$ ovs-vsctl set Interface dpdk0 options:tx-flow-ctrl=true >> +$ ovs-vsctl set Interface dpdk-p0 options:tx-flow-ctrl=true >> >> The flow control parameters can be turned off by setting ``false`` to the >> respective parameter. To disable the flow control at tx side, run:: >> >> -$ ovs-vsctl set Interface dpdk0 options:tx-flow-ctrl=false >> +$ ovs-vsctl set Interface dpdk-p0 options:tx-flow-ctrl=false >> >> pdump >> - >> @@ -234,13 +236,12 @@ enable Jumbo Frames support for a DPDK port, >> change the Interface's >> ``mtu_request`` attribute to a sufficiently large value. For example, to >> add a >> DPDK Phy port with MTU of 9000:: >> >> -$ ovs-vsctl add-port br0 dpdk0 \ >> - -- set Interface dpdk0 type=dpdk \ >> - -- set Interface dpdk0 mtu_request=9000` >> +$ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \ >> + options:dpdk-devargs=:01:00.0
Re: [ovs-dev] [PATCH] Documentation: Update DPDK doc after port naming change.
> > options:dpdk-devargs is always required now. This commit also changes > some of the names from 'dpdk0' to various others. > > netdev-dpdk/detach accepts a PCI id instead of a port name. > > CC: Ciara Loftus> Fixes: 55e075e65ef9("netdev-dpdk: Arbitrary 'dpdk' port naming") > Signed-off-by: Daniele Di Proietto Patch looks good. Thanks for the fixes! Acked-by: Ciara Loftus > --- > Documentation/howto/dpdk.rst| 77 > - > Documentation/howto/userspace-tunneling.rst | 2 +- > 2 files changed, 43 insertions(+), 36 deletions(-) > > diff --git a/Documentation/howto/dpdk.rst > b/Documentation/howto/dpdk.rst > index fbb4b5361..d1e6e899f 100644 > --- a/Documentation/howto/dpdk.rst > +++ b/Documentation/howto/dpdk.rst > @@ -44,8 +44,10 @@ ovs-vsctl can also be used to add DPDK devices. OVS > expects DPDK device names > to start with ``dpdk`` and end with a portid. ovs-vswitchd should print the > number of dpdk devices found in the log file:: > > -$ ovs-vsctl add-port br0 dpdk0 -- set Interface dpdk0 type=dpdk > -$ ovs-vsctl add-port br0 dpdk1 -- set Interface dpdk1 type=dpdk > +$ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \ > +options:dpdk-devargs=:01:00.0 > +$ ovs-vsctl add-port br0 dpdk-p1 -- set Interface dpdk-p1 type=dpdk \ > +options:dpdk-devargs=:01:00.1 > > After the DPDK ports get added to switch, a polling thread continuously polls > DPDK devices and consumes 100% of the core, as can be checked from > ``top`` and > @@ -55,12 +57,12 @@ DPDK devices and consumes 100% of the core, as can > be checked from ``top`` and > $ ps -eLo pid,psr,comm | grep pmd > > Creating bonds of DPDK interfaces is slightly different to creating bonds of > -system interfaces. For DPDK, the interface type must be explicitly set. For > -example:: > +system interfaces. For DPDK, the interface type and devargs must be > explicitly > +set. For example:: > > -$ ovs-vsctl add-bond br0 dpdkbond dpdk0 dpdk1 \ > --- set Interface dpdk0 type=dpdk \ > --- set Interface dpdk1 type=dpdk > +$ ovs-vsctl add-bond br0 dpdkbond p0 p1 \ > +-- set Interface p0 type=dpdk options:dpdk-devargs=:01:00.0 \ > +-- set Interface p1 type=dpdk options:dpdk-devargs=:01:00.1 > > To stop ovs-vswitchd & delete bridge, run:: > > @@ -98,7 +100,7 @@ where: > > For example:: > > -$ ovs-vsctl set interface dpdk0 options:n_rxq=4 \ > +$ ovs-vsctl set interface dpdk-p0 options:n_rxq=4 \ > other_config:pmd-rxq-affinity="0:3,1:7,3:8" > > This will ensure: > @@ -165,27 +167,27 @@ Flow Control > Flow control can be enabled only on DPDK physical ports. To enable flow > control > support at tx side while adding a port, run:: > > -$ ovs-vsctl add-port br0 dpdk0 -- \ > -set Interface dpdk0 type=dpdk options:tx-flow-ctrl=true > +$ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \ > +options:dpdk-devargs=:01:00.0 options:tx-flow-ctrl=true > > Similarly, to enable rx flow control, run:: > > -$ ovs-vsctl add-port br0 dpdk0 -- \ > -set Interface dpdk0 type=dpdk options:rx-flow-ctrl=true > +$ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \ > +options:dpdk-devargs=:01:00.0 options:rx-flow-ctrl=true > > To enable flow control auto-negotiation, run:: > > -$ ovs-vsctl add-port br0 dpdk0 -- \ > -set Interface dpdk0 type=dpdk options:flow-ctrl-autoneg=true > +$ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \ > +options:dpdk-devargs=:01:00.0 options:flow-ctrl-autoneg=true > > To turn ON the tx flow control at run time for an existing port, run:: > > -$ ovs-vsctl set Interface dpdk0 options:tx-flow-ctrl=true > +$ ovs-vsctl set Interface dpdk-p0 options:tx-flow-ctrl=true > > The flow control parameters can be turned off by setting ``false`` to the > respective parameter. To disable the flow control at tx side, run:: > > -$ ovs-vsctl set Interface dpdk0 options:tx-flow-ctrl=false > +$ ovs-vsctl set Interface dpdk-p0 options:tx-flow-ctrl=false > > pdump > - > @@ -234,13 +236,12 @@ enable Jumbo Frames support for a DPDK port, > change the Interface's > ``mtu_request`` attribute to a sufficiently large value. For example, to add > a > DPDK Phy port with MTU of 9000:: > > -$ ovs-vsctl add-port br0 dpdk0 \ > - -- set Interface dpdk0 type=dpdk \ > - -- set Interface dpdk0 mtu_request=9000` > +$ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \ > + options:dpdk-devargs=:01:00.0 mtu_request=9000 > > Similarly, to change the MTU of an existing port to 6200:: > > -$ ovs-vsctl set Interface dpdk0 mtu_request=6200 > +$ ovs-vsctl set Interface dpdk-p0 mtu_request=6200 > > Some additional
[ovs-dev] [PATCH] Documentation: Update DPDK doc after port naming change.
options:dpdk-devargs is always required now. This commit also changes some of the names from 'dpdk0' to various others. netdev-dpdk/detach accepts a PCI id instead of a port name. CC: Ciara LoftusFixes: 55e075e65ef9("netdev-dpdk: Arbitrary 'dpdk' port naming") Signed-off-by: Daniele Di Proietto --- Documentation/howto/dpdk.rst| 77 - Documentation/howto/userspace-tunneling.rst | 2 +- 2 files changed, 43 insertions(+), 36 deletions(-) diff --git a/Documentation/howto/dpdk.rst b/Documentation/howto/dpdk.rst index fbb4b5361..d1e6e899f 100644 --- a/Documentation/howto/dpdk.rst +++ b/Documentation/howto/dpdk.rst @@ -44,8 +44,10 @@ ovs-vsctl can also be used to add DPDK devices. OVS expects DPDK device names to start with ``dpdk`` and end with a portid. ovs-vswitchd should print the number of dpdk devices found in the log file:: -$ ovs-vsctl add-port br0 dpdk0 -- set Interface dpdk0 type=dpdk -$ ovs-vsctl add-port br0 dpdk1 -- set Interface dpdk1 type=dpdk +$ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \ +options:dpdk-devargs=:01:00.0 +$ ovs-vsctl add-port br0 dpdk-p1 -- set Interface dpdk-p1 type=dpdk \ +options:dpdk-devargs=:01:00.1 After the DPDK ports get added to switch, a polling thread continuously polls DPDK devices and consumes 100% of the core, as can be checked from ``top`` and @@ -55,12 +57,12 @@ DPDK devices and consumes 100% of the core, as can be checked from ``top`` and $ ps -eLo pid,psr,comm | grep pmd Creating bonds of DPDK interfaces is slightly different to creating bonds of -system interfaces. For DPDK, the interface type must be explicitly set. For -example:: +system interfaces. For DPDK, the interface type and devargs must be explicitly +set. For example:: -$ ovs-vsctl add-bond br0 dpdkbond dpdk0 dpdk1 \ --- set Interface dpdk0 type=dpdk \ --- set Interface dpdk1 type=dpdk +$ ovs-vsctl add-bond br0 dpdkbond p0 p1 \ +-- set Interface p0 type=dpdk options:dpdk-devargs=:01:00.0 \ +-- set Interface p1 type=dpdk options:dpdk-devargs=:01:00.1 To stop ovs-vswitchd & delete bridge, run:: @@ -98,7 +100,7 @@ where: For example:: -$ ovs-vsctl set interface dpdk0 options:n_rxq=4 \ +$ ovs-vsctl set interface dpdk-p0 options:n_rxq=4 \ other_config:pmd-rxq-affinity="0:3,1:7,3:8" This will ensure: @@ -165,27 +167,27 @@ Flow Control Flow control can be enabled only on DPDK physical ports. To enable flow control support at tx side while adding a port, run:: -$ ovs-vsctl add-port br0 dpdk0 -- \ -set Interface dpdk0 type=dpdk options:tx-flow-ctrl=true +$ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \ +options:dpdk-devargs=:01:00.0 options:tx-flow-ctrl=true Similarly, to enable rx flow control, run:: -$ ovs-vsctl add-port br0 dpdk0 -- \ -set Interface dpdk0 type=dpdk options:rx-flow-ctrl=true +$ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \ +options:dpdk-devargs=:01:00.0 options:rx-flow-ctrl=true To enable flow control auto-negotiation, run:: -$ ovs-vsctl add-port br0 dpdk0 -- \ -set Interface dpdk0 type=dpdk options:flow-ctrl-autoneg=true +$ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \ +options:dpdk-devargs=:01:00.0 options:flow-ctrl-autoneg=true To turn ON the tx flow control at run time for an existing port, run:: -$ ovs-vsctl set Interface dpdk0 options:tx-flow-ctrl=true +$ ovs-vsctl set Interface dpdk-p0 options:tx-flow-ctrl=true The flow control parameters can be turned off by setting ``false`` to the respective parameter. To disable the flow control at tx side, run:: -$ ovs-vsctl set Interface dpdk0 options:tx-flow-ctrl=false +$ ovs-vsctl set Interface dpdk-p0 options:tx-flow-ctrl=false pdump - @@ -234,13 +236,12 @@ enable Jumbo Frames support for a DPDK port, change the Interface's ``mtu_request`` attribute to a sufficiently large value. For example, to add a DPDK Phy port with MTU of 9000:: -$ ovs-vsctl add-port br0 dpdk0 \ - -- set Interface dpdk0 type=dpdk \ - -- set Interface dpdk0 mtu_request=9000` +$ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \ + options:dpdk-devargs=:01:00.0 mtu_request=9000 Similarly, to change the MTU of an existing port to 6200:: -$ ovs-vsctl set Interface dpdk0 mtu_request=6200 +$ ovs-vsctl set Interface dpdk-p0 mtu_request=6200 Some additional configuration is needed to take advantage of jumbo frames with vHost ports: @@ -280,14 +281,14 @@ By default, DPDK physical ports are enabled with Rx checksum offload. Rx checksum offload can be configured on a DPDK physical port either when adding or at run time. -To disable Rx checksum offload when