Re: [ovs-dev] [PATCH] appveyor: Fix caching of OpenSSL installer.

[Ilya Maximets]

On 6/11/24 00:09, Alin Serdean wrote:
> Acked-by: Alin-Gabriel Serdean 

Thanks!  Applied.

Best regards, Ilya Maximets.

> 
> On Mon, Jun 10, 2024 at 11:18 PM Ilya Maximets  > wrote:
> 
> Apparently, if the cache dependency is specified, the cache folder
> is not checked at the end of a build and so the cache is never
> updated unless we change appveyor.yml.  This makes the cache to not
> actually work, because on each build we discover that the installer
> is outdated, download the new one and it is not uploaded to the cache,
> so it is still outdated on the next build.
> 
> Removing the dependency to get a normal cache behavior.  We're
> manually comparing the hash of the cached binary with the most
> latest one, so we will still catch any OpenSSL updates, but now
> we will also upload the updated cache back.
> 
> Fixes: 9d8208484a35 ("appveyor: Build with OpenSSL 3.0.")
> Reported-at: 
> https://help.appveyor.com/discussions/problems/36144-cache-reports-up-to-date-while-it-is-not
> Signed-off-by: Ilya Maximets 
> ---
>  appveyor.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/appveyor.yml b/appveyor.yml
> index d11e46399..d0293b211 100644
> --- a/appveyor.yml
> +++ b/appveyor.yml
> @@ -15,7 +15,7 @@ init:
>                                -Value "C:\Python312-x64\python.exe"
> 
>  cache:
> -- C:\ovs-build-downloads -> appveyor.yml
> +- C:\ovs-build-downloads
> 
>  install:
>  - ps: |
> -- 
> 2.45.0
> 
> ___
> dev mailing list
> d...@openvswitch.org 
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev 
> 
> 

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] appveyor: Fix caching of OpenSSL installer.

[Alin Serdean]

Acked-by: Alin-Gabriel Serdean 

On Mon, Jun 10, 2024 at 11:18 PM Ilya Maximets  wrote:

> Apparently, if the cache dependency is specified, the cache folder
> is not checked at the end of a build and so the cache is never
> updated unless we change appveyor.yml.  This makes the cache to not
> actually work, because on each build we discover that the installer
> is outdated, download the new one and it is not uploaded to the cache,
> so it is still outdated on the next build.
>
> Removing the dependency to get a normal cache behavior.  We're
> manually comparing the hash of the cached binary with the most
> latest one, so we will still catch any OpenSSL updates, but now
> we will also upload the updated cache back.
>
> Fixes: 9d8208484a35 ("appveyor: Build with OpenSSL 3.0.")
> Reported-at:
> https://help.appveyor.com/discussions/problems/36144-cache-reports-up-to-date-while-it-is-not
> Signed-off-by
> :
> Ilya Maximets 
> ---
>  appveyor.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/appveyor.yml b/appveyor.yml
> index d11e46399..d0293b211 100644
> --- a/appveyor.yml
> +++ b/appveyor.yml
> @@ -15,7 +15,7 @@ init:
>-Value "C:\Python312-x64\python.exe"
>
>  cache:
> -- C:\ovs-build-downloads -> appveyor.yml
> +- C:\ovs-build-downloads
>
>  install:
>  - ps: |
> --
> 2.45.0
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] appveyor: Fix caching of OpenSSL installer.

[Ilya Maximets]

Apparently, if the cache dependency is specified, the cache folder
is not checked at the end of a build and so the cache is never
updated unless we change appveyor.yml.  This makes the cache to not
actually work, because on each build we discover that the installer
is outdated, download the new one and it is not uploaded to the cache,
so it is still outdated on the next build.

Removing the dependency to get a normal cache behavior.  We're
manually comparing the hash of the cached binary with the most
latest one, so we will still catch any OpenSSL updates, but now
we will also upload the updated cache back.

Fixes: 9d8208484a35 ("appveyor: Build with OpenSSL 3.0.")
Reported-at: 
https://help.appveyor.com/discussions/problems/36144-cache-reports-up-to-date-while-it-is-not
Signed-off-by: Ilya Maximets 
---
 appveyor.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/appveyor.yml b/appveyor.yml
index d11e46399..d0293b211 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -15,7 +15,7 @@ init:
   -Value "C:\Python312-x64\python.exe"
 
 cache:
-- C:\ovs-build-downloads -> appveyor.yml
+- C:\ovs-build-downloads
 
 install:
 - ps: |
-- 
2.45.0

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev