Re: [ovs-dev] [PATCH] dpif-netdev: Add thread safety annotation to sorted_poll_list.

2019-02-12 Thread Ian Stokes 

On 2/11/2019 6:32 PM, Kevin Traynor wrote:

On 02/11/2019 05:35 PM, Ilya Maximets wrote:

'sorted_poll_list()' uses the 'pmd->poll_list' that should be
guarded by 'pmd->port_mutex'.

Signed-off-by: Ilya Maximets 
---


LGTM

Acked-by: Kevin Traynor 



Thanks, applied to master and backported back to OVS 2.7.

Ian
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] dpif-netdev: Add thread safety annotation to sorted_poll_list.

2019-02-11 Thread Kevin Traynor 
On 02/11/2019 05:35 PM, Ilya Maximets wrote:
> 'sorted_poll_list()' uses the 'pmd->poll_list' that should be
> guarded by 'pmd->port_mutex'.
> 
> Signed-off-by: Ilya Maximets 
> ---

LGTM

Acked-by: Kevin Traynor 

>  lib/dpif-netdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
> index 914b2bb8b..34f2d2b07 100644
> --- a/lib/dpif-netdev.c
> +++ b/lib/dpif-netdev.c
> @@ -1109,6 +1109,7 @@ compare_poll_list(const void *a_, const void *b_)
>  static void
>  sorted_poll_list(struct dp_netdev_pmd_thread *pmd, struct rxq_poll **list,
>   size_t *n)
> +OVS_REQUIRES(pmd->port_mutex)
>  {
>  struct rxq_poll *ret, *poll;
>  size_t i;
> 

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] dpif-netdev: Add thread safety annotation to sorted_poll_list.

2019-02-11 Thread Ilya Maximets 
'sorted_poll_list()' uses the 'pmd->poll_list' that should be
guarded by 'pmd->port_mutex'.

Signed-off-by: Ilya Maximets 
---
 lib/dpif-netdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 914b2bb8b..34f2d2b07 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -1109,6 +1109,7 @@ compare_poll_list(const void *a_, const void *b_)
 static void
 sorted_poll_list(struct dp_netdev_pmd_thread *pmd, struct rxq_poll **list,
  size_t *n)
+OVS_REQUIRES(pmd->port_mutex)
 {
 struct rxq_poll *ret, *poll;
 size_t i;
-- 
2.17.1

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev