Re: [ovs-dev] [PATCH] m4: test avx512 for x86 only

2022-09-26 Thread Ilya Maximets 
On 9/16/22 16:52, Van Haaren, Harry wrote:
>> -Original Message-
>> From: lic...@chinatelecom.cn 
>> Sent: Friday, September 16, 2022 10:56 AM
>> To: d...@openvswitch.org; Van Haaren, Harry 
>> Cc: Cheng Li 
>> Subject: [PATCH] m4: test avx512 for x86 only
>>
>> 'as' command of arm version may don't support option '--64', this
>> patch is to move the avx512 test into x86 branch to avoid this.
>>
>> Signed-off-by: Cheng Li 
> 
> That's a good/simple solution to the issue;
> Tested-by: Harry van Haaren 

Thanks!  Applied and backported down to 2.17.

Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] m4: test avx512 for x86 only

2022-09-16 Thread Van Haaren, Harry 
> -Original Message-
> From: lic...@chinatelecom.cn 
> Sent: Friday, September 16, 2022 10:56 AM
> To: d...@openvswitch.org; Van Haaren, Harry 
> Cc: Cheng Li 
> Subject: [PATCH] m4: test avx512 for x86 only
> 
> 'as' command of arm version may don't support option '--64', this
> patch is to move the avx512 test into x86 branch to avoid this.
> 
> Signed-off-by: Cheng Li 

That's a good/simple solution to the issue;
Tested-by: Harry van Haaren 
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] m4: test avx512 for x86 only

2022-09-16 Thread Cheng Li 
'as' command of arm version may don't support option '--64', this
patch is to move the avx512 test into x86 branch to avoid this.

Signed-off-by: Cheng Li 
---
 m4/openvswitch.m4 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/m4/openvswitch.m4 b/m4/openvswitch.m4
index b5be5842..14d9249 100644
--- a/m4/openvswitch.m4
+++ b/m4/openvswitch.m4
@@ -494,8 +494,8 @@ AC_DEFUN([OVS_CHECK_BINUTILS_AVX512],
  mkdir -p build-aux
  OBJFILE=build-aux/binutils_avx512_check.o
  GATHER_PARAMS='0x8(,%ymm1,1),%ymm0{%k2}'
- echo "vpgatherqq $GATHER_PARAMS" | as --64 -o $OBJFILE -
  if ($CC -dumpmachine | grep x86_64) >/dev/null 2>&1; then
+   echo "vpgatherqq $GATHER_PARAMS" | as --64 -o $OBJFILE -
if (objdump -d  --no-show-raw-insn $OBJFILE | grep -q $GATHER_PARAMS) 
>/dev/null 2>&1; then
  ovs_cv_binutils_avx512_good=yes
else
@@ -504,11 +504,11 @@ AC_DEFUN([OVS_CHECK_BINUTILS_AVX512],
  dnl and causing zmm usage with buggy binutils versions.
  CFLAGS="$CFLAGS -mno-avx512f"
fi
+   rm $OBJFILE
  else
dnl non x86_64 architectures don't have avx512, so not affected
ovs_cv_binutils_avx512_good=no
  fi])
- rm $OBJFILE
if test "$ovs_cv_binutils_avx512_good" = yes; then
  AC_DEFINE([HAVE_LD_AVX512_GOOD], [1],
[Define to 1 if binutils correctly supports AVX512.])
-- 
1.8.3.1

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev