Re: [ovs-dev] [PATCH] ovn: Add missing netdev_close in setup_qos.

[Russell Bryant]

On Thu, Feb 2, 2017 at 12:41 PM, Ben Pfaff  wrote:

> On Thu, Feb 02, 2017 at 02:04:07AM -0500, Russell Bryant wrote:
> > We missed calling netdev_close in a couple of places.  One was in an
> error
> > condition rarely hit.  The second was just introduced and would be hit in
> > all cases where QoS is not in use.
> >
> > Fixes: dc2dab6e6de5 ("ovn-controller: Configure interface QoS only if it
> would actually be used.")
> > Signed-off-by: Russell Bryant 
>
> Thank you!
>
> Acked-by: Ben Pfaff 
>

Thanks, applied to master and branch-2.7.

-- 
Russell Bryant
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] ovn: Add missing netdev_close in setup_qos.

[Ben Pfaff]

On Thu, Feb 02, 2017 at 02:04:07AM -0500, Russell Bryant wrote:
> We missed calling netdev_close in a couple of places.  One was in an error
> condition rarely hit.  The second was just introduced and would be hit in
> all cases where QoS is not in use.
> 
> Fixes: dc2dab6e6de5 ("ovn-controller: Configure interface QoS only if it 
> would actually be used.")
> Signed-off-by: Russell Bryant 

Thank you!

Acked-by: Ben Pfaff 
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] ovn: Add missing netdev_close in setup_qos.

[Russell Bryant]

We missed calling netdev_close in a couple of places.  One was in an error
condition rarely hit.  The second was just introduced and would be hit in
all cases where QoS is not in use.

Fixes: dc2dab6e6de5 ("ovn-controller: Configure interface QoS only if it would 
actually be used.")
Signed-off-by: Russell Bryant 
---
 ovn/controller/binding.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ovn/controller/binding.c b/ovn/controller/binding.c
index 2d2da16..c90cb65 100644
--- a/ovn/controller/binding.c
+++ b/ovn/controller/binding.c
@@ -263,6 +263,7 @@ setup_qos(const char *egress_iface, struct hmap *queue_map)
 if (netdev_get_qos(netdev_phy, &qdisc_type, &qdisc_details) != 0 ||
 qdisc_type[0] == '\0') {
 smap_destroy(&qdisc_details);
+netdev_close(netdev_phy);
 /* Qos is not supported. */
 return;
 }
@@ -286,6 +287,7 @@ setup_qos(const char *egress_iface, struct hmap *queue_map)
 if (!strcmp(qdisc_type, OVN_QOS_TYPE)) {
 set_qos_type(netdev_phy, "");
 }
+netdev_close(netdev_phy);
 return;
 }
 
-- 
2.9.3

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev