Re: [ovs-dev] [PATCH] rhel: install firewalld ovn files with chmod 644 instead of 755

2017-05-31 Thread Ben Pfaff 
On Tue, May 30, 2017 at 08:13:02AM -0400, Lance Richardson wrote:
> > From: "Timothy Redaelli" <tredae...@redhat.com>
> > To: d...@openvswitch.org
> > Sent: Monday, 29 May, 2017 11:37:26 AM
> > Subject: [ovs-dev] [PATCH] rhel: install firewalld ovn files with chmod 644 
> > instead of 755
> > 
> > Signed-off-by: Timothy Redaelli <tredae...@redhat.com>
> > ---
> 
> LGTM, but I think it also needs:
> 
> Fixes: 55f36be59122 ("rhel: Firewall service files for OVN.")

Thanks, I applied this to master and branch-2.7 and added that line.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] rhel: install firewalld ovn files with chmod 644 instead of 755

2017-05-31 Thread Ben Pfaff 
Thanks, I applied this to master and branch-2.7.

On Tue, May 30, 2017 at 09:15:51AM +0200, Miguel Angel Ajo Pelayo wrote:
> Acked-By: Miguel Angel Ajo 
> 
> 
> 
> On Mon, May 29, 2017 at 5:37 PM, Timothy Redaelli 
> wrote:
> 
> > Signed-off-by: Timothy Redaelli 
> > ---
> >  rhel/openvswitch-fedora.spec.in | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.
> > spec.in
> > index 3200040..9fc5f27 100644
> > --- a/rhel/openvswitch-fedora.spec.in
> > +++ b/rhel/openvswitch-fedora.spec.in
> > @@ -279,9 +279,9 @@ install -p -m 644 -D selinux/openvswitch-custom.pp \
> >  $RPM_BUILD_ROOT%{_datadir}/selinux/packages/%{name}/
> > openvswitch-custom.pp
> >
> >  install -d $RPM_BUILD_ROOT%{_prefix}/lib/firewalld/services/
> > -install rhel/usr_lib_firewalld_services_ovn-central-firewall-service.xml
> > \
> > +install -p -m 0644 
> > rhel/usr_lib_firewalld_services_ovn-central-firewall-service.xml
> > \
> >  $RPM_BUILD_ROOT%{_prefix}/lib/firewalld/services/ovn-
> > central-firewall-service.xml
> > -install rhel/usr_lib_firewalld_services_ovn-host-firewall-service.xml \
> > +install -p -m 0644 
> > rhel/usr_lib_firewalld_services_ovn-host-firewall-service.xml
> > \
> >  $RPM_BUILD_ROOT%{_prefix}/lib/firewalld/services/ovn-host-
> > firewall-service.xml
> >
> >  # remove unpackaged files
> > --
> > 2.9.4
> >
> > ___
> > dev mailing list
> > d...@openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> >
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] rhel: install firewalld ovn files with chmod 644 instead of 755

2017-05-30 Thread Lance Richardson 
> From: "Timothy Redaelli" <tredae...@redhat.com>
> To: d...@openvswitch.org
> Sent: Monday, 29 May, 2017 11:37:26 AM
> Subject: [ovs-dev] [PATCH] rhel: install firewalld ovn files with chmod 644   
> instead of 755
> 
> Signed-off-by: Timothy Redaelli <tredae...@redhat.com>
> ---

LGTM, but I think it also needs:

Fixes: 55f36be59122 ("rhel: Firewall service files for OVN.")

   Lance

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] rhel: install firewalld ovn files with chmod 644 instead of 755

2017-05-30 Thread Miguel Angel Ajo Pelayo 
Acked-By: Miguel Angel Ajo 



On Mon, May 29, 2017 at 5:37 PM, Timothy Redaelli 
wrote:

> Signed-off-by: Timothy Redaelli 
> ---
>  rhel/openvswitch-fedora.spec.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.
> spec.in
> index 3200040..9fc5f27 100644
> --- a/rhel/openvswitch-fedora.spec.in
> +++ b/rhel/openvswitch-fedora.spec.in
> @@ -279,9 +279,9 @@ install -p -m 644 -D selinux/openvswitch-custom.pp \
>  $RPM_BUILD_ROOT%{_datadir}/selinux/packages/%{name}/
> openvswitch-custom.pp
>
>  install -d $RPM_BUILD_ROOT%{_prefix}/lib/firewalld/services/
> -install rhel/usr_lib_firewalld_services_ovn-central-firewall-service.xml
> \
> +install -p -m 0644 
> rhel/usr_lib_firewalld_services_ovn-central-firewall-service.xml
> \
>  $RPM_BUILD_ROOT%{_prefix}/lib/firewalld/services/ovn-
> central-firewall-service.xml
> -install rhel/usr_lib_firewalld_services_ovn-host-firewall-service.xml \
> +install -p -m 0644 
> rhel/usr_lib_firewalld_services_ovn-host-firewall-service.xml
> \
>  $RPM_BUILD_ROOT%{_prefix}/lib/firewalld/services/ovn-host-
> firewall-service.xml
>
>  # remove unpackaged files
> --
> 2.9.4
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev