Re: [ovs-dev] [PATCH] v2, python-windows: Fix unicode python tests on Windows

[aserdean]

> -Mesaj original-
> De la: ovs-dev-boun...@openvswitch.org  boun...@openvswitch.org> În numele Ben Pfaff
> Trimis: Saturday, March 31, 2018 10:46 PM
> Către: Alin Gabriel Serdean <aserd...@ovn.org>
> Cc: d...@openvswitch.org
> Subiect: Re: [ovs-dev] [PATCH] v2, python-windows: Fix unicode python
> tests on Windows
> 
> On Wed, Mar 28, 2018 at 12:11:18PM +0300, Alin Gabriel Serdean wrote:
> > This patch changes the default filesystem encodings to the values used
> > before python3.6 to ensure compatibility with older versions.
> >
> > Signed-off-by: Alin Gabriel Serdean <aserd...@ovn.org>
> > Co-authored-by: Alin Balutoiu <abalut...@cloudbasesolutions.com>
> > ---
> > v2: update commit message
> 
> I don't really understand this change, but if it fixes a problem in the
tests
> then I'm all in favor of it.
> 
> If it is not difficult, then I would suggest adding a little more
information to
> the commit message, such as an example of what goes wrong without it.
> 
> Acked-by: Ben Pfaff <b...@ovn.org>
> ___
I'll drop this change and improve the commit message in the next revision.
Thanks for the review!

Alin.



___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] v2, python-windows: Fix unicode python tests on Windows

[Ben Pfaff]

On Wed, Mar 28, 2018 at 12:11:18PM +0300, Alin Gabriel Serdean wrote:
> This patch changes the default filesystem encodings to the values used
> before python3.6 to ensure compatibility with older versions.
> 
> Signed-off-by: Alin Gabriel Serdean 
> Co-authored-by: Alin Balutoiu 
> ---
> v2: update commit message

I don't really understand this change, but if it fixes a problem in the
tests then I'm all in favor of it.

If it is not difficult, then I would suggest adding a little more
information to the commit message, such as an example of what goes wrong
without it.

Acked-by: Ben Pfaff 
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] v2, python-windows: Fix unicode python tests on Windows

[Alin Gabriel Serdean]

This patch changes the default filesystem encodings to the values used
before python3.6 to ensure compatibility with older versions.

Signed-off-by: Alin Gabriel Serdean 
Co-authored-by: Alin Balutoiu 
---
v2: update commit message
---
 tests/atlocal.in | 9 +
 1 file changed, 9 insertions(+)

diff --git a/tests/atlocal.in b/tests/atlocal.in
index 55f9333ee..0df504be7 100644
--- a/tests/atlocal.in
+++ b/tests/atlocal.in
@@ -106,6 +106,15 @@ FreeBSD|NetBSD)
 ;;
 esac
 
+if test x"$PYTHON3" != x && test "$IS_WIN32" = yes; then
+# enables legacy windows unicode printing needed for Python3 compatibility
+# with the Python2 tests
+PYTHONLEGACYWINDOWSFSENCODING=true
+export PYTHONLEGACYWINDOWSFSENCODING
+PYTHONLEGACYWINDOWSSTDIO=true
+export PYTHONLEGACYWINDOWSSTDIO
+fi
+
 # Check whether to run IPv6 tests.
 if $PYTHON -c '
 import socket
-- 
2.16.1.windows.1

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev