Re: [ovs-dev] [PATCH] vconn: Fix using of uninitialized deadline.

[Ben Pfaff]

On Fri, Jan 11, 2019 at 11:09:19AM +0300, Ilya Maximets wrote:
> Typo introduced while making minor refactoring before applying the
> patch.
> 
> Fixes logic and the clang build:
> 
>   lib/vconn.c:707:47: error:
>   variable 'deadline' is uninitialized when
>   used within its own initialization [-Werror,-Wuninitialized]
>   ? time_msec() + deadline
>   ^~~~
> 
> Fixes: 04895042e9f6 ("vconn: Allow timeout configuration for blocking 
> connection.")
> Signed-off-by: Ilya Maximets 

Well, I'm an idiot.  Sorry about that.

I applied this to master.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] vconn: Fix using of uninitialized deadline.

[Kevin Traynor]

On 01/11/2019 08:09 AM, Ilya Maximets wrote:
> Typo introduced while making minor refactoring before applying the
> patch.
> 
> Fixes logic and the clang build:
> 
>   lib/vconn.c:707:47: error:
>   variable 'deadline' is uninitialized when
>   used within its own initialization [-Werror,-Wuninitialized]
>   ? time_msec() + deadline
>   ^~~~
> 
> Fixes: 04895042e9f6 ("vconn: Allow timeout configuration for blocking 
> connection.")
> Signed-off-by: Ilya Maximets 

Acked-by: Kevin Traynor 

> ---
>  lib/vconn.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/vconn.c b/lib/vconn.c
> index 40ebc5818..403461662 100644
> --- a/lib/vconn.c
> +++ b/lib/vconn.c
> @@ -704,7 +704,7 @@ int
>  vconn_connect_block(struct vconn *vconn, long long int timeout)
>  {
>  long long int deadline = (timeout >= 0
> -  ? time_msec() + deadline
> +  ? time_msec() + timeout
>: LLONG_MAX);
>  
>  int error;
> 

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] vconn: Fix using of uninitialized deadline.

[Ilya Maximets]

Typo introduced while making minor refactoring before applying the
patch.

Fixes logic and the clang build:

  lib/vconn.c:707:47: error:
  variable 'deadline' is uninitialized when
  used within its own initialization [-Werror,-Wuninitialized]
  ? time_msec() + deadline
  ^~~~

Fixes: 04895042e9f6 ("vconn: Allow timeout configuration for blocking 
connection.")
Signed-off-by: Ilya Maximets 
---
 lib/vconn.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/vconn.c b/lib/vconn.c
index 40ebc5818..403461662 100644
--- a/lib/vconn.c
+++ b/lib/vconn.c
@@ -704,7 +704,7 @@ int
 vconn_connect_block(struct vconn *vconn, long long int timeout)
 {
 long long int deadline = (timeout >= 0
-  ? time_msec() + deadline
+  ? time_msec() + timeout
   : LLONG_MAX);
 
 int error;
-- 
2.17.1

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev