Re: [ovs-dev] [PATCH 1/2] ofp-util: Remove prototypes for unimplemented functions.

[Yifeng Sun]

Thanks for the clean up. Looks good to me.

Reviewed-by: Yifeng Sun 

On Fri, Feb 9, 2018 at 2:57 PM, Ben Pfaff  wrote:

> Signed-off-by: Ben Pfaff 
> ---
>  include/openvswitch/ofp-util.h | 12 
>  1 file changed, 12 deletions(-)
>
> diff --git a/include/openvswitch/ofp-util.h b/include/openvswitch/ofp-
> util.h
> index 5dd1b34c216b..876ca6ed280a 100644
> --- a/include/openvswitch/ofp-util.h
> +++ b/include/openvswitch/ofp-util.h
> @@ -39,7 +39,6 @@ extern "C" {
>  #endif
>
>  struct ofpbuf;
> -union ofp_action;
>  struct ofpact_set_field;
>  struct vl_mff_map;
>
> @@ -1190,17 +1189,6 @@ struct ofpbuf *make_echo_reply(const struct
> ofp_header *rq);
>
>  struct ofpbuf *ofputil_encode_barrier_request(enum ofp_version);
>
> -/* Actions. */
> -
> -bool action_outputs_to_port(const union ofp_action *, ovs_be16 port);
> -
> -enum ofperr ofputil_pull_actions(struct ofpbuf *, unsigned int
> actions_len,
> - union ofp_action **, size_t *);
> -
> -bool ofputil_actions_equal(const union ofp_action *a, size_t n_a,
> -   const union ofp_action *b, size_t n_b);
> -union ofp_action *ofputil_actions_clone(const union ofp_action *, size_t
> n);
> -
>  /* Handy utility for parsing flows and actions. */
>  bool ofputil_parse_key_value(char **stringp, char **keyp, char **valuep);
>
> --
> 2.15.1
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH 1/2] ofp-util: Remove prototypes for unimplemented functions.

[Ben Pfaff]

Signed-off-by: Ben Pfaff 
---
 include/openvswitch/ofp-util.h | 12 
 1 file changed, 12 deletions(-)

diff --git a/include/openvswitch/ofp-util.h b/include/openvswitch/ofp-util.h
index 5dd1b34c216b..876ca6ed280a 100644
--- a/include/openvswitch/ofp-util.h
+++ b/include/openvswitch/ofp-util.h
@@ -39,7 +39,6 @@ extern "C" {
 #endif
 
 struct ofpbuf;
-union ofp_action;
 struct ofpact_set_field;
 struct vl_mff_map;
 
@@ -1190,17 +1189,6 @@ struct ofpbuf *make_echo_reply(const struct ofp_header 
*rq);
 
 struct ofpbuf *ofputil_encode_barrier_request(enum ofp_version);
 
-/* Actions. */
-
-bool action_outputs_to_port(const union ofp_action *, ovs_be16 port);
-
-enum ofperr ofputil_pull_actions(struct ofpbuf *, unsigned int actions_len,
- union ofp_action **, size_t *);
-
-bool ofputil_actions_equal(const union ofp_action *a, size_t n_a,
-   const union ofp_action *b, size_t n_b);
-union ofp_action *ofputil_actions_clone(const union ofp_action *, size_t n);
-
 /* Handy utility for parsing flows and actions. */
 bool ofputil_parse_key_value(char **stringp, char **keyp, char **valuep);
 
-- 
2.15.1

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev