Re: [ovs-dev] [PATCH 1/3] ovs-check-dead-ifs: python3 print format

2019-09-25 Thread Ben Pfaff 
On Fri, Sep 13, 2019 at 01:29:01PM -0400, Aaron Conole wrote:
> The print call changed in python3, so update it.
> 
> Signed-off-by: Aaron Conole 

Thanks for the patches.  (William, thanks for the reviews.)  I applied
this series to master.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/3] ovs-check-dead-ifs: python3 print format

2019-09-14 Thread William Tu 
On Fri, Sep 13, 2019 at 01:29:01PM -0400, Aaron Conole wrote:
> The print call changed in python3, so update it.
> 
> Signed-off-by: Aaron Conole 

LGTM
Acked-by: William Tu 

> ---
>  utilities/ovs-check-dead-ifs.in | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/utilities/ovs-check-dead-ifs.in b/utilities/ovs-check-dead-ifs.in
> index ac54f6c9c..f398a3401 100755
> --- a/utilities/ovs-check-dead-ifs.in
> +++ b/utilities/ovs-check-dead-ifs.in
> @@ -37,7 +37,7 @@ for ifname in os.listdir("/sys/class/net"):
>  except IOError:
>  pass
>  except ValueError:
> -print "%s: unexpected format\n" % fn
> +print("%s: unexpected format\n" % fn)
>  
>  # Get inodes for all packet sockets whose ifindexes don't exist.
>  invalid_inodes = set()
> @@ -95,8 +95,8 @@ for pid in os.listdir("/proc"):
>  bad_pids.add(pid)
>  
>  if bad_pids:
> -print """
> +print("""
>  The following processes are listening for packets to arrive on network 
> devices
> -that no longer exist. You may want to restart them."""
> +that no longer exist. You may want to restart them.""")
>  sys.stdout.flush()
>  os.execvp("ps", ["ps"] + ["%s" % pid for pid in bad_pids])
> -- 
> 2.21.0
> 
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH 1/3] ovs-check-dead-ifs: python3 print format

2019-09-13 Thread Aaron Conole 
The print call changed in python3, so update it.

Signed-off-by: Aaron Conole 
---
 utilities/ovs-check-dead-ifs.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/utilities/ovs-check-dead-ifs.in b/utilities/ovs-check-dead-ifs.in
index ac54f6c9c..f398a3401 100755
--- a/utilities/ovs-check-dead-ifs.in
+++ b/utilities/ovs-check-dead-ifs.in
@@ -37,7 +37,7 @@ for ifname in os.listdir("/sys/class/net"):
 except IOError:
 pass
 except ValueError:
-print "%s: unexpected format\n" % fn
+print("%s: unexpected format\n" % fn)
 
 # Get inodes for all packet sockets whose ifindexes don't exist.
 invalid_inodes = set()
@@ -95,8 +95,8 @@ for pid in os.listdir("/proc"):
 bad_pids.add(pid)
 
 if bad_pids:
-print """
+print("""
 The following processes are listening for packets to arrive on network devices
-that no longer exist. You may want to restart them."""
+that no longer exist. You may want to restart them.""")
 sys.stdout.flush()
 os.execvp("ps", ["ps"] + ["%s" % pid for pid in bad_pids])
-- 
2.21.0

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev