Re: [ovs-dev] [PATCH 10/10] build-windows: cccl fail compilation on Wimplicit-function-declaration

[Alin Serdean]

> > As a temporary solution issue an error when this warning is triggered.
> > This will help development on the Windows side.
> >
> > Suggested-by: Ben Pfaff 
> > Signed-off-by: Alin Gabriel Serdean 
> 
> This seems reasonable to me.  I assume that other patches in the series are
> needed before this one can be applied, so I'll wait for the next revision of 
> the
> series before applying it.
[Alin Serdean] You are correct in your assumption . I will post another 
revision once we clarify the rest of the reviews.

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH 10/10] build-windows: cccl fail compilation on Wimplicit-function-declaration

[Alin Serdean]

Gcc compiler argument -Wall contains -Wimplicit-function-declaration which
gives warnings when a function is used before declared.
Map VStudio compiler error C4013 to it.
More info on C4013:
https://msdn.microsoft.com/en-us/library/d3ct4kz9.aspx

At the moment we cannot switch to the equivalent -Werror because we need
to solve other warnings.

As a temporary solution issue an error when this warning is triggered.
This will help development on the Windows side.

Suggested-by: Ben Pfaff 
Signed-off-by: Alin Gabriel Serdean 
---
 build-aux/cccl | 8 
 1 file changed, 8 insertions(+)

diff --git a/build-aux/cccl b/build-aux/cccl
index 93f9c50..e2426fb 100644
--- a/build-aux/cccl
+++ b/build-aux/cccl
@@ -144,6 +144,14 @@ EOF
 #ignore pedantic
 ;;
 
+-Wall)
+# not all warnings are implemented
+# the following is equivalent to
+# Wimplicit-function-declaration but we will issue a compiler
+# error
+clopt="$clopt ${slash}we4013"
+;;
+
 -W*)
 #ignore warnings
 ;;
-- 
2.10.2.windows.1
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev