Re: [ovs-dev] [PATCH 2/2] checkpatch: Fix personal word list storage.

2023-11-10 Thread Aaron Conole 
Roi Dayan  writes:

> On 08/11/2023 20:50, Aaron Conole wrote:
>> Eelco Chaudron  writes:
>> 
>>> On 2 Nov 2023, at 14:20, Roi Dayan via dev wrote:
>>>
 From: Gaetan Rivet 

 The enchant dictionary synchronizes additions to the source file.
 Keep the two word source separate by adding the extra words only
 to the current session.

 Signed-off-by: Gaetan Rivet 
 Acked-by: Roi Dayan 
 ---
  utilities/checkpatch.py | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
 index 9276640760d4..b484a37db2e8 100755
 --- a/utilities/checkpatch.py
 +++ b/utilities/checkpatch.py
 @@ -95,7 +95,7 @@ def open_spell_check_dict():
  'dictionary.txt')
  spell_check_dict = enchant.DictWithPWL('en_US', word_dic)
  for kw in extra_keywords:
 -spell_check_dict.add(kw)
 +spell_check_dict.add_to_session(kw)
>>>
>>> I guess this should be the first patch (or maybe a fixes patch in general).
>> 
>> +1 - I would be fine with merging this on its own.
>> 
>
> ok. is it possible to take only this one from the series or I need
> to send it again on its own?

Yes - I will take this patch on Monday.


  return True
  except:
 -- 
 2.40.1

 ___
 dev mailing list
 d...@openvswitch.org
 https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>>>
>>> ___
>>> dev mailing list
>>> d...@openvswitch.org
>>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>> 

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/2] checkpatch: Fix personal word list storage.

2023-11-08 Thread Roi Dayan via dev 



On 08/11/2023 20:50, Aaron Conole wrote:
> Eelco Chaudron  writes:
> 
>> On 2 Nov 2023, at 14:20, Roi Dayan via dev wrote:
>>
>>> From: Gaetan Rivet 
>>>
>>> The enchant dictionary synchronizes additions to the source file.
>>> Keep the two word source separate by adding the extra words only
>>> to the current session.
>>>
>>> Signed-off-by: Gaetan Rivet 
>>> Acked-by: Roi Dayan 
>>> ---
>>>  utilities/checkpatch.py | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
>>> index 9276640760d4..b484a37db2e8 100755
>>> --- a/utilities/checkpatch.py
>>> +++ b/utilities/checkpatch.py
>>> @@ -95,7 +95,7 @@ def open_spell_check_dict():
>>>  'dictionary.txt')
>>>  spell_check_dict = enchant.DictWithPWL('en_US', word_dic)
>>>  for kw in extra_keywords:
>>> -spell_check_dict.add(kw)
>>> +spell_check_dict.add_to_session(kw)
>>
>> I guess this should be the first patch (or maybe a fixes patch in general).
> 
> +1 - I would be fine with merging this on its own.
> 

ok. is it possible to take only this one from the series or I need
to send it again on its own?

>>>
>>>  return True
>>>  except:
>>> -- 
>>> 2.40.1
>>>
>>> ___
>>> dev mailing list
>>> d...@openvswitch.org
>>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>>
>> ___
>> dev mailing list
>> d...@openvswitch.org
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> 

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/2] checkpatch: Fix personal word list storage.

2023-11-08 Thread Aaron Conole 
Eelco Chaudron  writes:

> On 2 Nov 2023, at 14:20, Roi Dayan via dev wrote:
>
>> From: Gaetan Rivet 
>>
>> The enchant dictionary synchronizes additions to the source file.
>> Keep the two word source separate by adding the extra words only
>> to the current session.
>>
>> Signed-off-by: Gaetan Rivet 
>> Acked-by: Roi Dayan 
>> ---
>>  utilities/checkpatch.py | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
>> index 9276640760d4..b484a37db2e8 100755
>> --- a/utilities/checkpatch.py
>> +++ b/utilities/checkpatch.py
>> @@ -95,7 +95,7 @@ def open_spell_check_dict():
>>  'dictionary.txt')
>>  spell_check_dict = enchant.DictWithPWL('en_US', word_dic)
>>  for kw in extra_keywords:
>> -spell_check_dict.add(kw)
>> +spell_check_dict.add_to_session(kw)
>
> I guess this should be the first patch (or maybe a fixes patch in general).

+1 - I would be fine with merging this on its own.

>>
>>  return True
>>  except:
>> -- 
>> 2.40.1
>>
>> ___
>> dev mailing list
>> d...@openvswitch.org
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/2] checkpatch: Fix personal word list storage.

2023-11-05 Thread Roi Dayan via dev 



On 02/11/2023 16:07, Eelco Chaudron wrote:
> 
> 
> On 2 Nov 2023, at 14:20, Roi Dayan via dev wrote:
> 
>> From: Gaetan Rivet 
>>
>> The enchant dictionary synchronizes additions to the source file.
>> Keep the two word source separate by adding the extra words only
>> to the current session.
>>
>> Signed-off-by: Gaetan Rivet 
>> Acked-by: Roi Dayan 
>> ---
>>  utilities/checkpatch.py | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
>> index 9276640760d4..b484a37db2e8 100755
>> --- a/utilities/checkpatch.py
>> +++ b/utilities/checkpatch.py
>> @@ -95,7 +95,7 @@ def open_spell_check_dict():
>>  'dictionary.txt')
>>  spell_check_dict = enchant.DictWithPWL('en_US', word_dic)
>>  for kw in extra_keywords:
>> -spell_check_dict.add(kw)
>> +spell_check_dict.add_to_session(kw)
> 
> I guess this should be the first patch (or maybe a fixes patch in general).

I don't think the order matters. I just sent together because they can cause a 
conflict
as the patches modify the same area.

Let me know if you want me to add a fixes line or it can be amended when commit 
taken.
This is the fixes line.

Fixes: 999c7773a60b ("checkpatch: add a comment spell-checker")

> 
>>
>>  return True
>>  except:
>> -- 
>> 2.40.1
>>
>> ___
>> dev mailing list
>> d...@openvswitch.org
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> 

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/2] checkpatch: Fix personal word list storage.

2023-11-02 Thread Eelco Chaudron 



On 2 Nov 2023, at 14:20, Roi Dayan via dev wrote:

> From: Gaetan Rivet 
>
> The enchant dictionary synchronizes additions to the source file.
> Keep the two word source separate by adding the extra words only
> to the current session.
>
> Signed-off-by: Gaetan Rivet 
> Acked-by: Roi Dayan 
> ---
>  utilities/checkpatch.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
> index 9276640760d4..b484a37db2e8 100755
> --- a/utilities/checkpatch.py
> +++ b/utilities/checkpatch.py
> @@ -95,7 +95,7 @@ def open_spell_check_dict():
>  'dictionary.txt')
>  spell_check_dict = enchant.DictWithPWL('en_US', word_dic)
>  for kw in extra_keywords:
> -spell_check_dict.add(kw)
> +spell_check_dict.add_to_session(kw)

I guess this should be the first patch (or maybe a fixes patch in general).

>
>  return True
>  except:
> -- 
> 2.40.1
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH 2/2] checkpatch: Fix personal word list storage.

2023-11-02 Thread Roi Dayan via dev 
From: Gaetan Rivet 

The enchant dictionary synchronizes additions to the source file.
Keep the two word source separate by adding the extra words only
to the current session.

Signed-off-by: Gaetan Rivet 
Acked-by: Roi Dayan 
---
 utilities/checkpatch.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py
index 9276640760d4..b484a37db2e8 100755
--- a/utilities/checkpatch.py
+++ b/utilities/checkpatch.py
@@ -95,7 +95,7 @@ def open_spell_check_dict():
 'dictionary.txt')
 spell_check_dict = enchant.DictWithPWL('en_US', word_dic)
 for kw in extra_keywords:
-spell_check_dict.add(kw)
+spell_check_dict.add_to_session(kw)
 
 return True
 except:
-- 
2.40.1

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev