Re: [ovs-dev] [PATCH 2/2] lib/automake.mk: don't install runtime directories
On Thu, Apr 13, 2017 at 01:51:30PM -0400, Aaron Conole wrote: > The Open vSwitch run, log, and DB directories are installed as part of the > normal `make install` process. However, this means they are created with > user and group ownership that may conflict with the desired user. For > example, running `make install` as root will install those files as > root:root, whereas the runtime user desired may be openvswitch:openvswitch. > > Since these directories are automatically created as part of the ovs-ctl > command, and with the correct user:group permissions, it makes sense to > delay creation until these directories are actually required. > > Reviewed-by: Markos Chandras > Signed-off-by: Aaron Conole This seems like a good idea to me once we figure out patch 1. Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH 2/2] lib/automake.mk: don't install runtime directories
The Open vSwitch run, log, and DB directories are installed as part of the normal `make install` process. However, this means they are created with user and group ownership that may conflict with the desired user. For example, running `make install` as root will install those files as root:root, whereas the runtime user desired may be openvswitch:openvswitch. Since these directories are automatically created as part of the ovs-ctl command, and with the correct user:group permissions, it makes sense to delay creation until these directories are actually required. Reviewed-by: Markos Chandras Signed-off-by: Aaron Conole --- lib/automake.mk | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/automake.mk b/lib/automake.mk index 62b2f38..faace79 100644 --- a/lib/automake.mk +++ b/lib/automake.mk @@ -534,10 +534,7 @@ EXTRA_DIST += build-aux/extract-ofp-msgs INSTALL_DATA_LOCAL += lib-install-data-local lib-install-data-local: - $(MKDIR_P) $(DESTDIR)$(RUNDIR) $(MKDIR_P) $(DESTDIR)$(PKIDIR) - $(MKDIR_P) $(DESTDIR)$(LOGDIR) - $(MKDIR_P) $(DESTDIR)$(DBDIR) $(MKDIR_P) $(DESTDIR)$(sysconfdir)/openvswitch man_MANS += lib/ovs-fields.7 -- 2.9.3 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev