Re: [ovs-dev] [PATCH V2 04/12] netdev-offload-dpdk: Support partial TCP/UDP port matching

[Sriharsha Basavapatna via dev]

On Wed, May 27, 2020 at 9:31 PM Eli Britstein  wrote:
>
> The cited commit failed partial matching of TCP/UDP port matching,
> preventing such offload of supporting HWs. Remove this failure.
>
> Fixes: e8a2b5bf92bb ("netdev-dpdk: implement flow offload with rte flow")
> Signed-off-by: Eli Britstein 
> Reviewed-by: Roni Bar Yanai 
> ---
>  lib/netdev-offload-dpdk.c | 5 -
>  1 file changed, 5 deletions(-)
>
Acked-by: sriharsha.basavapa...@broadcom.com

Thanks,
-Harsha

> diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
> index dd5e71e36..4c0e6af68 100644
> --- a/lib/netdev-offload-dpdk.c
> +++ b/lib/netdev-offload-dpdk.c
> @@ -760,11 +760,6 @@ parse_flow_match(struct flow_patterns *patterns,
>  return -1;
>  }
>
> -if ((match->wc.masks.tp_src && match->wc.masks.tp_src != OVS_BE16_MAX) ||
> -(match->wc.masks.tp_dst && match->wc.masks.tp_dst != OVS_BE16_MAX)) {
> -return -1;
> -}
> -
>  if (proto == IPPROTO_TCP) {
>  struct rte_flow_item_tcp *spec, *mask;
>
> --
> 2.14.5
>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH V2 04/12] netdev-offload-dpdk: Support partial TCP/UDP port matching

[Eli Britstein]

The cited commit failed partial matching of TCP/UDP port matching,
preventing such offload of supporting HWs. Remove this failure.

Fixes: e8a2b5bf92bb ("netdev-dpdk: implement flow offload with rte flow")
Signed-off-by: Eli Britstein 
Reviewed-by: Roni Bar Yanai 
---
 lib/netdev-offload-dpdk.c | 5 -
 1 file changed, 5 deletions(-)

diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c
index dd5e71e36..4c0e6af68 100644
--- a/lib/netdev-offload-dpdk.c
+++ b/lib/netdev-offload-dpdk.c
@@ -760,11 +760,6 @@ parse_flow_match(struct flow_patterns *patterns,
 return -1;
 }
 
-if ((match->wc.masks.tp_src && match->wc.masks.tp_src != OVS_BE16_MAX) ||
-(match->wc.masks.tp_dst && match->wc.masks.tp_dst != OVS_BE16_MAX)) {
-return -1;
-}
-
 if (proto == IPPROTO_TCP) {
 struct rte_flow_item_tcp *spec, *mask;
 
-- 
2.14.5

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev