Re: [ovs-dev] [PATCH V3 7/7] Documentation: Remove kernel module documentation
On 7/9/2022 12:31 AM, David Marchand wrote: On Fri, Jul 8, 2022 at 10:09 PM Greg Rose wrote: diff --git a/Documentation/internals/contributing/backporting-patches.rst b/Documentation/internals/contributing/backporting-patches.rst index 162e9d209..8370c954d 100644 --- a/Documentation/internals/contributing/backporting-patches.rst +++ b/Documentation/internals/contributing/backporting-patches.rst @@ -119,6 +119,13 @@ userspace changes. How to backport kernel patches ~~ +These instructions only apply to Open vSwitch releases 2.16 and older. +As of Open vSwitch branch 2.17 the Open vSwitch kernel module is no +longer supported and only the Linux openvswitch kernel module is used. +In the case of Open vSwitch releases 2.16 and older kernel backports +may be required for bux fixes and feature implementation so these +instructions are preserved for that reason. + First, the patch should be submitted upstream to `netdev`. When the patch has been applied to `net-next`, it is ready to be backported. Starting from the Linux tree, use ``git format-patch`` to format each patch that should be Adding to Ilya comments. Here, should those versions here be bumped by one too? Leaving it as proposed in this patch, this saves us from potential backporting effort to 2.17 too :-). I think they're supposed to be bumped. I'll take care of it. Thanks, - Greg ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH V3 7/7] Documentation: Remove kernel module documentation
On Fri, Jul 8, 2022 at 10:09 PM Greg Rose wrote: > diff --git a/Documentation/internals/contributing/backporting-patches.rst > b/Documentation/internals/contributing/backporting-patches.rst > index 162e9d209..8370c954d 100644 > --- a/Documentation/internals/contributing/backporting-patches.rst > +++ b/Documentation/internals/contributing/backporting-patches.rst > @@ -119,6 +119,13 @@ userspace changes. > How to backport kernel patches > ~~ > > +These instructions only apply to Open vSwitch releases 2.16 and older. > +As of Open vSwitch branch 2.17 the Open vSwitch kernel module is no > +longer supported and only the Linux openvswitch kernel module is used. > +In the case of Open vSwitch releases 2.16 and older kernel backports > +may be required for bux fixes and feature implementation so these > +instructions are preserved for that reason. > + > First, the patch should be submitted upstream to `netdev`. When the patch has > been applied to `net-next`, it is ready to be backported. Starting from the > Linux tree, use ``git format-patch`` to format each patch that should be Adding to Ilya comments. Here, should those versions here be bumped by one too? Leaving it as proposed in this patch, this saves us from potential backporting effort to 2.17 too :-). -- David Marchand ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH V3 7/7] Documentation: Remove kernel module documentation
On 7/8/22 22:03, Greg Rose wrote: > As of Open vSwitch release 2.18 the OVS kernel module is no longer > supported. Pull the documentation references. > > Signed-off-by: Greg Rose > --- > Documentation/faq/releases.rst| 5 +- > .../contributing/backporting-patches.rst | 7 +++ > Documentation/intro/install/fedora.rst| 24 --- > Documentation/intro/install/general.rst | 63 --- > 4 files changed, 10 insertions(+), 89 deletions(-) > > diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst > index 8cfe2d392..ab2925a62 100644 > --- a/Documentation/faq/releases.rst > +++ b/Documentation/faq/releases.rst > @@ -74,7 +74,7 @@ Q: What Linux kernel versions does each Open vSwitch > release work with? > 2.14.x 3.16 to 5.5 > 2.15.x 3.16 to 5.8 > 2.16.x 3.16 to 5.8 > -2.17.x 3.16 to 5.8 > +2.17.x N/A We should leave the 2.17 entry here add something like: 2.18+N/A > == > > Open vSwitch userspace should also work with the Linux kernel module > built > @@ -110,7 +110,8 @@ Q: Are all features available with all datapaths? > Linux OVS tree >The datapath implemented by the Linux kernel module distributed with >the OVS source tree. This datapath is deprecated starting with OVS > - 2.15.x and support capped at Linux kernel version 5.8. > + 2.15.x and support capped at Linux kernel version 5.8. As of OVS 2.17.x > + the Linux OVS tree is no longer supported. It should be 2.18 as well. Best regards, Ilya Maximets. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH V3 7/7] Documentation: Remove kernel module documentation
Bleep bloop. Greetings Gregory Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH V3 7/7] Documentation: Remove kernel module documentation
As of Open vSwitch release 2.18 the OVS kernel module is no longer supported. Pull the documentation references. Signed-off-by: Greg Rose --- Documentation/faq/releases.rst| 5 +- .../contributing/backporting-patches.rst | 7 +++ Documentation/intro/install/fedora.rst| 24 --- Documentation/intro/install/general.rst | 63 --- 4 files changed, 10 insertions(+), 89 deletions(-) diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index 8cfe2d392..ab2925a62 100644 --- a/Documentation/faq/releases.rst +++ b/Documentation/faq/releases.rst @@ -74,7 +74,7 @@ Q: What Linux kernel versions does each Open vSwitch release work with? 2.14.x 3.16 to 5.5 2.15.x 3.16 to 5.8 2.16.x 3.16 to 5.8 -2.17.x 3.16 to 5.8 +2.17.x N/A == Open vSwitch userspace should also work with the Linux kernel module built @@ -110,7 +110,8 @@ Q: Are all features available with all datapaths? Linux OVS tree The datapath implemented by the Linux kernel module distributed with the OVS source tree. This datapath is deprecated starting with OVS - 2.15.x and support capped at Linux kernel version 5.8. + 2.15.x and support capped at Linux kernel version 5.8. As of OVS 2.17.x + the Linux OVS tree is no longer supported. Userspace This datapath supports conventional system devices as well as diff --git a/Documentation/internals/contributing/backporting-patches.rst b/Documentation/internals/contributing/backporting-patches.rst index 162e9d209..8370c954d 100644 --- a/Documentation/internals/contributing/backporting-patches.rst +++ b/Documentation/internals/contributing/backporting-patches.rst @@ -119,6 +119,13 @@ userspace changes. How to backport kernel patches ~~ +These instructions only apply to Open vSwitch releases 2.16 and older. +As of Open vSwitch branch 2.17 the Open vSwitch kernel module is no +longer supported and only the Linux openvswitch kernel module is used. +In the case of Open vSwitch releases 2.16 and older kernel backports +may be required for bux fixes and feature implementation so these +instructions are preserved for that reason. + First, the patch should be submitted upstream to `netdev`. When the patch has been applied to `net-next`, it is ready to be backported. Starting from the Linux tree, use ``git format-patch`` to format each patch that should be diff --git a/Documentation/intro/install/fedora.rst b/Documentation/intro/install/fedora.rst index 06a0bd3d5..02481597f 100644 --- a/Documentation/intro/install/fedora.rst +++ b/Documentation/intro/install/fedora.rst @@ -132,36 +132,12 @@ tests. This can take several minutes. $ make rpm-fedora RPMBUILD_OPT="--with check" -Kernel OVS Tree Datapath RPM - - -To build the Open vSwitch kernel module for the currently running kernel -version, run: - -:: - -$ make rpm-fedora-kmod - -To build the Open vSwitch kernel module for another kernel version, the desired -kernel version can be specified via the `kversion` macro. For example: - -:: - -$ make rpm-fedora-kmod \ - RPMBUILD_OPT='-D "kversion 4.3.4-300.fc23.x86_64"' - Installing -- RPM packages can be installed by using the command ``rpm -i``. Package installation requires superuser privileges. -The `openvswitch-kmod` RPM should be installed first if the Linux OVS tree -datapath module is to be used. The `openvswitch-kmod` RPM should not be -installed if only the in-tree Linux datapath or user-space datapath is needed. -Refer to the :doc:`/faq/index` for more information about the various Open -vSwitch datapath options. - In most cases only the `openvswitch` RPM will need to be installed. The `python3-openvswitch`, `openvswitch-test`, `openvswitch-devel`, and `openvswitch-debuginfo` RPMs are optional unless required for a specific diff --git a/Documentation/intro/install/general.rst b/Documentation/intro/install/general.rst index a297aadac..c2208bbed 100644 --- a/Documentation/intro/install/general.rst +++ b/Documentation/intro/install/general.rst @@ -302,24 +302,6 @@ example:: $ ./configure CFLAGS="-g -O2 -fsanitize=address -fno-omit-frame-pointer -fno-common" -To build the Linux kernel module, so that you can run the kernel-based switch, -pass the location of the kernel build directory on ``--with-linux``. For -example, to build for a running instance of Linux:: - -$ ./configure --with-linux=/lib/modules/$(uname -r)/build - -.. note:: - If ``--with-linux`` requests building for an unsupported version of Linux, - then ``configure`` will fail with an error message. Refer to the - :doc:`/faq/index` for advice in that case. - -If you wish to build the kernel module for an architecture other than the -architecture of the machine used for the build, you may specify the kernel -architecture stri
