Re: [ovs-dev] [PATCH ovn] ovn-sb.xml: Remove IPv4-only restriction from Service Monitors.

2024-02-09 Thread Dumitru Ceara
On 2/2/24 10:55, Ales Musil wrote:
> On Fri, Feb 2, 2024 at 4:21 AM Mark Michelson  wrote:
> 
>> The documentation for Service_Monitors in the southbound database state
>> that only IPv4 is supported. However, IPv6 service monitors have been
>> supported since OVN 23.03 was released.
>>
>> This patch addresses the problem by removing the incorrect
>> documentation.
>>
>> Fixes: 40a686e8e70f ("Add IPv6 support for lb health-check")
>> Signed-off-by: Mark Michelson 
>> ---

Thanks, Mark and Ales!

Applied to main and backported all the way to 23.03.

Regards,
Dumitru

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev


Re: [ovs-dev] [PATCH ovn] ovn-sb.xml: Remove IPv4-only restriction from Service Monitors.

2024-02-02 Thread Ales Musil
On Fri, Feb 2, 2024 at 4:21 AM Mark Michelson  wrote:

> The documentation for Service_Monitors in the southbound database state
> that only IPv4 is supported. However, IPv6 service monitors have been
> supported since OVN 23.03 was released.
>
> This patch addresses the problem by removing the incorrect
> documentation.
>
> Fixes: 40a686e8e70f ("Add IPv6 support for lb health-check")
> Signed-off-by: Mark Michelson 
> ---
>  ovn-sb.xml | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/ovn-sb.xml b/ovn-sb.xml
> index e393f92b3..95733f99b 100644
> --- a/ovn-sb.xml
> +++ b/ovn-sb.xml
> @@ -4774,8 +4774,7 @@ tcp.flags = RST;
>Each row in this table configures monitoring a service for its
> liveness.
>The service can be an IPv4 TCP or UDP
>service. ovn-controller periodically sends out service
> -  monitor packets and updates the status of the service. Service
> monitoring
> -  for IPv6 services is not supported.
> +  monitor packets and updates the status of the service.
>  
>
>  
> @@ -4812,7 +4811,7 @@ tcp.flags = RST;
>
>
>
> -Source IPv4 address to use in the service monitor packet.
> +Source IPv4 or IPv6 address to use in the service monitor packet.
>
>
>
> --
> 2.43.0
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>

Looks good to me, thanks.

Acked-by: Ales Musil 


-- 

Ales Musil

Senior Software Engineer - OVN Core

Red Hat EMEA 

amu...@redhat.com

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev


[ovs-dev] [PATCH ovn] ovn-sb.xml: Remove IPv4-only restriction from Service Monitors.

2024-02-01 Thread Mark Michelson
The documentation for Service_Monitors in the southbound database state
that only IPv4 is supported. However, IPv6 service monitors have been
supported since OVN 23.03 was released.

This patch addresses the problem by removing the incorrect
documentation.

Fixes: 40a686e8e70f ("Add IPv6 support for lb health-check")
Signed-off-by: Mark Michelson 
---
 ovn-sb.xml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/ovn-sb.xml b/ovn-sb.xml
index e393f92b3..95733f99b 100644
--- a/ovn-sb.xml
+++ b/ovn-sb.xml
@@ -4774,8 +4774,7 @@ tcp.flags = RST;
   Each row in this table configures monitoring a service for its liveness.
   The service can be an IPv4 TCP or UDP
   service. ovn-controller periodically sends out service
-  monitor packets and updates the status of the service. Service monitoring
-  for IPv6 services is not supported.
+  monitor packets and updates the status of the service.
 
 
 
@@ -4812,7 +4811,7 @@ tcp.flags = RST;
   
 
   
-Source IPv4 address to use in the service monitor packet.
+Source IPv4 or IPv6 address to use in the service monitor packet.
   
 
   
-- 
2.43.0

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev