Re: [ovs-dev] [PATCH ovn] run CI for every commit when merging several commits, not for the latest.
Great! I see it works: https://github.com/ovn-org/ovn/commits/main > On Fri, Aug 5, 2022 at 1:05 AM Igor Zhukov wrote: > >> From: Igor Zhukov >> >> Docs: >> https://docs.github.com/en/actions/using-jobs/using-concurrency#example-using-a-fallback-value >> >> Test: https://github.com/fsb4000/ovn/actions and https://imgur.com/a/mUBQWSO >> >> Signed-off-by: Igor Zhukov > > Thanks. I applied this patch to the main branch. > > Numan > >> --- >> .github/workflows/ovn-kubernetes.yml | 2 +- >> .github/workflows/test.yml | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/.github/workflows/ovn-kubernetes.yml >> b/.github/workflows/ovn-kubernetes.yml >> index 03f35d7a3..32eb2350b 100644 >> --- a/.github/workflows/ovn-kubernetes.yml >> +++ b/.github/workflows/ovn-kubernetes.yml >> @@ -9,7 +9,7 @@ on: >> - cron: '0 0 * * 0' >> >> concurrency: >> - group: ${{ github.workflow }}-${{ github.event.pull_request.number || >> github.ref }} >> + group: ${{ github.workflow }}-${{ github.event.pull_request.number || >> github.run_id }} >> cancel-in-progress: true >> >> env: >> diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml >> index 3b7283229..76a7ce090 100644 >> --- a/.github/workflows/test.yml >> +++ b/.github/workflows/test.yml >> @@ -8,7 +8,7 @@ on: >> - cron: '0 0 * * 0' >> >> concurrency: >> - group: ${{ github.workflow }}-${{ github.event.pull_request.number || >> github.ref }} >> + group: ${{ github.workflow }}-${{ github.event.pull_request.number || >> github.run_id }} >> cancel-in-progress: true >> >> jobs: >> -- >> 2.30.2 >> >> ___ >> dev mailing list >> d...@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] run CI for every commit when merging several commits, not for the latest.
On Fri, Aug 5, 2022 at 1:05 AM Igor Zhukov wrote: > > From: Igor Zhukov > > Docs: > https://docs.github.com/en/actions/using-jobs/using-concurrency#example-using-a-fallback-value > > Test: https://github.com/fsb4000/ovn/actions and https://imgur.com/a/mUBQWSO > > Signed-off-by: Igor Zhukov Thanks. I applied this patch to the main branch. Numan > --- > .github/workflows/ovn-kubernetes.yml | 2 +- > .github/workflows/test.yml | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/.github/workflows/ovn-kubernetes.yml > b/.github/workflows/ovn-kubernetes.yml > index 03f35d7a3..32eb2350b 100644 > --- a/.github/workflows/ovn-kubernetes.yml > +++ b/.github/workflows/ovn-kubernetes.yml > @@ -9,7 +9,7 @@ on: >- cron: '0 0 * * 0' > > concurrency: > - group: ${{ github.workflow }}-${{ github.event.pull_request.number || > github.ref }} > + group: ${{ github.workflow }}-${{ github.event.pull_request.number || > github.run_id }} >cancel-in-progress: true > > env: > diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml > index 3b7283229..76a7ce090 100644 > --- a/.github/workflows/test.yml > +++ b/.github/workflows/test.yml > @@ -8,7 +8,7 @@ on: > - cron: '0 0 * * 0' > > concurrency: > - group: ${{ github.workflow }}-${{ github.event.pull_request.number || > github.ref }} > + group: ${{ github.workflow }}-${{ github.event.pull_request.number || > github.run_id }} >cancel-in-progress: true > > jobs: > -- > 2.30.2 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] run CI for every commit when merging several commits, not for the latest.
Bleep bloop. Greetings Igor Zhukov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 88 characters long (recommended limit is 79) #25 FILE: .github/workflows/ovn-kubernetes.yml:12: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }} WARNING: Line is 88 characters long (recommended limit is 79) #38 FILE: .github/workflows/test.yml:11: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }} Lines checked: 44, Warnings: 2, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH ovn] run CI for every commit when merging several commits, not for the latest.
From: Igor Zhukov Docs: https://docs.github.com/en/actions/using-jobs/using-concurrency#example-using-a-fallback-value Test: https://github.com/fsb4000/ovn/actions and https://imgur.com/a/mUBQWSO Signed-off-by: Igor Zhukov --- .github/workflows/ovn-kubernetes.yml | 2 +- .github/workflows/test.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ovn-kubernetes.yml b/.github/workflows/ovn-kubernetes.yml index 03f35d7a3..32eb2350b 100644 --- a/.github/workflows/ovn-kubernetes.yml +++ b/.github/workflows/ovn-kubernetes.yml @@ -9,7 +9,7 @@ on: - cron: '0 0 * * 0' concurrency: - group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} + group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }} cancel-in-progress: true env: diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 3b7283229..76a7ce090 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -8,7 +8,7 @@ on: - cron: '0 0 * * 0' concurrency: - group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} + group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }} cancel-in-progress: true jobs: -- 2.30.2 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev