Re: [ovs-dev] [PATCH ovn 0/3] Introduce check_pkt_len for ingress traffic
> On Wed, 2021-05-19 at 17:35 +0200, Lorenzo Bianconi wrote: > > In the current codebase, check_pkt_len is applied just for traffic > > leaving the > > ovn cluster. This series introduces the same capability for traffic > > entering > > the network from a gateway router or distributed gateway router port > > in order > > to send an ICMP error packet if the frame size is greater than the > > configured > > MTU. > > > > Lorenzo Bianconi (3): > > northd: introduce build_check_pkt_len_flows_for_lrp routine > > northd: enable check_pkt_len for gw router > > northd: add chec_pkt_len lflows for ingress traffic > > I know I said "check_pkt_len" a lot when talking about it internally, > but the commit messages should probably reference check_pkt_larger() > right? yes, correct. I mixed the ovn action and the kernel one, I will fix it in v2. Thanks. > > Also small nit, commit message for last patch is missing a "k" in > check. ack, I will fix it in v2. Regards, Lorenzo > > Thanks, > Dan > > > > > northd/ovn-northd.c | 236 +++-- > > tests/ovn-northd.at | 150 +++--- > > tests/ovn.at | 492 > > ++-- > > 3 files changed, 682 insertions(+), 196 deletions(-) > > > > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn 0/3] Introduce check_pkt_len for ingress traffic
On Wed, 2021-05-19 at 17:35 +0200, Lorenzo Bianconi wrote: > In the current codebase, check_pkt_len is applied just for traffic > leaving the > ovn cluster. This series introduces the same capability for traffic > entering > the network from a gateway router or distributed gateway router port > in order > to send an ICMP error packet if the frame size is greater than the > configured > MTU. > > Lorenzo Bianconi (3): > northd: introduce build_check_pkt_len_flows_for_lrp routine > northd: enable check_pkt_len for gw router > northd: add chec_pkt_len lflows for ingress traffic I know I said "check_pkt_len" a lot when talking about it internally, but the commit messages should probably reference check_pkt_larger() right? Also small nit, commit message for last patch is missing a "k" in check. Thanks, Dan > > northd/ovn-northd.c | 236 +++-- > tests/ovn-northd.at | 150 +++--- > tests/ovn.at | 492 > ++-- > 3 files changed, 682 insertions(+), 196 deletions(-) > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH ovn 0/3] Introduce check_pkt_len for ingress traffic
In the current codebase, check_pkt_len is applied just for traffic leaving the ovn cluster. This series introduces the same capability for traffic entering the network from a gateway router or distributed gateway router port in order to send an ICMP error packet if the frame size is greater than the configured MTU. Lorenzo Bianconi (3): northd: introduce build_check_pkt_len_flows_for_lrp routine northd: enable check_pkt_len for gw router northd: add chec_pkt_len lflows for ingress traffic northd/ovn-northd.c | 236 +++-- tests/ovn-northd.at | 150 +++--- tests/ovn.at| 492 ++-- 3 files changed, 682 insertions(+), 196 deletions(-) -- 2.31.1 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
