Re: [ovs-dev] [PATCH ovn 1/4] logical-fields: add rarp fields

[Numan Siddique]

On Mon, Oct 24, 2022 at 6:47 AM Felix Hüttner via dev
 wrote:
>
> We need to be able to handle rarp fields in order to ensure we can
> handle rarp messages we send ourselves.
> This will be used by the next patch in the series.
>
> Signed-off-by: Felix Huettner 

Acked-by: Numan Siddique 

Numan

> ---
>  lib/logical-fields.c | 8 
>  lib/ovn-util.c   | 2 +-
>  ovn-sb.xml   | 2 ++
>  3 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/lib/logical-fields.c b/lib/logical-fields.c
> index ed3ec62e1..fc131791e 100644
> --- a/lib/logical-fields.c
> +++ b/lib/logical-fields.c
> @@ -261,6 +261,14 @@ ovn_init_symtab(struct shash *symtab)
>  expr_symtab_add_field(symtab, "arp.tpa", MFF_ARP_TPA, "arp", false);
>  expr_symtab_add_field(symtab, "arp.tha", MFF_ARP_THA, "arp", false);
>
> +/* RARPs use the same layout as arp packets -> use the same field_id */
> +expr_symtab_add_predicate(symtab, "rarp", "eth.type == 0x8035");
> +expr_symtab_add_field(symtab, "rarp.op", MFF_ARP_OP, "rarp", false);
> +expr_symtab_add_field(symtab, "rarp.spa", MFF_ARP_SPA, "rarp", false);
> +expr_symtab_add_field(symtab, "rarp.sha", MFF_ARP_SHA, "rarp", false);
> +expr_symtab_add_field(symtab, "rarp.tpa", MFF_ARP_TPA, "rarp", false);
> +expr_symtab_add_field(symtab, "rarp.tha", MFF_ARP_THA, "rarp", false);
> +
>  expr_symtab_add_predicate(symtab, "nd",
>"icmp6.type == {135, 136} && icmp6.code == 0 && ip.ttl == 
> 255");
>  expr_symtab_add_predicate(symtab, "nd_ns",
> diff --git a/lib/ovn-util.c b/lib/ovn-util.c
> index 5dca72714..597625a29 100644
> --- a/lib/ovn-util.c
> +++ b/lib/ovn-util.c
> @@ -817,7 +817,7 @@ ip_address_and_port_from_lb_key(const char *key, char 
> **ip_address,
>   *
>   * This value is also used to handle some backward compatibility during
>   * upgrading. It should never decrease or rewind. */
> -#define OVN_INTERNAL_MINOR_VER 4
> +#define OVN_INTERNAL_MINOR_VER 5
>
>  /* Returns the OVN version. The caller must free the returned value. */
>  char *
> diff --git a/ovn-sb.xml b/ovn-sb.xml
> index 315d60853..42e6fa3ee 100644
> --- a/ovn-sb.xml
> +++ b/ovn-sb.xml
> @@ -1052,6 +1052,7 @@
>  ip4.src ip4.dst
>  ip6.src ip6.dst 
> ip6.label
>  arp.op arp.spa arp.tpa 
> arp.sha arp.tha
> +rarp.op rarp.spa rarp.tpa 
> rarp.sha rarp.tha
>  tcp.src tcp.dst 
> tcp.flags
>  udp.src udp.dst
>  sctp.src sctp.dst
> @@ -1115,6 +1116,7 @@
>  ip.later_frag expands to 
> ip.frag[1]
>  ip.first_frag expands to ip.is_frag 
>  !ip.later_frag
>  arp expands to eth.type == 0x806
> +rarp expands to eth.type == 0x8035
>  nd expands to icmp6.type == {135, 136} 
>  icmp6.code == 0  ip.ttl == 255
>  nd_ns expands to icmp6.type == 135  
> icmp6.code == 0  ip.ttl == 255
>  nd_na expands to icmp6.type == 136  
> icmp6.code == 0  ip.ttl == 255
> --
> 2.38.0
> Diese E Mail enthält möglicherweise vertrauliche Inhalte und ist nur für die 
> Verwertung durch den vorgesehenen Empfänger bestimmt. Sollten Sie nicht der 
> vorgesehene Empfänger sein, setzen Sie den Absender bitte unverzüglich in 
> Kenntnis und löschen diese E Mail. Hinweise zum Datenschutz finden Sie 
> hier.
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn 1/4] logical-fields: add rarp fields

[0-day Robot]

Bleep bloop.  Greetings Felix Hüttner, I am a robot and I have tried out your 
patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
ERROR: Author Felix Hüttner  needs to sign off.
WARNING: Unexpected sign-offs from developers who are not authors or co-authors 
or committers: Felix Huettner 
WARNING: Line is 125 characters long (recommended limit is 79)
#57 FILE: ovn-sb.xml:1055:
rarp.op rarp.spa rarp.tpa 
rarp.sha rarp.tha

Lines checked: 72, Warnings: 2, Errors: 1


Please check this out.  If you feel there has been an error, please email 
acon...@redhat.com

Thanks,
0-day Robot
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn 1/4] logical-fields: add rarp fields

[Felix Hüttner via dev]

We need to be able to handle rarp fields in order to ensure we can
handle rarp messages we send ourselves.
This will be used by the next patch in the series.

Signed-off-by: Felix Huettner 
---
 lib/logical-fields.c | 8 
 lib/ovn-util.c   | 2 +-
 ovn-sb.xml   | 2 ++
 3 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/lib/logical-fields.c b/lib/logical-fields.c
index ed3ec62e1..fc131791e 100644
--- a/lib/logical-fields.c
+++ b/lib/logical-fields.c
@@ -261,6 +261,14 @@ ovn_init_symtab(struct shash *symtab)
 expr_symtab_add_field(symtab, "arp.tpa", MFF_ARP_TPA, "arp", false);
 expr_symtab_add_field(symtab, "arp.tha", MFF_ARP_THA, "arp", false);

+/* RARPs use the same layout as arp packets -> use the same field_id */
+expr_symtab_add_predicate(symtab, "rarp", "eth.type == 0x8035");
+expr_symtab_add_field(symtab, "rarp.op", MFF_ARP_OP, "rarp", false);
+expr_symtab_add_field(symtab, "rarp.spa", MFF_ARP_SPA, "rarp", false);
+expr_symtab_add_field(symtab, "rarp.sha", MFF_ARP_SHA, "rarp", false);
+expr_symtab_add_field(symtab, "rarp.tpa", MFF_ARP_TPA, "rarp", false);
+expr_symtab_add_field(symtab, "rarp.tha", MFF_ARP_THA, "rarp", false);
+
 expr_symtab_add_predicate(symtab, "nd",
   "icmp6.type == {135, 136} && icmp6.code == 0 && ip.ttl == 255");
 expr_symtab_add_predicate(symtab, "nd_ns",
diff --git a/lib/ovn-util.c b/lib/ovn-util.c
index 5dca72714..597625a29 100644
--- a/lib/ovn-util.c
+++ b/lib/ovn-util.c
@@ -817,7 +817,7 @@ ip_address_and_port_from_lb_key(const char *key, char 
**ip_address,
  *
  * This value is also used to handle some backward compatibility during
  * upgrading. It should never decrease or rewind. */
-#define OVN_INTERNAL_MINOR_VER 4
+#define OVN_INTERNAL_MINOR_VER 5

 /* Returns the OVN version. The caller must free the returned value. */
 char *
diff --git a/ovn-sb.xml b/ovn-sb.xml
index 315d60853..42e6fa3ee 100644
--- a/ovn-sb.xml
+++ b/ovn-sb.xml
@@ -1052,6 +1052,7 @@
 ip4.src ip4.dst
 ip6.src ip6.dst 
ip6.label
 arp.op arp.spa arp.tpa 
arp.sha arp.tha
+rarp.op rarp.spa rarp.tpa 
rarp.sha rarp.tha
 tcp.src tcp.dst 
tcp.flags
 udp.src udp.dst
 sctp.src sctp.dst
@@ -1115,6 +1116,7 @@
 ip.later_frag expands to ip.frag[1]
 ip.first_frag expands to ip.is_frag  
!ip.later_frag
 arp expands to eth.type == 0x806
+rarp expands to eth.type == 0x8035
 nd expands to icmp6.type == {135, 136} 
 icmp6.code == 0  ip.ttl == 255
 nd_ns expands to icmp6.type == 135  
icmp6.code == 0  ip.ttl == 255
 nd_na expands to icmp6.type == 136  
icmp6.code == 0  ip.ttl == 255
--
2.38.0
Diese E Mail enthält möglicherweise vertrauliche Inhalte und ist nur für die 
Verwertung durch den vorgesehenen Empfänger bestimmt. Sollten Sie nicht der 
vorgesehene Empfänger sein, setzen Sie den Absender bitte unverzüglich in 
Kenntnis und löschen diese E Mail. Hinweise zum Datenschutz finden Sie 
hier.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev