Re: [ovs-dev] [PATCH ovn branch-23.03 1/5] Track ip version of tunnel in chassis_tunnel struct
On 6/6/23 21:07, Mark Michelson wrote: > For the series: > > Acked-by: Mark Michelson > > On 5/31/23 16:04, Ihar Hrachyshka wrote: >> This will be used in a later patch to calculate tunneling overhead for >> effective path MTU. >> >> Acked-by: Dumitru Ceara >> Signed-off-by: Ihar Hrachyshka >> Signed-off-by: Mark Michelson >> (cherry picked from commit 935034b4065b3ad052aa2b0d711254db53fcb938) >> --- Thanks, Ihar and Mark! I applied this to branch-23.03. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn branch-23.03 1/5] Track ip version of tunnel in chassis_tunnel struct
For the series: Acked-by: Mark Michelson On 5/31/23 16:04, Ihar Hrachyshka wrote: This will be used in a later patch to calculate tunneling overhead for effective path MTU. Acked-by: Dumitru Ceara Signed-off-by: Ihar Hrachyshka Signed-off-by: Mark Michelson (cherry picked from commit 935034b4065b3ad052aa2b0d711254db53fcb938) --- controller/local_data.c | 2 ++ controller/local_data.h | 1 + 2 files changed, 3 insertions(+) diff --git a/controller/local_data.c b/controller/local_data.c index acaf1de6d..cf0b21bb1 100644 --- a/controller/local_data.c +++ b/controller/local_data.c @@ -22,6 +22,7 @@ #include "lib/util.h" #include "lib/vswitch-idl.h" #include "openvswitch/vlog.h" +#include "socket-util.h" /* OVN includes. */ #include "encaps.h" @@ -447,6 +448,7 @@ local_nonvif_data_run(const struct ovsrec_bridge *br_int, tun->chassis_id = xstrdup(tunnel_id); tun->ofport = u16_to_ofp(ofport); tun->type = tunnel_type; +tun->is_ipv6 = ip ? addr_is_ipv6(ip) : false; free(hash_id); free(ip); diff --git a/controller/local_data.h b/controller/local_data.h index 748f009aa..ad0fa7f94 100644 --- a/controller/local_data.h +++ b/controller/local_data.h @@ -133,6 +133,7 @@ struct chassis_tunnel { char *chassis_id; ofp_port_t ofport; enum chassis_tunnel_type type; +bool is_ipv6; }; void local_nonvif_data_run(const struct ovsrec_bridge *br_int, ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn branch-23.03 1/5] Track ip version of tunnel in chassis_tunnel struct
Bleep bloop. Greetings Ihar Hrachyshka, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Mark Michelson Lines checked: 53, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH ovn branch-23.03 1/5] Track ip version of tunnel in chassis_tunnel struct
This will be used in a later patch to calculate tunneling overhead for effective path MTU. Acked-by: Dumitru Ceara Signed-off-by: Ihar Hrachyshka Signed-off-by: Mark Michelson (cherry picked from commit 935034b4065b3ad052aa2b0d711254db53fcb938) --- controller/local_data.c | 2 ++ controller/local_data.h | 1 + 2 files changed, 3 insertions(+) diff --git a/controller/local_data.c b/controller/local_data.c index acaf1de6d..cf0b21bb1 100644 --- a/controller/local_data.c +++ b/controller/local_data.c @@ -22,6 +22,7 @@ #include "lib/util.h" #include "lib/vswitch-idl.h" #include "openvswitch/vlog.h" +#include "socket-util.h" /* OVN includes. */ #include "encaps.h" @@ -447,6 +448,7 @@ local_nonvif_data_run(const struct ovsrec_bridge *br_int, tun->chassis_id = xstrdup(tunnel_id); tun->ofport = u16_to_ofp(ofport); tun->type = tunnel_type; +tun->is_ipv6 = ip ? addr_is_ipv6(ip) : false; free(hash_id); free(ip); diff --git a/controller/local_data.h b/controller/local_data.h index 748f009aa..ad0fa7f94 100644 --- a/controller/local_data.h +++ b/controller/local_data.h @@ -133,6 +133,7 @@ struct chassis_tunnel { char *chassis_id; ofp_port_t ofport; enum chassis_tunnel_type type; +bool is_ipv6; }; void local_nonvif_data_run(const struct ovsrec_bridge *br_int, -- 2.38.1 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev