Re: [ovs-dev] [PATCH ovn v2] .gitignore: ignore /compile_commands.json

2023-11-10 Thread Dumitru Ceara
On 10/31/23 18:33, Ihar Hrachyshka wrote:
> This is the standard clang JSON Compilation Database file name, as
> documented in:
> 
> https://clang.llvm.org/docs/JSONCompilationDatabase.html#build-system-integration
> 
> FYI the file is used by Language Server Protocol implementations and
> other AST tools.
> 
> Signed-off-by: Ihar Hrachyshka 
> ---
>  .gitignore | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/.gitignore b/.gitignore
> index 7ca9b3859..775bf0f09 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -42,6 +42,7 @@
>  /build-arch-stamp
>  /build-indep-stamp
>  /compile
> +/compile_commands.json
>  /config.guess
>  /config.h
>  /config.h.in

Hi Ihar,

As discussed offline, this probably fits better into a local gitignore
file as I'm guessing you'd need to do this for multiple (all?) repos you
contribute to.

I'm going to nack the patch for now.

Thanks,
Dumitru


___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev


[ovs-dev] [PATCH ovn v2] .gitignore: ignore /compile_commands.json

2023-10-31 Thread Ihar Hrachyshka
This is the standard clang JSON Compilation Database file name, as
documented in:

https://clang.llvm.org/docs/JSONCompilationDatabase.html#build-system-integration

FYI the file is used by Language Server Protocol implementations and
other AST tools.

Signed-off-by: Ihar Hrachyshka 
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index 7ca9b3859..775bf0f09 100644
--- a/.gitignore
+++ b/.gitignore
@@ -42,6 +42,7 @@
 /build-arch-stamp
 /build-indep-stamp
 /compile
+/compile_commands.json
 /config.guess
 /config.h
 /config.h.in
-- 
2.41.0

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev