Re: [ovs-dev] [PATCH ovn v2 7/7] ci: Replace clang jemalloc suite with system-test-userspace

2023-03-01 Thread Simon Horman
On Tue, Feb 21, 2023 at 01:32:07PM +0100, Ales Musil wrote:
> The test with jemalloc and clang is redundant as
> we are already testing jemalloc with gcc. Replace
> it with system-test-userspace which runs system tests
> over userspace OvS datapath.
> 
> Signed-off-by: Ales Musil 

FWIIW, I would prefer 2 patches, one for each change.
But in any case I did exercise this, and it did work.

Link: https://github.com/horms/ovn/actions/runs/4304595329

Tested-by: Simon Horman 

> ---
>  .github/workflows/test.yml | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
> index 0f8d9d193..90dc8a6f1 100644
> --- a/.github/workflows/test.yml
> +++ b/.github/workflows/test.yml
> @@ -47,9 +47,9 @@ jobs:
>  - { compiler: gcc, testsuite: test, libs: -ljemalloc, test_range: 
> "-500" }
>  - { compiler: gcc, testsuite: test, libs: -ljemalloc, test_range: 
> "501-1000" }
>  - { compiler: gcc, testsuite: test, libs: -ljemalloc, test_range: 
> "1001-" }
> -- { compiler: clang, testsuite: test, libs: -ljemalloc, test_range: 
> "-500" }
> -- { compiler: clang, testsuite: test, libs: -ljemalloc, test_range: 
> "501-1000" }
> -- { compiler: clang, testsuite: test, libs: -ljemalloc, test_range: 
> "1001-" }
> +- { compiler: gcc, testsuite: system-test-userspace, test_range: 
> "-100" }
> +- { compiler: gcc, testsuite: system-test-userspace, test_range: 
> "101-200" }
> +- { compiler: gcc, testsuite: system-test-userspace, test_range: 
> "201-" }
>  - { compiler: gcc, testsuite: system-test, test_range: "-100" }
>  - { compiler: gcc, testsuite: system-test, test_range: "101-200" }
>  - { compiler: gcc, testsuite: system-test, test_range: "201-" }
> -- 
> 2.39.1
> 
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> 
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev


Re: [ovs-dev] [PATCH ovn v2 7/7] ci: Replace clang jemalloc suite with system-test-userspace

2023-02-21 Thread 0-day Robot
Bleep bloop.  Greetings Ales Musil, I am a robot and I have tried out your 
patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 81 characters long (recommended limit is 79)
#27 FILE: .github/workflows/test.yml:50:
- { compiler: gcc, testsuite: system-test-userspace, test_range: "-100" 
}

WARNING: Line is 84 characters long (recommended limit is 79)
#28 FILE: .github/workflows/test.yml:51:
- { compiler: gcc, testsuite: system-test-userspace, test_range: 
"101-200" }

WARNING: Line is 81 characters long (recommended limit is 79)
#29 FILE: .github/workflows/test.yml:52:
- { compiler: gcc, testsuite: system-test-userspace, test_range: "201-" 
}

Lines checked: 36, Warnings: 3, Errors: 0


Please check this out.  If you feel there has been an error, please email 
acon...@redhat.com

Thanks,
0-day Robot
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev


[ovs-dev] [PATCH ovn v2 7/7] ci: Replace clang jemalloc suite with system-test-userspace

2023-02-21 Thread Ales Musil
The test with jemalloc and clang is redundant as
we are already testing jemalloc with gcc. Replace
it with system-test-userspace which runs system tests
over userspace OvS datapath.

Signed-off-by: Ales Musil 
---
 .github/workflows/test.yml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 0f8d9d193..90dc8a6f1 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -47,9 +47,9 @@ jobs:
 - { compiler: gcc, testsuite: test, libs: -ljemalloc, test_range: 
"-500" }
 - { compiler: gcc, testsuite: test, libs: -ljemalloc, test_range: 
"501-1000" }
 - { compiler: gcc, testsuite: test, libs: -ljemalloc, test_range: 
"1001-" }
-- { compiler: clang, testsuite: test, libs: -ljemalloc, test_range: 
"-500" }
-- { compiler: clang, testsuite: test, libs: -ljemalloc, test_range: 
"501-1000" }
-- { compiler: clang, testsuite: test, libs: -ljemalloc, test_range: 
"1001-" }
+- { compiler: gcc, testsuite: system-test-userspace, test_range: 
"-100" }
+- { compiler: gcc, testsuite: system-test-userspace, test_range: 
"101-200" }
+- { compiler: gcc, testsuite: system-test-userspace, test_range: 
"201-" }
 - { compiler: gcc, testsuite: system-test, test_range: "-100" }
 - { compiler: gcc, testsuite: system-test, test_range: "101-200" }
 - { compiler: gcc, testsuite: system-test, test_range: "201-" }
-- 
2.39.1

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev