Re: [ovs-dev] [PATCH ovn v3 0/2] Stabilize CI by pinning container, runner and Python versions.

2023-11-17 Thread Dumitru Ceara 
On 11/16/23 21:48, Mark Michelson wrote:
> On 11/16/23 12:35, Ales Musil wrote:
>>
>>
>> On Thu, Nov 16, 2023 at 6:26 PM Dumitru Ceara > > wrote:
>>
>>     All of the above were changed to track the latest available releases.
>>     Initially that seemed like a good idea but in practice, a new
>>     release would
>>     potentially (silently) cause CI runs that used to pass on given
>> stable
>>     versions to unexpectedly start failing.
>>
>>     To address that this series pins all versions we can control
>> allowing us
>>     to use different values for different branches [0].
>>
>>     NOTE: this series of patches will look slightly different on each
>> stable
>>     branch because we need to bump to different OVS stable branch tips
>> and
>>     we pin to different container and python versions on different stable
>>     branches.
>>
>>     NOTE2: this patch DOES NOT change the current behavior of always
>> using
>>     the CI container image we built from the main branch contents.  As
>>     discussed in the v2 of this series [1], that has issues so we need to
>>     follow up in the future.  Until then we just unblock CI.
>>
>>     [0]
>>     https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-23.09
>>     
>>     https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-23.06
>>     
>>     https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-23.03
>>     
>>     https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-22.12
>>     
>>     https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-22.09
>>     
>>     https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-22.06
>>     
>>     https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-22.03
>>     
>>
>>     [1]
>>    
>> https://mail.openvswitch.org/pipermail/ovs-dev/2023-November/409482.html 
>> 
>>
>>     Changes in v3:
>>     - dropped the patch that builds per-branch CI container images.
>>     Changes in v2:
>>     - added first patch to bump OVS submodule
>>     - addressed Ales' review comments:
>>    - moved the logic to determine which image to use out of ci.sh;
>>      it's now in the workflow itself.
>>    - moved setting of OVN_IMAGE in the same block with all related
>>      env vars
>>     - added a note for maintainers in the release process documentation
>>    to mention that the new workflow will likely have to be triggered
>>    manually (at least once) when branching for a new release.  GitHub
>>    doesn't allow periodic jobs on non-default branches.
>>
>>     Dumitru Ceara (2):
>>        ovs: Bump submodule to include E721 fixes.
>>        ci: Pin Python, Fedora and Ubuntu runner versions.
>>
>>
>>   .github/workflows/containers.yml               | 2 +-
>>   .github/workflows/ovn-fake-multinode-tests.yml | 6 +++---
>>   .github/workflows/ovn-kubernetes.yml           | 4 ++--
>>   .github/workflows/test.yml                     | 6 +++---
>>   utilities/containers/fedora/Dockerfile         | 2 +-
>>   5 files changed, 10 insertions(+), 10 deletions(-)
>>
>>
>> The series looks good to me, thanks.
>> I have only one question on 2/2.
>>
>> Acked-by: Ales Musil mailto:amu...@redhat.com>>
> Acked-by: Mark Michelson 
> 

Thanks, everyone!  I changed the registry back to quay.io for Fedora in
patch 2/2 and pushed this series to main.  I backported it to all
branches down to 22.03.

OVN self tests and system tests are green again on main.  CI is ongoing
on all branches.

Regards,
Dumitru

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn v3 0/2] Stabilize CI by pinning container, runner and Python versions.

2023-11-16 Thread Mark Michelson 

On 11/16/23 12:35, Ales Musil wrote:



On Thu, Nov 16, 2023 at 6:26 PM Dumitru Ceara > wrote:


All of the above were changed to track the latest available releases.
Initially that seemed like a good idea but in practice, a new
release would
potentially (silently) cause CI runs that used to pass on given stable
versions to unexpectedly start failing.

To address that this series pins all versions we can control allowing us
to use different values for different branches [0].

NOTE: this series of patches will look slightly different on each stable
branch because we need to bump to different OVS stable branch tips and
we pin to different container and python versions on different stable
branches.

NOTE2: this patch DOES NOT change the current behavior of always using
the CI container image we built from the main branch contents.  As
discussed in the v2 of this series [1], that has issues so we need to
follow up in the future.  Until then we just unblock CI.

[0]
https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-23.09

https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-23.06

https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-23.03

https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-22.12

https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-22.09

https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-22.06

https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-22.03


[1]
https://mail.openvswitch.org/pipermail/ovs-dev/2023-November/409482.html 


Changes in v3:
- dropped the patch that builds per-branch CI container images.
Changes in v2:
- added first patch to bump OVS submodule
- addressed Ales' review comments:
   - moved the logic to determine which image to use out of ci.sh;
     it's now in the workflow itself.
   - moved setting of OVN_IMAGE in the same block with all related
     env vars
- added a note for maintainers in the release process documentation
   to mention that the new workflow will likely have to be triggered
   manually (at least once) when branching for a new release.  GitHub
   doesn't allow periodic jobs on non-default branches.

Dumitru Ceara (2):
       ovs: Bump submodule to include E721 fixes.
       ci: Pin Python, Fedora and Ubuntu runner versions.


  .github/workflows/containers.yml               | 2 +-
  .github/workflows/ovn-fake-multinode-tests.yml | 6 +++---
  .github/workflows/ovn-kubernetes.yml           | 4 ++--
  .github/workflows/test.yml                     | 6 +++---
  utilities/containers/fedora/Dockerfile         | 2 +-
  5 files changed, 10 insertions(+), 10 deletions(-)


The series looks good to me, thanks.
I have only one question on 2/2.

Acked-by: Ales Musil mailto:amu...@redhat.com>>

Acked-by: Mark Michelson 




--

Ales Musil

Senior Software Engineer - OVN Core

Red Hat EMEA 

amu...@redhat.com 







___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn v3 0/2] Stabilize CI by pinning container, runner and Python versions.

2023-11-16 Thread Ales Musil 
On Thu, Nov 16, 2023 at 6:26 PM Dumitru Ceara  wrote:

> All of the above were changed to track the latest available releases.
> Initially that seemed like a good idea but in practice, a new release would
> potentially (silently) cause CI runs that used to pass on given stable
> versions to unexpectedly start failing.
>
> To address that this series pins all versions we can control allowing us
> to use different values for different branches [0].
>
> NOTE: this series of patches will look slightly different on each stable
> branch because we need to bump to different OVS stable branch tips and
> we pin to different container and python versions on different stable
> branches.
>
> NOTE2: this patch DOES NOT change the current behavior of always using
> the CI container image we built from the main branch contents.  As
> discussed in the v2 of this series [1], that has issues so we need to
> follow up in the future.  Until then we just unblock CI.
>
> [0]
> https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-23.09
> https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-23.06
> https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-23.03
> https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-22.12
> https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-22.09
> https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-22.06
> https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-22.03
>
> [1]
> https://mail.openvswitch.org/pipermail/ovs-dev/2023-November/409482.html
>
> Changes in v3:
> - dropped the patch that builds per-branch CI container images.
> Changes in v2:
> - added first patch to bump OVS submodule
> - addressed Ales' review comments:
>   - moved the logic to determine which image to use out of ci.sh;
> it's now in the workflow itself.
>   - moved setting of OVN_IMAGE in the same block with all related
> env vars
> - added a note for maintainers in the release process documentation
>   to mention that the new workflow will likely have to be triggered
>   manually (at least once) when branching for a new release.  GitHub
>   doesn't allow periodic jobs on non-default branches.
>
> Dumitru Ceara (2):
>   ovs: Bump submodule to include E721 fixes.
>   ci: Pin Python, Fedora and Ubuntu runner versions.
>
>
>  .github/workflows/containers.yml   | 2 +-
>  .github/workflows/ovn-fake-multinode-tests.yml | 6 +++---
>  .github/workflows/ovn-kubernetes.yml   | 4 ++--
>  .github/workflows/test.yml | 6 +++---
>  utilities/containers/fedora/Dockerfile | 2 +-
>  5 files changed, 10 insertions(+), 10 deletions(-)
>
>
The series looks good to me, thanks.
I have only one question on 2/2.

Acked-by: Ales Musil 


-- 

Ales Musil

Senior Software Engineer - OVN Core

Red Hat EMEA 

amu...@redhat.com

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn v3 0/2] Stabilize CI by pinning container, runner and Python versions.

2023-11-16 Thread Dumitru Ceara 
All of the above were changed to track the latest available releases.
Initially that seemed like a good idea but in practice, a new release would
potentially (silently) cause CI runs that used to pass on given stable
versions to unexpectedly start failing.

To address that this series pins all versions we can control allowing us
to use different values for different branches [0].

NOTE: this series of patches will look slightly different on each stable
branch because we need to bump to different OVS stable branch tips and
we pin to different container and python versions on different stable
branches.

NOTE2: this patch DOES NOT change the current behavior of always using
the CI container image we built from the main branch contents.  As
discussed in the v2 of this series [1], that has issues so we need to
follow up in the future.  Until then we just unblock CI.

[0]
https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-23.09
https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-23.06
https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-23.03
https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-22.12
https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-22.09
https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-22.06
https://github.com/dceara/ovn/tree/pin-versions-in-ci-v3-22.03

[1] https://mail.openvswitch.org/pipermail/ovs-dev/2023-November/409482.html

Changes in v3:
- dropped the patch that builds per-branch CI container images.
Changes in v2:
- added first patch to bump OVS submodule
- addressed Ales' review comments:
  - moved the logic to determine which image to use out of ci.sh;
it's now in the workflow itself.
  - moved setting of OVN_IMAGE in the same block with all related
env vars
- added a note for maintainers in the release process documentation
  to mention that the new workflow will likely have to be triggered
  manually (at least once) when branching for a new release.  GitHub
  doesn't allow periodic jobs on non-default branches.

Dumitru Ceara (2):
  ovs: Bump submodule to include E721 fixes.
  ci: Pin Python, Fedora and Ubuntu runner versions.


 .github/workflows/containers.yml   | 2 +-
 .github/workflows/ovn-fake-multinode-tests.yml | 6 +++---
 .github/workflows/ovn-kubernetes.yml   | 4 ++--
 .github/workflows/test.yml | 6 +++---
 utilities/containers/fedora/Dockerfile | 2 +-
 5 files changed, 10 insertions(+), 10 deletions(-)

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev