Re: [ovs-dev] [PATCH ovn v7 5/5] ovn-northd-ddlog: New implementation of ovn-northd based on ddlog.
On Thu, Nov 19, 2020 at 09:11:38AM +0100, Dumitru Ceara wrote: > On 11/19/20 6:13 AM, Ben Pfaff wrote: > > From: Leonid Ryzhyk > > > > This implementation is incremental, meaning that it only recalculates > > what is needed for the southbound database when northbound changes > > occur. It is expected to scale better than the C implementation, > > for large deployments. (This may take testing and tuning to be > > effective.) > > > > There are three tests that I'm having mysterious trouble getting > > to work with DDlog. For now, I've marked the testsuite to skip > > them unless RUN_ANYWAY=yes is set in the environment. > > > > Signed-off-by: Leonid Ryzhyk > > Co-authored-by: Justin Pettit > > Signed-off-by: Justin Pettit > > Co-authored-by: Ben Pfaff > > Signed-off-by: Ben Pfaff > > Acked-by: Dumitru Ceara > > Hi Ben, > > This is not a review, just a note that my "Acked-by" should probably go > to patch 2/5 "tests: Prepare for multiple northd types.". Unless I'm > mistaken, I didn't review the last patch of the series yet, except the > fact that I tried running the OVN tests. > > I'm not saying patch 5/5 "ovn-northd-ddlog: New implementation of > ovn-northd based on ddlog." is not good, just that I didn't review it yet :) Thanks, I misunderstood. I'll move the ack. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn v7 5/5] ovn-northd-ddlog: New implementation of ovn-northd based on ddlog.
On 11/19/20 6:13 AM, Ben Pfaff wrote: > From: Leonid Ryzhyk > > This implementation is incremental, meaning that it only recalculates > what is needed for the southbound database when northbound changes > occur. It is expected to scale better than the C implementation, > for large deployments. (This may take testing and tuning to be > effective.) > > There are three tests that I'm having mysterious trouble getting > to work with DDlog. For now, I've marked the testsuite to skip > them unless RUN_ANYWAY=yes is set in the environment. > > Signed-off-by: Leonid Ryzhyk > Co-authored-by: Justin Pettit > Signed-off-by: Justin Pettit > Co-authored-by: Ben Pfaff > Signed-off-by: Ben Pfaff > Acked-by: Dumitru Ceara Hi Ben, This is not a review, just a note that my "Acked-by" should probably go to patch 2/5 "tests: Prepare for multiple northd types.". Unless I'm mistaken, I didn't review the last patch of the series yet, except the fact that I tried running the OVN tests. I'm not saying patch 5/5 "ovn-northd-ddlog: New implementation of ovn-northd based on ddlog." is not good, just that I didn't review it yet :) Thanks, Dumitru ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn v7 5/5] ovn-northd-ddlog: New implementation of ovn-northd based on ddlog.
Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #4617 FILE: northd/ovn-northd-ddlog.c:1271: * XXX If the transaction we're sending to the database fails, then WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around operator #4821 FILE: northd/ovn-northd-ddlog.c:1475: --ovnnb-db=DATABASE connect to ovn-nb database at DATABASE\n\ WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around operator #4823 FILE: northd/ovn-northd-ddlog.c:1477: --ovnsb-db=DATABASE connect to ovn-sb database at DATABASE\n\ WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around operator #4825 FILE: northd/ovn-northd-ddlog.c:1479: --unixctl=SOCKET override default control socket name\n\ WARNING: Line has trailing whitespace #6561 FILE: northd/ovn_northd.dl:160: var l3dgw_port = peer.and_then(|p| p.router.l3dgw_port), Lines checked: 14371, Warnings: 10, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
