Re: [ovs-dev] [PATCH ovn v9 0/6] Add multiple routing tables support to Logical Routers
Thanks Numan! regards, Vladislav Odintsov > On 23 Nov 2021, at 00:35, Numan Siddique wrote: > > On Fri, Nov 19, 2021 at 11:07 AM Vladislav Odintsov > wrote: >> >> v8 -> v9: >> - Fix documentation errors. >> - Fix commit messages. >> >> v7 -> v8: >> - Updated manpages with and commit messages according to latest changes. >> - Small fixes. >> >> v6 -> v7: >> - Addressed Han's comments regarding saving same behaviour for route-tables >>static routes as for static routes from 'global' table. >>To address this 2 new patches were added (1, 2). >> - "global" table terminology was replaced with ''. >> >> v5 -> v6: >> - 2 memory leak bugs were fixed in ovn-ic code, which were introduced in >>previous versions of #3 patch. >> >> v4 -> v5: >> - Addressed Numan's review comments. >> >> v3 -> v4: >> - Minor logging typo fixes. >> - Added patch with ovn-ic routes learning bugfix. >> >> v2 -> v3: >> - Rebased on split northd changes. >> - Replaced route_tables HMAP with SIMAP as Numan suggested. >> - This series stil doesn't have ddlog support yet. >>It will take too much time for me to deal to ddlog language and specifics. >>Help with ddlog implementation wanted. >> >> v1 -> v2: >> - First patch of v1 patch series was applied, but new tests for new feature >>were added with strict table number check. Update this tests to be table >>number-independent. >> - Squash pathes for northd and utilities as tests don't pass without latter. >> - Add support for OVN IC routing table in routes advertisement/learning. >> - Patches `ic: remove port_binding on ts deletion` >> >> https://patchwork.ozlabs.org/project/ovn/patch/20210824184442.35063-1-odiv...@gmail.com/ >>and `ic: process only local port_bindings` >> >> https://patchwork.ozlabs.org/project/ovn/patch/20210830195707.98529-1-odiv...@gmail.com/ >>were already sent to list separately, but other changes are based on them >>so they're included. >>Once those patches are accepts, I can drop them from this series. >> - Added NEWS item. >> - Added myself to authors list. >> >> Vladislav Odintsov (6): >> northd: fix symmetric ECMP reply flows documentation >> ic: maintain route origin - connected/static >> northd: make connected routes have higher priority than static >> northd,utils: support for RouteTables in LRs >> ic: add support for routing tables in adv/learn routes >> ic: don't learn routes which have local GW >> >> NEWS| 4 + >> ic/ovn-ic.c | 592 ++-- >> lib/ovn-util.c | 2 +- >> lib/ovn-util.h | 3 + >> northd/northd.c | 192 ++--- >> northd/ovn-northd.8.xml | 80 -- >> ovn-ic-sb.ovsschema | 8 +- >> ovn-ic-sb.xml | 30 ++ >> ovn-nb.ovsschema| 5 +- >> ovn-nb.xml | 44 +++ >> tests/ovn-ic.at | 550 + >> tests/ovn-nbctl.at | 196 - >> tests/ovn-northd.at | 74 - >> tests/ovn.at| 546 +++- >> utilities/ovn-nbctl.c | 138 +- >> 15 files changed, 2181 insertions(+), 283 deletions(-) > > Thanks. I applied this patch series to the main branch. > > Numan > >> >> -- >> 2.30.0 >> >> ___ >> dev mailing list >> d...@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn v9 0/6] Add multiple routing tables support to Logical Routers
On Fri, Nov 19, 2021 at 11:07 AM Vladislav Odintsov wrote: > > v8 -> v9: > - Fix documentation errors. > - Fix commit messages. > > v7 -> v8: > - Updated manpages with and commit messages according to latest changes. > - Small fixes. > > v6 -> v7: > - Addressed Han's comments regarding saving same behaviour for route-tables > static routes as for static routes from 'global' table. > To address this 2 new patches were added (1, 2). > - "global" table terminology was replaced with ''. > > v5 -> v6: > - 2 memory leak bugs were fixed in ovn-ic code, which were introduced in > previous versions of #3 patch. > > v4 -> v5: > - Addressed Numan's review comments. > > v3 -> v4: > - Minor logging typo fixes. > - Added patch with ovn-ic routes learning bugfix. > > v2 -> v3: > - Rebased on split northd changes. > - Replaced route_tables HMAP with SIMAP as Numan suggested. > - This series stil doesn't have ddlog support yet. > It will take too much time for me to deal to ddlog language and specifics. > Help with ddlog implementation wanted. > > v1 -> v2: > - First patch of v1 patch series was applied, but new tests for new feature > were added with strict table number check. Update this tests to be table > number-independent. > - Squash pathes for northd and utilities as tests don't pass without latter. > - Add support for OVN IC routing table in routes advertisement/learning. > - Patches `ic: remove port_binding on ts deletion` > > https://patchwork.ozlabs.org/project/ovn/patch/20210824184442.35063-1-odiv...@gmail.com/ > and `ic: process only local port_bindings` > > https://patchwork.ozlabs.org/project/ovn/patch/20210830195707.98529-1-odiv...@gmail.com/ > were already sent to list separately, but other changes are based on them > so they're included. > Once those patches are accepts, I can drop them from this series. > - Added NEWS item. > - Added myself to authors list. > > Vladislav Odintsov (6): > northd: fix symmetric ECMP reply flows documentation > ic: maintain route origin - connected/static > northd: make connected routes have higher priority than static > northd,utils: support for RouteTables in LRs > ic: add support for routing tables in adv/learn routes > ic: don't learn routes which have local GW > > NEWS| 4 + > ic/ovn-ic.c | 592 ++-- > lib/ovn-util.c | 2 +- > lib/ovn-util.h | 3 + > northd/northd.c | 192 ++--- > northd/ovn-northd.8.xml | 80 -- > ovn-ic-sb.ovsschema | 8 +- > ovn-ic-sb.xml | 30 ++ > ovn-nb.ovsschema| 5 +- > ovn-nb.xml | 44 +++ > tests/ovn-ic.at | 550 + > tests/ovn-nbctl.at | 196 - > tests/ovn-northd.at | 74 - > tests/ovn.at| 546 +++- > utilities/ovn-nbctl.c | 138 +- > 15 files changed, 2181 insertions(+), 283 deletions(-) Thanks. I applied this patch series to the main branch. Numan > > -- > 2.30.0 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH ovn v9 0/6] Add multiple routing tables support to Logical Routers
v8 -> v9: - Fix documentation errors. - Fix commit messages. v7 -> v8: - Updated manpages with and commit messages according to latest changes. - Small fixes. v6 -> v7: - Addressed Han's comments regarding saving same behaviour for route-tables static routes as for static routes from 'global' table. To address this 2 new patches were added (1, 2). - "global" table terminology was replaced with ''. v5 -> v6: - 2 memory leak bugs were fixed in ovn-ic code, which were introduced in previous versions of #3 patch. v4 -> v5: - Addressed Numan's review comments. v3 -> v4: - Minor logging typo fixes. - Added patch with ovn-ic routes learning bugfix. v2 -> v3: - Rebased on split northd changes. - Replaced route_tables HMAP with SIMAP as Numan suggested. - This series stil doesn't have ddlog support yet. It will take too much time for me to deal to ddlog language and specifics. Help with ddlog implementation wanted. v1 -> v2: - First patch of v1 patch series was applied, but new tests for new feature were added with strict table number check. Update this tests to be table number-independent. - Squash pathes for northd and utilities as tests don't pass without latter. - Add support for OVN IC routing table in routes advertisement/learning. - Patches `ic: remove port_binding on ts deletion` https://patchwork.ozlabs.org/project/ovn/patch/20210824184442.35063-1-odiv...@gmail.com/ and `ic: process only local port_bindings` https://patchwork.ozlabs.org/project/ovn/patch/20210830195707.98529-1-odiv...@gmail.com/ were already sent to list separately, but other changes are based on them so they're included. Once those patches are accepts, I can drop them from this series. - Added NEWS item. - Added myself to authors list. Vladislav Odintsov (6): northd: fix symmetric ECMP reply flows documentation ic: maintain route origin - connected/static northd: make connected routes have higher priority than static northd,utils: support for RouteTables in LRs ic: add support for routing tables in adv/learn routes ic: don't learn routes which have local GW NEWS| 4 + ic/ovn-ic.c | 592 ++-- lib/ovn-util.c | 2 +- lib/ovn-util.h | 3 + northd/northd.c | 192 ++--- northd/ovn-northd.8.xml | 80 -- ovn-ic-sb.ovsschema | 8 +- ovn-ic-sb.xml | 30 ++ ovn-nb.ovsschema| 5 +- ovn-nb.xml | 44 +++ tests/ovn-ic.at | 550 + tests/ovn-nbctl.at | 196 - tests/ovn-northd.at | 74 - tests/ovn.at| 546 +++- utilities/ovn-nbctl.c | 138 +- 15 files changed, 2181 insertions(+), 283 deletions(-) -- 2.30.0 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev